linux/drivers/soc/fsl
Sean Anderson 9a3ca8292c soc: fsl: qbman: Use raw spinlock for cgr_lock
[ Upstream commit fbec4e7fed ]

smp_call_function always runs its callback in hard IRQ context, even on
PREEMPT_RT, where spinlocks can sleep. So we need to use a raw spinlock
for cgr_lock to ensure we aren't waiting on a sleeping task.

Although this bug has existed for a while, it was not apparent until
commit ef2a8d5478 ("net: dpaa: Adjust queue depth on rate change")
which invokes smp_call_function_single via qman_update_cgr_safe every
time a link goes up or down.

Fixes: 96f413f476 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()")
CC: stable@vger.kernel.org
Reported-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Closes: https://lore.kernel.org/all/20230323153935.nofnjucqjqnz34ej@skbuf/
Reported-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Closes: https://lore.kernel.org/linux-arm-kernel/87wmsyvclu.fsf@pengutronix.de/
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-04-10 16:18:42 +02:00
..
dpio soc: fsl: dpio: fix kcalloc() argument order 2024-03-26 18:21:35 -04:00
qbman soc: fsl: qbman: Use raw spinlock for cgr_lock 2024-04-10 16:18:42 +02:00
qe soc/fsl/qe: fix usb.c build errors 2023-07-23 13:47:04 +02:00
dpaa2-console.c soc: fsl: dpaa2-console: free buffer before returning from dpaa2_console_read 2021-11-18 19:17:02 +01:00
guts.c soc: fsl: guts: machine variable might be unset 2022-08-17 14:23:08 +02:00
Kconfig soc: fsl: select FSL_GUTS driver for DPIO 2022-09-20 12:39:46 +02:00
Makefile soc: fsl: add RCPM driver 2019-11-12 15:26:05 -06:00
rcpm.c soc: fsl: enable acpi support in RCPM driver 2021-04-08 16:34:15 -05:00