Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Zhang Rui 8403021b6f thermal: intel: int340x: processor: Fix warning during module unload ... [ Upstream commit 99ca0b57e4 ] The processor_thermal driver uses pcim_device_enable() to enable a PCI device, which means the device will be automatically disabled on driver detach. Thus there is no need to call pci_disable_device() again on it. With recent PCI device resource management improvements, e.g. commit f748a07a0b ("PCI: Remove legacy pcim_release()"), this problem is exposed and triggers the warining below. [ 224.010735] proc_thermal_pci 0000:00:04.0: disabling already-disabled device [ 224.010747] WARNING: CPU: 8 PID: 4442 at drivers/pci/pci.c:2250 pci_disable_device+0xe5/0x100 ... [ 224.010844] Call Trace: [ 224.010845] <TASK> [ 224.010847] ? show_regs+0x6d/0x80 [ 224.010851] ? __warn+0x8c/0x140 [ 224.010854] ? pci_disable_device+0xe5/0x100 [ 224.010856] ? report_bug+0x1c9/0x1e0 [ 224.010859] ? handle_bug+0x46/0x80 [ 224.010862] ? exc_invalid_op+0x1d/0x80 [ 224.010863] ? asm_exc_invalid_op+0x1f/0x30 [ 224.010867] ? pci_disable_device+0xe5/0x100 [ 224.010869] ? pci_disable_device+0xe5/0x100 [ 224.010871] ? kfree+0x21a/0x2b0 [ 224.010873] pcim_disable_device+0x20/0x30 [ 224.010875] devm_action_release+0x16/0x20 [ 224.010878] release_nodes+0x47/0xc0 [ 224.010880] devres_release_all+0x9f/0xe0 [ 224.010883] device_unbind_cleanup+0x12/0x80 [ 224.010885] device_release_driver_internal+0x1ca/0x210 [ 224.010887] driver_detach+0x4e/0xa0 [ 224.010889] bus_remove_driver+0x6f/0xf0 [ 224.010890] driver_unregister+0x35/0x60 [ 224.010892] pci_unregister_driver+0x44/0x90 [ 224.010894] proc_thermal_pci_driver_exit+0x14/0x5f0 [processor_thermal_device_pci] ... [ 224.010921] ---[ end trace 0000000000000000 ]--- Remove the excess pci_disable_device() calls. Fixes: acd65d5d1c ("thermal/drivers/int340x/processor_thermal: Add PCI MMIO based thermal driver") Signed-off-by: Zhang Rui <rui.zhang@intel.com> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Link: https://patch.msgid.link/20240930081801.28502-3-rui.zhang@intel.com [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2024-10-17 15:11:54 +02:00
..
int340x_thermal	thermal: intel: int340x: processor: Fix warning during module unload	2024-10-17 15:11:54 +02:00
intel_bxt_pmic_thermal.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
intel_menlow.c	thermal/drivers/intel: Move intel_menlow to thermal drivers	2021-08-17 14:11:48 +02:00
intel_pch_thermal.c	thermal: intel: intel_pch: Add support for Wellsburg PCH	2023-03-10 09:39:49 +01:00
intel_powerclamp.c	thermal: intel: powerclamp: Fix cur_state for multi package system	2023-03-10 09:40:06 +01:00
intel_quark_dts_thermal.c	thermal: intel: quark_dts: fix error pointer dereference	2023-03-11 13:57:32 +01:00
intel_soc_dts_iosf.c	thermal: intel: Fix unsigned comparison with less than zero	2023-03-10 09:39:47 +01:00
intel_soc_dts_iosf.h	thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro	2019-12-04 19:44:12 -08:00
intel_soc_dts_thermal.c	thermal: Convert to new X86 CPU match macros	2020-03-24 21:33:53 +01:00
intel_tcc_cooling.c	drivers/thermal/intel: Add TCC cooling support for AlderLake platform	2021-08-14 12:41:36 +02:00
Kconfig	thermal: intel: BXT_PMIC: select REGMAP instead of depending on it	2023-03-11 13:57:32 +01:00
Makefile	thermal/drivers/intel: Move intel_menlow to thermal drivers	2021-08-17 14:11:48 +02:00
therm_throt.c	thermal/drivers/intel: Allow processing of HWP interrupt	2021-09-09 16:33:20 +02:00
thermal_interrupt.h	thermal/drivers/intel: Allow processing of HWP interrupt	2021-09-09 16:33:20 +02:00
x86_pkg_temp_thermal.c	thermal/drivers/intel: Initialize RW trip to THERMAL_TEMP_INVALID	2021-05-14 09:37:27 +02:00