Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Jiri Slaby b125b08dbe mxser: fix xmit_buf leak in activate when LSR == 0xff ...

[ Upstream commit cd3a4907ee ]

When LSR is 0xff in ->activate() (rather unlike), we return an error.
Provided ->shutdown() is not called when ->activate() fails, nothing
actually frees the buffer in this case.

Fix this by properly freeing the buffer in a designated label. We jump
there also from the "!info->type" if now too.

Fixes: 6769140d30 ("tty: mxser: use the tty_port_open method")
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220124071430.14907-6-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-04-08 14:23:43 +02:00

2027 lines

52 KiB

Raw Permalink Blame History