kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-22 19:14:51 +00:00
Code Issues Releases Packages Activity
linux/drivers/comedi/drivers
History
Ian Abbott 87e1ee6058 comedi: adv_pci1760: Fix PWM instruction handling 
commit 2efb6edd52 upstream.

(Actually, this is fixing the "Read the Current Status" command sent to
the device's outgoing mailbox, but it is only currently used for the PWM
instructions.)

The PCI-1760 is operated mostly by sending commands to a set of Outgoing
Mailbox registers, waiting for the command to complete, and reading the
result from the Incoming Mailbox registers.  One of these commands is
the "Read the Current Status" command.  The number of this command is
0x07 (see the User's Manual for the PCI-1760 at
<https://advdownload.advantech.com/productfile/Downloadfile2/1-11P6653/PCI-1760.pdf>.
The `PCI1760_CMD_GET_STATUS` macro defined in the driver should expand
to this command number 0x07, but unfortunately it currently expands to
0x03.  (Command number 0x03 is not defined in the User's Manual.)
Correct the definition of the `PCI1760_CMD_GET_STATUS` macro to fix it.

This is used by all the PWM subdevice related instructions handled by
`pci1760_pwm_insn_config()` which are probably all broken.  The effect
of sending the undefined command number 0x03 is not known.

Fixes: 14b93bb6bb ("staging: comedi: adv_pci_dio: separate out PCI-1760 support")
Cc: <stable@vger.kernel.org> # v4.5+
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20230103143754.17564-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2023-01-24 07:22:45 +01:00
..
ni_routing comedi: remove editor modelines and cruft (again) 2021-05-13 20:31:44 +02:00
tests comedi: remove editor modelines and cruft (again) 2021-05-13 20:31:44 +02:00
8255.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
8255.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
8255_pci.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_3xxx.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_16xx.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_1032.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_1500.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_1516.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_1564.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_2032.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_2200.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_3120.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_apci_3501.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_tcw.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_watchdog.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_watchdog.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adl_pci7x3x.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adl_pci6208.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adl_pci8164.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adl_pci9111.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adl_pci9118.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adq12b.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adv_pci1710.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adv_pci1720.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adv_pci1723.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adv_pci1724.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adv_pci1760.c comedi: adv_pci1760: Fix PWM instruction handling 2023-01-24 07:22:45 +01:00
adv_pci_dio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
aio_aio12_8.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
aio_iiro_16.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amcc_s5933.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_dio200.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_dio200.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_dio200_common.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_dio200_pci.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pc236.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pc236.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pc236_common.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pc263.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pci224.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pci230.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pci236.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pci263.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
c6xdigio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
cb_das16_cs.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
cb_pcidas.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
cb_pcidas64.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
cb_pcidda.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
cb_pcimdas.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
cb_pcimdda.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
comedi_8254.c comedi: comedi_8254: Fix descriptions for 'i8254' and 'iobase' 2021-05-21 14:38:44 +02:00
comedi_8254.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
comedi_8255.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
comedi_bond.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
comedi_isadma.c comedi: drivers: comedi_isadma: Fix misspelling of 'dma_chan1' 2021-05-21 14:38:44 +02:00
comedi_isadma.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
comedi_parport.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
comedi_test.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
contec_pci_dio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dac02.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
daqboard2000.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das08.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das08.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das08_cs.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das08_isa.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das08_pci.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das16.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das16m1.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das800.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das1800.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das6402.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dmm32at.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt282x.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt2801.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt2811.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt2814.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt2815.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt2817.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt3000.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
dt9812.c comedi: dt9812: fix DMA buffers on stack 2021-11-12 15:05:50 +01:00
dyna_pci10xx.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
fl512.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
gsc_hpdi.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
icp_multi.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ii_pci20kc.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
jr3_pci.c staging: comedi: Remove unused variable ‘min_full_scale’ and function 'get_min_full_scales' 2021-05-19 18:00:24 +02:00
jr3_pci.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ke_counter.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
Makefile staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
me4000.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
me_daq.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
mf6x4.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
mite.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
mite.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
mpc624.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
multiq3.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_65xx.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_660x.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_670x.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_6527.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_at_a2150.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_at_ao.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_atmio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_atmio16d.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_daq_700.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_daq_dio24.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_common.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_cs.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_isadma.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_isadma.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_pci.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_regs.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_mio_common.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_mio_cs.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_pcidio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_pcimio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_routes.c comedi: drivers: ni_routes: Demote non-conforming kernel-doc headers 2021-05-21 14:38:44 +02:00
ni_routes.h comedi: remove editor modelines and cruft (again) 2021-05-13 20:31:44 +02:00
ni_stc.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_tio.c comedi: drivers: ni_tio: Fix slightly broken kernel-doc and demote others 2021-05-21 14:38:44 +02:00
ni_tio.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_tio_internal.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_tiocmd.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_usb6501.c comedi: ni_usb6501: fix NULL-deref in command paths 2021-11-12 15:05:50 +01:00
pcl711.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcl724.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcl726.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcl730.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcl812.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcl816.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcl818.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcm3724.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcmad.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcmda12.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcmmio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
pcmuio.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
plx9052.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
plx9080.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
quatech_daqp_cs.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
rtd520.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
rti800.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
rti802.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
s526.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
s626.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
s626.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ssv_dnp.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
usbdux.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
usbduxfast.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
usbduxsigma.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
vmk80xx.c comedi: vmk80xx: fix expression for tx buffer size 2022-06-22 14:22:03 +02:00
z8536.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00