Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Yishai Hadas bba6b12d73 vfio: Split migration ops from main device ops ... [ Upstream commit 6e97eba8ad ] vfio core checks whether the driver sets some migration op (e.g. set_state/get_state) and accordingly calls its op. However, currently mlx5 driver sets the above ops without regards to its migration caps. This might lead to unexpected usage/Oops if user space may call to the above ops even if the driver doesn't support migration. As for example, the migration state_mutex is not initialized in that case. The cleanest way to manage that seems to split the migration ops from the main device ops, this will let the driver setting them separately from the main ops when it's applicable. As part of that, validate ops construction on registration and include a check for VFIO_MIGRATION_STOP_COPY since the uAPI claims it must be set in migration_flags. HISI driver was changed as well to match this scheme. This scheme may enable down the road to come with some extra group of ops (e.g. DMA log) that can be set without regards to the other options based on driver caps. Fixes: 6fadb02126 ("vfio/mlx5: Implement vfio_pci driver for mlx5 devices") Reviewed-by: Kevin Tian <kevin.tian@intel.com> Signed-off-by: Yishai Hadas <yishaih@nvidia.com> Link: https://lore.kernel.org/r/20220628155910.171454-3-yishaih@nvidia.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2022-08-17 15:15:48 +02:00
..
fsl-mc	vfio: Set DMA ownership for VFIO devices	2022-04-28 15:32:20 +02:00
mdev	vfio/mdev: Use the driver core to create the 'remove' file	2022-04-21 07:36:56 -04:00
pci	vfio: Split migration ops from main device ops	2022-08-17 15:15:48 +02:00
platform	vfio: Set DMA ownership for VFIO devices	2022-04-28 15:32:20 +02:00
Kconfig	vfio: Use kconfig if XX/endif blocks instead of repeating 'depends on'	2021-08-26 10:36:51 -06:00
Makefile	vfio/fsl-mc: Add VFIO framework skeleton for fsl-mc devices	2020-10-07 14:17:33 -06:00
vfio.c	vfio: Split migration ops from main device ops	2022-08-17 15:15:48 +02:00
vfio.h	vfio: clean up the check for mediated device in vfio_iommu_type1	2021-09-30 12:46:44 -06:00
vfio_iommu_spapr_tce.c	vfio/spapr_tce: reject mediated devices	2021-09-30 12:46:44 -06:00
vfio_iommu_type1.c	vfio: Move the Intel no-snoop control off of IOMMU_CACHE	2022-04-28 17:24:57 +02:00
vfio_spapr_eeh.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
virqfd.c	vfio/virqfd: Drain events from eventfd in virqfd_wakeup()	2020-11-15 09:49:10 -05:00