kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-16 22:39:48 +00:00
Code Issues Releases Packages Activity
linux/drivers/vfio/pci
History
Yishai Hadas bba6b12d73 vfio: Split migration ops from main device ops 
[ Upstream commit 6e97eba8ad ]

vfio core checks whether the driver sets some migration op (e.g.
set_state/get_state) and accordingly calls its op.

However, currently mlx5 driver sets the above ops without regards to its
migration caps.

This might lead to unexpected usage/Oops if user space may call to the
above ops even if the driver doesn't support migration. As for example,
the migration state_mutex is not initialized in that case.

The cleanest way to manage that seems to split the migration ops from
the main device ops, this will let the driver setting them separately
from the main ops when it's applicable.

As part of that, validate ops construction on registration and include a
check for VFIO_MIGRATION_STOP_COPY since the uAPI claims it must be set
in migration_flags.

HISI driver was changed as well to match this scheme.

This scheme may enable down the road to come with some extra group of
ops (e.g. DMA log) that can be set without regards to the other options
based on driver caps.

Fixes: 6fadb02126 ("vfio/mlx5: Implement vfio_pci driver for mlx5 devices")
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Link: https://lore.kernel.org/r/20220628155910.171454-3-yishaih@nvidia.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2022-08-17 15:15:48 +02:00
..
hisilicon vfio: Split migration ops from main device ops 2022-08-17 15:15:48 +02:00
mlx5 vfio: Split migration ops from main device ops 2022-08-17 15:15:48 +02:00
Kconfig hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices 2022-03-15 11:34:08 -06:00
Makefile hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices 2022-03-15 11:34:08 -06:00
trace.h vfio/pci: Cleanup license mess 2019-01-22 11:06:05 -07:00
vfio_pci.c Merge remote-tracking branch 'iommu/vfio-notifier-fix' into v5.19/vfio/next 2022-05-13 10:04:22 -06:00
vfio_pci_config.c vfio/pci: Virtualize PME related registers bits and initialize to zero 2022-05-18 10:00:48 -06:00
vfio_pci_core.c vfio: Split migration ops from main device ops 2022-08-17 15:15:48 +02:00
vfio_pci_igd.c vfio/pci: Resolve sparse endian warnings in IGD support 2021-12-21 12:30:31 -07:00
vfio_pci_intrs.c vfio/pci: Introduce vfio_pci_core.ko 2021-08-26 10:36:51 -06:00
vfio_pci_rdwr.c vfio/pci: Stub vfio_pci_vga_rw when !CONFIG_VFIO_PCI_VGA 2022-02-22 13:45:02 -07:00
vfio_pci_zdev.c Merge branches 'v5.15/vfio/spdx-license-cleanups', 'v5.15/vfio/dma-valid-waited-v3', 'v5.15/vfio/vfio-pci-core-v5' and 'v5.15/vfio/vfio-ap' into v5.15/vfio/next 2021-08-26 11:08:50 -06:00