linux/drivers/i3c/master
Kaixin Wang 2a21bad996 i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition
commit 609366e7a0 upstream.

In the cdns_i3c_master_probe function, &master->hj_work is bound with
cdns_i3c_master_hj. And cdns_i3c_master_interrupt can call
cnds_i3c_master_demux_ibis function to start the work.

If we remove the module which will call cdns_i3c_master_remove to
make cleanup, it will free master->base through i3c_master_unregister
while the work mentioned above will be used. The sequence of operations
that may lead to a UAF bug is as follows:

CPU0                                      CPU1

                                     | cdns_i3c_master_hj
cdns_i3c_master_remove               |
i3c_master_unregister(&master->base) |
device_unregister(&master->dev)      |
device_release                       |
//free master->base                  |
                                     | i3c_master_do_daa(&master->base)
                                     | //use master->base

Fix it by ensuring that the work is canceled before proceeding with
the cleanup in cdns_i3c_master_remove.

Signed-off-by: Kaixin Wang <kxwang23@m.fudan.edu.cn>
Link: https://lore.kernel.org/r/20240911153544.848398-1-kxwang23@m.fudan.edu.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2025-02-21 13:50:10 +01:00
..
mipi-i3c-hci i3c: mipi-i3c-hci: Mask ring interrupts before ring stop request 2024-12-14 19:54:47 +01:00
dw-i3c-master.c i3c: Make i3c_master_unregister() return void 2024-12-14 19:54:26 +01:00
i3c-master-cdns.c i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition 2025-02-21 13:50:10 +01:00
Kconfig i3c: master: svc: Add Silvaco I3C master driver 2021-02-06 00:43:29 +01:00
Makefile i3c: master: svc: Add Silvaco I3C master driver 2021-02-06 00:43:29 +01:00
svc-i3c-master.c i3c: master: svc: Fix use after free vulnerability in svc_i3c_master Driver Due to Race Condition 2024-12-14 19:54:56 +01:00