kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-22 19:14:51 +00:00
Code Issues Releases Packages Activity
linux/drivers/comedi/drivers
History
Edward Adam Davis 5a33d07c94 comedi: pcl726: Prevent invalid irq number 
commit 96cb948408 upstream.

The reproducer passed in an irq number(0x80008000) that was too large,
which triggered the oob.

Added an interrupt number check to prevent users from passing in an irq
number that was too large.

If `it->options[1]` is 31, then `1 << it->options[1]` is still invalid
because it shifts a 1-bit into the sign bit (which is UB in C).
Possible solutions include reducing the upper bound on the
`it->options[1]` value to 30 or lower, or using `1U << it->options[1]`.

The old code would just not attempt to request the IRQ if the
`options[1]` value were invalid.  And it would still configure the
device without interrupts even if the call to `request_irq` returned an
error.  So it would be better to combine this test with the test below.

Fixes: fff4620724 ("staging: comedi: pcl726: enable the interrupt support code")
Cc: stable <stable@kernel.org> # 5.13+
Reported-by: syzbot+5cd373521edd68bebcb3@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=5cd373521edd68bebcb3
Tested-by: syzbot+5cd373521edd68bebcb3@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/tencent_3C66983CC1369E962436264A50759176BF09@qq.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2025-08-28 16:26:14 +02:00
..
ni_routing comedi: ni_routing: tools: Check when the file could not be opened 2024-10-17 15:22:16 +02:00
tests comedi: remove editor modelines and cruft (again) 2021-05-13 20:31:44 +02:00
8255.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
8255_pci.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
addi_apci_3xxx.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_16xx.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_1032.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_1500.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_1516.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_1564.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_2032.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_2200.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_3120.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_apci_3501.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_tcw.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
addi_watchdog.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
addi_watchdog.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
adl_pci7x3x.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adl_pci6208.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adl_pci8164.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adl_pci9111.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
adl_pci9118.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
adq12b.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adv_pci1710.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
adv_pci1720.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adv_pci1723.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adv_pci1724.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
adv_pci1760.c comedi: adv_pci1760: Fix PWM instruction handling 2023-01-24 07:24:35 +01:00
adv_pci_dio.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
aio_aio12_8.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
aio_iiro_16.c comedi: aio_iiro_16: Fix bit shift out of bounds 2025-07-24 08:51:50 +02:00
amcc_s5933.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_dio200.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
amplc_dio200.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_dio200_common.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
amplc_dio200_pci.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
amplc_pc236.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
amplc_pc236.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
amplc_pc236_common.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
amplc_pc263.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
amplc_pci224.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
amplc_pci230.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
amplc_pci236.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
amplc_pci263.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
c6xdigio.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
cb_das16_cs.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
cb_pcidas.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
cb_pcidas64.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
cb_pcidda.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
cb_pcimdas.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
cb_pcimdda.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
comedi_8254.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
comedi_8255.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
comedi_bond.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
comedi_isadma.c PCI: Move isa_dma_bridge_buggy out of asm/dma.h 2022-07-22 17:24:47 -05:00
comedi_parport.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
comedi_test.c comedi: comedi_test: Fix possible deletion of uninitialized timers 2025-08-15 12:04:50 +02:00
contec_pci_dio.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dac02.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
daqboard2000.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
das08.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
das08.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
das08_cs.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
das08_isa.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
das08_pci.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
das16.c comedi: das16: Use struct_size() helper in comedi_alloc_spriv() 2022-01-26 14:16:16 +01:00
das16m1.c comedi: das16m1: Fix bit shift out of bounds 2025-07-24 08:51:50 +02:00
das800.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
das1800.c comedi: Move "comedi_isadma.h" to <linux/comedi/comedi_isadma.h> 2021-11-26 16:48:59 +01:00
das6402.c comedi: das6402: Fix bit shift out of bounds 2025-07-24 08:51:50 +02:00
dmm32at.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
dt282x.c comedi: Move "comedi_isadma.h" to <linux/comedi/comedi_isadma.h> 2021-11-26 16:48:59 +01:00
dt2801.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dt2811.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dt2814.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dt2815.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dt2817.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dt3000.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dt9812.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
dyna_pci10xx.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
fl512.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
gsc_hpdi.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
icp_multi.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ii_pci20kc.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
jr3_pci.c comedi: jr3_pci: Fix synchronous deletion of timer 2025-05-02 07:47:08 +02:00
jr3_pci.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ke_counter.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
Makefile staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
me4000.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
me_daq.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
mf6x4.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
mite.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
mite.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
mpc624.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
multiq3.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_65xx.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_660x.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_670x.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_6527.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_at_a2150.c comedi: Move "comedi_isadma.h" to <linux/comedi/comedi_isadma.h> 2021-11-26 16:48:59 +01:00
ni_at_ao.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
ni_atmio.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
ni_atmio16d.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
ni_daq_700.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_daq_dio24.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
ni_labpc.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_labpc.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_common.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
ni_labpc_cs.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_labpc_isadma.c comedi: Move "comedi_isadma.h" to <linux/comedi/comedi_isadma.h> 2021-11-26 16:48:59 +01:00
ni_labpc_isadma.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_labpc_pci.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_labpc_regs.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_mio_common.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
ni_mio_cs.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
ni_pcidio.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_pcimio.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_routes.c comedi: drivers: ni_routes: Use strcmp() instead of memcmp() 2022-02-25 12:08:52 +01:00
ni_routes.h comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_stc.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_tio.c comedi: drivers: ni_tio: Fix slightly broken kernel-doc and demote others 2021-05-21 14:38:44 +02:00
ni_tio.h comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
ni_tio_internal.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_tiocmd.c staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ni_usb6501.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
pcl711.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
pcl724.c comedi: Move and rename "8255.h" to <linux/comedi/comedi_8255.h> 2021-11-26 16:48:59 +01:00
pcl726.c comedi: pcl726: Prevent invalid irq number 2025-08-28 16:26:14 +02:00
pcl730.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
pcl812.c comedi: pcl812: Fix bit shift out of bounds 2025-07-24 08:51:50 +02:00
pcl816.c comedi: Move "comedi_isadma.h" to <linux/comedi/comedi_isadma.h> 2021-11-26 16:48:59 +01:00
pcl818.c comedi: Move "comedi_isadma.h" to <linux/comedi/comedi_isadma.h> 2021-11-26 16:48:59 +01:00
pcm3724.c comedi: remove redundant assignment to variable buffer_config 2022-02-08 12:12:02 +01:00
pcmad.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
pcmda12.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
pcmmio.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
pcmuio.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
plx9052.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
plx9080.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
quatech_daqp_cs.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
rtd520.c comedi: Move "comedi_8254.h" to <linux/comedi/comedi_8254.h> 2021-11-26 16:48:59 +01:00
rti800.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
rti802.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
s526.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
s626.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
s626.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00
ssv_dnp.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
usbdux.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
usbduxfast.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
usbduxsigma.c comedi: Move the main COMEDI headers 2021-11-26 16:48:59 +01:00
vmk80xx.c comedi: vmk80xx: fix incomplete endpoint checking 2024-04-27 17:07:14 +02:00
z8536.h staging: comedi: move out of staging directory 2021-04-15 09:26:25 +02:00