linux/fs/udf
Jan Kara 12d461e224 udf: Fix file corruption when appending just after end of preallocated extent
commit 36ec52ea03 upstream.

When we append new block just after the end of preallocated extent, the
code in inode_getblk() wrongly determined we're going to use the
preallocated extent which resulted in adding block into a wrong logical
offset in the file. Sequence like this manifests it:

xfs_io -f -c "pwrite 0x2cacf 0xd122" -c "truncate 0x2dd6f" \
  -c "pwrite 0x27fd9 0x69a9" -c "pwrite 0x32981 0x7244" <file>

The code that determined the use of preallocated extent is actually
stale because udf_do_extend_file() does not create preallocation anymore
so after calling that function we are sure there's no usable
preallocation. Just remove the faulty condition.

CC: stable@vger.kernel.org
Fixes: 16d0556568 ("udf: Discard preallocation before extending file with a hole")
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2023-03-10 09:34:10 +01:00
..
balloc.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
dir.c udf: replace ll_rw_block() 2022-09-11 20:26:07 -07:00
directory.c udf: replace ll_rw_block() 2022-09-11 20:26:07 -07:00
ecma_167.h udf: Get rid of 0-length arrays in struct fileIdentDesc 2021-08-11 16:54:44 +02:00
file.c udf: Do not update file length for failed writes to inline files 2023-03-10 09:34:10 +01:00
ialloc.c udf: Fix error handling in udf_new_inode() 2021-12-15 13:08:34 +01:00
inode.c udf: Fix file corruption when appending just after end of preallocated extent 2023-03-10 09:34:10 +01:00
Kconfig docs: filesystems: fix renamed references 2020-04-20 15:45:22 -06:00
lowlevel.c udf: use sb_bdev_nr_blocks 2021-10-18 14:43:23 -06:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
misc.c udf_get_extendedattr() had no boundary checks. 2021-08-23 13:35:19 +02:00
namei.c udf: Avoid double brelse() in udf_rename() 2022-12-31 13:32:57 +01:00
osta_udf.h udf: Get rid of 0-length arrays 2021-08-11 16:54:44 +02:00
partition.c udf: Remove pointless union in udf_inode_info 2020-09-29 17:21:54 +02:00
super.c udf: Preserve link count of system files 2023-03-10 09:34:10 +01:00
symlink.c udf: Convert adinicb and symlinks to read_folio 2022-05-09 16:21:46 -04:00
truncate.c udf: Do not bother looking for prealloc extents if i_lenExtents matches i_size 2022-12-21 17:48:05 +01:00
udf_i.h udf: Preserve link count of system files 2023-03-10 09:34:10 +01:00
udf_sb.h udf: Define EFSCORRUPTED error code 2023-03-10 09:33:45 +01:00
udfdecl.h udf: Get rid of 0-length arrays in struct fileIdentDesc 2021-08-11 16:54:44 +02:00
udfend.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
udftime.c udf: convert inode stamps to timespec64 2018-06-27 13:58:00 +02:00
unicode.c udf: Fix iocharset=utf8 mount option 2021-08-12 16:07:09 +02:00