Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Alan Stern 53764a17f5 media: radio-shark: Add endpoint checks ... commit 76e31045ba upstream. The syzbot fuzzer was able to provoke a WARNING from the radio-shark2 driver: ------------[ cut here ]------------ usb 1-1: BOGUS urb xfer, pipe 1 != type 3 WARNING: CPU: 0 PID: 3271 at drivers/usb/core/urb.c:504 usb_submit_urb+0xed2/0x1880 drivers/usb/core/urb.c:504 Modules linked in: CPU: 0 PID: 3271 Comm: kworker/0:3 Not tainted 6.1.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Workqueue: usb_hub_wq hub_event RIP: 0010:usb_submit_urb+0xed2/0x1880 drivers/usb/core/urb.c:504 Code: 7c 24 18 e8 00 36 ea fb 48 8b 7c 24 18 e8 36 1c 02 ff 41 89 d8 44 89 e1 4c 89 ea 48 89 c6 48 c7 c7 a0 b6 90 8a e8 9a 29 b8 03 <0f> 0b e9 58 f8 ff ff e8 d2 35 ea fb 48 81 c5 c0 05 00 00 e9 84 f7 RSP: 0018:ffffc90003876dd0 EFLAGS: 00010282 RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000 RDX: ffff8880750b0040 RSI: ffffffff816152b8 RDI: fffff5200070edac RBP: ffff8880172d81e0 R08: 0000000000000005 R09: 0000000000000000 R10: 0000000080000000 R11: 0000000000000000 R12: 0000000000000001 R13: ffff8880285c5040 R14: 0000000000000002 R15: ffff888017158200 FS: 0000000000000000(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffe03235b90 CR3: 000000000bc8e000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> usb_start_wait_urb+0x101/0x4b0 drivers/usb/core/message.c:58 usb_bulk_msg+0x226/0x550 drivers/usb/core/message.c:387 shark_write_reg+0x1ff/0x2e0 drivers/media/radio/radio-shark2.c:88 ... The problem was caused by the fact that the driver does not check whether the endpoints it uses are actually present and have the appropriate types. This can be fixed by adding a simple check of these endpoints (and similarly for the radio-shark driver). Link: https://syzkaller.appspot.com/bug?extid=4b3f8190f6e13b3efd74 Reported-and-tested-by: syzbot+4b3f8190f6e13b3efd74@syzkaller.appspotmail.com Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Link: https://lore.kernel.org/r/e2858ab4-4adf-46e5-bbf6-c56742034547@rowland.harvard.edu Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2023-05-30 14:03:20 +01:00
..
cec	media fixes for v6.1-rc2	2022-10-22 15:30:15 -07:00
common	media: videobuf2-core: take mmap_lock in vb2_get_unmapped_area()	2022-12-07 11:25:40 -08:00
dvb-core	media: dvb-core: Fix UAF due to refcount races at releasing	2023-01-07 11:11:49 +01:00
dvb-frontends	media: stv0288: use explicitly signed char	2023-01-07 11:11:36 +01:00
firewire	media: Makefiles: remove extra spaces	2022-03-12 16:59:52 +01:00
i2c	media: hi846: Fix memleak in hi846_init_controls()	2023-05-11 23:03:15 +09:00
mc	media: mc: Get media_device directly from pad	2023-03-10 09:33:42 +01:00
mmc	media: media/*/Kconfig: sort entries	2022-03-18 05:58:35 +01:00
pci	media: netup_unidvb: fix use-after-free at del_timer()	2023-05-24 17:32:45 +01:00
platform	media: mediatek: vcodec: Fix potential array out-of-bounds in decoder queue_setup	2023-05-24 17:32:36 +01:00
radio	media: radio-shark: Add endpoint checks	2023-05-30 14:03:20 +01:00
rc	media: rc: gpio-ir-recv: Fix support for wake-up	2023-05-11 23:03:15 +09:00
spi	media updates for v5.18-rc1	2022-03-23 14:51:35 -07:00
test-drivers	media: vimc: Fix wrong function called when vimc_init() fails	2022-12-31 13:32:16 +01:00
tuners	media fixes for v6.1-rc2	2022-10-22 15:30:15 -07:00
usb	media: Prefer designated initializers over memset for subdev pad ops	2023-05-24 17:32:36 +01:00
v4l2-core	media: v4l: async: Return async sub-devices to subnotifier list	2023-05-11 23:03:15 +09:00
Kconfig	media: remove reference to CONFIG_EMBEDDED in MEDIA_SUPPORT_FILTER	2022-09-08 18:19:29 +02:00
Makefile	media: Makefiles: remove extra spaces	2022-03-12 16:59:52 +01:00