Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Eric Dumazet 3d9eface2e rfs: annotate lockless accesses to sk->sk_rxhash ...

[ Upstream commit 1e5c647c3f ]

Add READ_ONCE()/WRITE_ONCE() on accesses to sk->sk_rxhash.

This also prevents a (smart ?) compiler to remove the condition in:

if (sk->sk_rxhash != newval)
	sk->sk_rxhash = newval;

We need the condition to avoid dirtying a shared cache line.

Fixes: fec5e652e5 ("rfs: Receive Flow Steering")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-06-14 11:15:20 +02:00

3008 lines

84 KiB

Raw Permalink Blame History