Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Jan Höppner dc96fde8fc s390/dasd: protect device queue against concurrent access ... commit db46cd1e04 upstream. In dasd_profile_start() the amount of requests on the device queue are counted. The access to the device queue is unprotected against concurrent access. With a lot of parallel I/O, especially with alias devices enabled, the device queue can change while dasd_profile_start() is accessing the queue. In the worst case this leads to a kernel panic due to incorrect pointer accesses. Fix this by taking the device lock before accessing the queue and counting the requests. Additionally the check for a valid profile data pointer can be done earlier to avoid unnecessary locking in a hot path. Cc: <stable@vger.kernel.org> Fixes: 4fa52aa7a8 ("[S390] dasd: add enhanced DASD statistics interface") Reviewed-by: Stefan Haberland <sth@linux.ibm.com> Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com> Signed-off-by: Stefan Haberland <sth@linux.ibm.com> Link: https://lore.kernel.org/r/20231025132437.1223363-3-sth@linux.ibm.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2023-12-03 07:32:11 +01:00
..
block	s390/dasd: protect device queue against concurrent access	2023-12-03 07:32:11 +01:00
char	s390/early: fix sclp_early_sccb variable lifetime	2023-03-10 09:32:53 +01:00
cio	s390/cio: fix a memleak in css_alloc_subchannel	2023-10-25 12:03:15 +02:00
crypto	s390/ap: fix AP bus crash on early config change callback invocation	2023-11-28 17:07:18 +00:00
net	s390/qeth: Don't call dev_close/dev_open (DOWN/UP)	2023-08-11 12:08:17 +02:00
scsi	scsi: zfcp: Fix a double put in zfcp_port_enqueue()	2023-10-10 22:00:38 +02:00
virtio	virtio: Revert "virtio: find_vqs() add arg sizes"	2022-08-16 01:40:24 -04:00
Makefile	s390: remove pointless drivers-y in drivers/s390/Makefile	2019-09-16 13:21:51 +02:00