kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-22 19:14:51 +00:00
Code Issues Releases Packages Activity
linux/drivers/tty/serial
History
Hugo Villeneuve 7d3b793faa serial: sc16is7xx: fix invalid FIFO access with special register set 
When enabling access to the special register set, Receiver time-out and
RHR interrupts can happen. In this case, the IRQ handler will try to read
from the FIFO thru the RHR register at address 0x00, but address 0x00 is
mapped to DLL register, resulting in erroneous FIFO reading.

Call graph example:
    sc16is7xx_startup(): entry
    sc16is7xx_ms_proc(): entry
    sc16is7xx_set_termios(): entry
    sc16is7xx_set_baud(): DLH/DLL = $009C --> access special register set
    sc16is7xx_port_irq() entry            --> IIR is 0x0C
    sc16is7xx_handle_rx() entry
    sc16is7xx_fifo_read(): --> unable to access FIFO (RHR) because it is
                               mapped to DLL (LCR=LCR_CONF_MODE_A)
    sc16is7xx_set_baud(): exit --> Restore access to general register set

Fix the problem by claiming the efr_lock mutex when accessing the Special
register set.

Fixes: dfeae619d7 ("serial: sc16is7xx")
Cc: stable@vger.kernel.org
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20240723125302.1305372-3-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2024-07-31 12:31:19 +02:00
..
8250 TTY/Serial updates for 6.11-rc1 2024-07-19 15:22:14 -07:00
jsm tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
21285.c serial: 21285: Use port lock wrappers 2023-09-18 11:18:08 +02:00
altera_jtaguart.c serial: altera_jtaguart: Convert to platform remove callback returning void 2023-11-23 19:12:30 +00:00
altera_uart.c tty/serial: altera_uart: use more informative labels in /proc/interrupts 2024-01-04 16:20:51 +01:00
amba-pl010.c serial: amba-pl010: Use port lock wrappers 2023-09-18 11:18:09 +02:00
amba-pl011.c serial: amba-pl011: move variable into CONFIG_DMA_ENGINE conditional 2024-04-09 17:07:10 +02:00
apbuart.c serial: apbuart: fix console prompt on qemu 2024-01-04 16:21:06 +01:00
apbuart.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ar933x_uart.c serial: ar933x: Remove unneeded static structure 2024-04-09 17:07:10 +02:00
arc_uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
atmel_serial.c tty: atmel_serial: use single DMA mapping for RX 2024-04-09 15:28:04 +02:00
atmel_serial.h tty: serial: atmel: Use FIELD_PREP/FIELD_GET 2022-09-22 16:32:25 +02:00
bcm63xx_uart.c serial: bcm63xx-uart: fix tx after conversion to uart_port_tx_limited() 2024-06-24 16:14:48 +02:00
clps711x.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
cpm_uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
cpm_uart.h serial: cpm_uart: Remove cpm_uart/ subdirectory 2023-08-04 15:08:30 +02:00
digicolor-usart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
dz.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
dz.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
earlycon-riscv-sbi.c tty/serial: Add RISC-V SBI debug console based earlycon 2024-01-10 07:04:04 -08:00
earlycon-semihost.c serial: Rename earlycon semihost driver 2023-01-19 14:58:19 +01:00
earlycon.c earlycon: Let users set the clock frequency 2023-01-19 14:56:44 +01:00
esp32_acm.c tty: add missing MODULE_DESCRIPTION() macros 2024-06-24 16:10:11 +02:00
esp32_uart.c tty: add missing MODULE_DESCRIPTION() macros 2024-06-24 16:10:11 +02:00
fsl_linflexuart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
fsl_lpuart.c tty: serial: fsl_lpuart: use dev_err_probe for clocks 2024-04-17 13:14:04 +02:00
icom.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
imx.c TTY/Serial updates for 6.11-rc1 2024-07-19 15:22:14 -07:00
imx_earlycon.c serial: make uart_console_write->putchar()'s character an unsigned char 2022-03-03 15:06:31 +01:00
ip22zilog.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
ip22zilog.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Kconfig serial: sc16is7xx: re-add Kconfig SPI or I2C dependency 2024-06-04 14:10:28 +02:00
kgdb_nmi.c tty: make tty_operations::write()'s count size_t 2023-08-11 21:12:46 +02:00
kgdboc.c serial: kgdboc: Fix NMI-safety problems from keyboard reset code 2024-04-26 17:14:10 +01:00
lantiq.c serial: lantiq: Convert to platform remove callback returning void 2023-11-23 19:12:32 +00:00
liteuart.c serial: liteuart: Convert to platform remove callback returning void 2023-11-23 19:12:32 +00:00
lpc32xx_hs.c serial: lpc32xx_hs: Use uart_prepare_sysrq_char() to handle sysrq. 2024-03-02 22:06:21 +01:00
ma35d1_serial.c tty: serial: ma35d1: Add a NULL check for of_node 2024-07-03 16:12:06 +02:00
Makefile serial: sc16is7xx: rename Kconfig CONFIG_SERIAL_SC16IS7XX_CORE 2024-06-04 14:10:28 +02:00
max310x.c tty: serial: max310x: convert to use maple tree register cache 2024-04-09 16:50:36 +02:00
max3100.c serial: max3100: Convert to_max3100_port() to be static inline 2024-04-11 14:08:40 +02:00
mcf.c tty: mcf: MCF54418 has 10 UARTS 2024-06-24 16:13:05 +02:00
men_z135_uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
meson_uart.c serial: meson+qcom: don't advance the kfifo twice 2024-04-16 09:05:43 +02:00
milbeaut_usio.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
mpc52xx_uart.c serial: mpc52xx: Convert to platform remove callback returning void 2023-11-23 19:12:32 +00:00
mps2-uart.c serial: mps2-uart: Use port lock wrappers 2023-09-18 11:18:12 +02:00
msm_serial.c serial: msm: check dma_map_sg() return value properly 2024-04-20 07:58:42 +02:00
mux.c tty: serial: use uart_port_tx_limited() 2022-11-03 03:32:40 +01:00
mvebu-uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
mxs-auart.c Merge 6.9-rc5 into tty-next 2024-04-23 13:24:45 +02:00
omap-serial.c serial: omap: remove redundant assignment to variable tmout 2024-04-11 14:08:36 +02:00
owl-uart.c tty: add missing MODULE_DESCRIPTION() macros 2024-06-24 16:10:11 +02:00
pch_uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
pic32_uart.c serial: pic32_uart: Replace of_gpio.h by proper one 2024-04-09 15:48:43 +02:00
pmac_zilog.c Merge 6.9-rc5 into tty-next 2024-04-23 13:24:45 +02:00
pmac_zilog.h serial: pmac_zilog: remove unused uart_pmac_port::termios_cache 2022-05-19 18:23:19 +02:00
pxa.c serial: pxa: Use uart_prepare_sysrq_char(). 2024-03-02 22:06:21 +01:00
qcom_geni_serial.c serial: qcom-geni: do not kill the machine on fifo underrun 2024-07-04 12:30:30 +02:00
rda-uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
rp2.c tty: rp2: remove unused rp2_uart_port::ignore_rx 2023-11-23 19:16:03 +00:00
sa1100.c serial: sa1100: Convert to platform remove callback returning void 2023-11-23 19:12:33 +00:00
samsung_tty.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
sb1250-duart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
sc16is7xx.c serial: sc16is7xx: fix invalid FIFO access with special register set 2024-07-31 12:31:19 +02:00
sc16is7xx.h serial: sc16is7xx: split into core and I2C/SPI parts (sc16is7xx_regcfg) 2024-04-11 14:08:08 +02:00
sc16is7xx_i2c.c serial: sc16is7xx: split into core and I2C/SPI parts (sc16is7xx_regcfg) 2024-04-11 14:08:08 +02:00
sc16is7xx_spi.c serial: sc16is7xx: split into core and I2C/SPI parts (sc16is7xx_regcfg) 2024-04-11 14:08:08 +02:00
sccnxp.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
serial-tegra.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
serial_base.h serial: core: Add serial_base_match_and_update_preferred_console() 2024-07-04 15:41:44 +02:00
serial_base_bus.c Driver core changes for 6.11-rc1 2024-07-25 10:42:22 -07:00
serial_core.c serial: core: check uartclk for zero to avoid divide by zero 2024-07-31 12:30:06 +02:00
serial_ctrl.c serial: core: Start managing serial controllers to enable runtime PM 2023-05-31 10:46:59 +01:00
serial_mctrl_gpio.c tty: add missing MODULE_DESCRIPTION() macros 2024-06-24 16:10:11 +02:00
serial_mctrl_gpio.h serial: mctrl_gpio: add a new API to enable / disable wake_irq 2022-02-08 11:07:16 +01:00
serial_port.c serial: port: Don't block system suspend even if bytes are left to xmit 2024-06-04 14:09:47 +02:00
serial_txx9.c serial: txx9: Add missing #include <asm/txx9/generic.h> 2024-01-27 19:05:39 -08:00
sh-sci.c serial: sh-sci: Add support for RZ/V2H(P) SoC 2024-06-24 16:09:37 +02:00
sh-sci.h tty: serial: sh-sci: Add support for tx end interrupt handling 2023-04-20 13:47:33 +02:00
sifive.c serial: sifive: Remove 0 from fu540-c000-uart0 binding. 2024-04-09 15:48:46 +02:00
sprd_serial.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
st-asc.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
stm32-usart.c Merge 6.9-rc5 into tty-next 2024-04-23 13:24:45 +02:00
stm32-usart.h serial: stm32: get FIFO size from hwcfg register 2024-01-27 19:04:11 -08:00
suncore.c tty: Use of_node_name_{eq,prefix} for node name comparisons 2018-12-17 16:12:17 +01:00
sunhv.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
sunplus-uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
sunsab.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
sunsab.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sunsu.c tty: sunsu: Simplify device_node cleanup by using __free 2024-06-04 14:00:16 +02:00
sunzilog.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
sunzilog.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
tegra-tcu.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
timbuart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
timbuart.h tty: serial: Use the correct style for SPDX License Identifier 2020-03-07 09:52:01 +01:00
uartlite.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
ucc_uart.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
vt8500_serial.c serial: vt8500: Use port lock wrappers 2023-09-18 11:18:16 +02:00
xilinx_uartps.c tty: serial: uartps: Add support for uartps controller reset 2024-05-04 18:11:05 +02:00
zs.c tty: serial: switch from circ_buf to kfifo 2024-04-09 15:28:03 +02:00
zs.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00