linux/sound/usb/usx2y
Takashi Iwai 9d5c530e4d ALSA: us122l: Use snd_card_free_when_closed() at disconnection
[ Upstream commit b7df09bb34 ]

The USB disconnect callback is supposed to be short and not too-long
waiting.  OTOH, the current code uses snd_card_free() at
disconnection, but this waits for the close of all used fds, hence it
can take long.  It eventually blocks the upper layer USB ioctls, which
may trigger a soft lockup.

An easy workaround is to replace snd_card_free() with
snd_card_free_when_closed().  This variant returns immediately while
the release of resources is done asynchronously by the card device
release at the last close.

The loop of us122l->mmap_count check is dropped as well.  The check is
useless for the asynchronous operation with *_when_closed().

Fixes: 030a07e441 ("ALSA: Add USB US122L driver")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241113111042.15058-3-tiwai@suse.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-12-05 14:01:58 +01:00
..
Makefile ALSA: usb: Use *-y instead of *-objs in Makefile 2024-05-08 18:17:53 +02:00
us122l.c ALSA: us122l: Use snd_card_free_when_closed() at disconnection 2024-12-05 14:01:58 +01:00
us122l.h ALSA: usx2y: Coding style fixes 2021-05-17 16:03:58 +02:00
usb_stream.c ALSA: usx2y: Drop no longer used variable 2024-08-09 09:57:33 +02:00
usb_stream.h ALSA: usx2y: Use standard print API 2024-08-08 07:49:47 +02:00
usbus428ctldefs.h ALSA: usx2y: Fix potential leaks of uninitialized memory 2021-05-17 16:04:10 +02:00
usbusx2y.c ALSA: usx2y: Use snd_card_free_when_closed() at disconnection 2024-12-05 14:01:57 +01:00
usbusx2y.h ALSA: usx2y: Annotate struct snd_usx2y_urb_seq with __counted_by 2023-09-23 12:36:59 +02:00
usbusx2yaudio.c ALSA: usx2y: Use standard print API 2024-08-08 07:49:47 +02:00
usx2y.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
usX2Yhwdep.c ALSA: usx2y: Use standard print API 2024-08-08 07:49:47 +02:00
usX2Yhwdep.h ALSA: usx2y: Fix spaces 2021-05-17 16:03:46 +02:00
usx2yhwdeppcm.c ALSA: usx2y: Use standard print API 2024-08-08 07:49:47 +02:00
usx2yhwdeppcm.h ALSA: usx2y: Avoid camelCase 2021-05-17 16:03:34 +02:00