kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-24 19:10:26 +00:00
Code Issues Releases Packages Activity
linux/drivers/s390
History
Fedor Pchelkin f855b119e6 s390/pkey: Prevent overflow in size calculation for memdup_user() 
commit 7360ee4759 upstream.

Number of apqn target list entries contained in 'nr_apqns' variable is
determined by userspace via an ioctl call so the result of the product in
calculation of size passed to memdup_user() may overflow.

In this case the actual size of the allocated area and the value
describing it won't be in sync leading to various types of unpredictable
behaviour later.

Use a proper memdup_array_user() helper which returns an error if an
overflow is detected. Note that it is different from when nr_apqns is
initially zero - that case is considered valid and should be handled in
subsequent pkey_handler implementations.

Found by Linux Verification Center (linuxtesting.org).

Fixes: f2bbc96e7c ("s390/pkey: add CCA AES cipher key support")
Cc: stable@vger.kernel.org
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: Holger Dengler <dengler@linux.ibm.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/20250611192011.206057-1-pchelkin@ispras.ru
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2025-07-06 11:01:38 +02:00
..
block s390/dasd: fix error recovery leading to data corruption on ESE devices 2024-08-12 10:31:08 -06:00
char s390/tty: Fix a potential memory leak bug 2025-05-02 07:59:16 +02:00
cio s390/cio: Fix CHPID "configure" attribute caching 2025-03-22 12:54:17 -07:00
crypto s390/pkey: Prevent overflow in size calculation for memdup_user() 2025-07-06 11:01:38 +02:00
net s390/ism: add release function for struct device 2025-02-27 04:30:17 -08:00
scsi scsi: s390: zfcp: Ensure synchronous unit_add 2025-06-27 11:11:37 +01:00
virtio s390/virtio_ccw: Don't allocate/assign airqs for non-existing queues 2025-04-20 10:15:59 +02:00
Makefile s390: remove pointless drivers-y in drivers/s390/Makefile 2019-09-16 13:21:51 +02:00