Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Guoniu Zhou e8b5f4d807 media: nxp: imx8-isi: m2m: Fix streaming cleanup on release ... [ Upstream commit 178aa33602 ] If streamon/streamoff calls are imbalanced, such as when exiting an application with Ctrl+C when streaming, the m2m usage_count will never reach zero and the ISI channel won't be freed. Besides from that, if the input line width is more than 2K, it will trigger a WARN_ON(): [ 59.222120] ------------[ cut here ]------------ [ 59.226758] WARNING: drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:631 at mxc_isi_channel_chain+0xa4/0x120, CPU#4: v4l2-ctl/654 [ 59.238569] Modules linked in: ap1302 [ 59.242231] CPU: 4 UID: 0 PID: 654 Comm: v4l2-ctl Not tainted 6.16.0-rc4-next-20250704-06511-gff0e002d480a-dirty #258 PREEMPT [ 59.253597] Hardware name: NXP i.MX95 15X15 board (DT) [ 59.258720] pstate: 80400009 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 59.265669] pc : mxc_isi_channel_chain+0xa4/0x120 [ 59.270358] lr : mxc_isi_channel_chain+0x44/0x120 [ 59.275047] sp : ffff8000848c3b40 [ 59.278348] x29: ffff8000848c3b40 x28: ffff0000859b4c98 x27: ffff800081939f00 [ 59.285472] x26: 000000000000000a x25: ffff0000859b4cb8 x24: 0000000000000001 [ 59.292597] x23: ffff0000816f4760 x22: ffff0000816f4258 x21: ffff000084ceb780 [ 59.299720] x20: ffff000084342ff8 x19: ffff000084340000 x18: 0000000000000000 [ 59.306845] x17: 0000000000000000 x16: 0000000000000000 x15: 0000ffffdb369e1c [ 59.313969] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 [ 59.321093] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000 [ 59.328217] x8 : ffff8000848c3d48 x7 : ffff800081930b30 x6 : ffff800081930b30 [ 59.335340] x5 : ffff0000859b6000 x4 : ffff80008193ae80 x3 : ffff800081022420 [ 59.342464] x2 : ffff0000852f6900 x1 : 0000000000000001 x0 : ffff000084341000 [ 59.349590] Call trace: [ 59.352025] mxc_isi_channel_chain+0xa4/0x120 (P) [ 59.356722] mxc_isi_m2m_streamon+0x160/0x20c [ 59.361072] v4l_streamon+0x24/0x30 [ 59.364556] __video_do_ioctl+0x40c/0x4a0 [ 59.368560] video_usercopy+0x2bc/0x690 [ 59.372382] video_ioctl2+0x18/0x24 [ 59.375857] v4l2_ioctl+0x40/0x60 [ 59.379168] __arm64_sys_ioctl+0xac/0x104 [ 59.383172] invoke_syscall+0x48/0x104 [ 59.386916] el0_svc_common.constprop.0+0xc0/0xe0 [ 59.391613] do_el0_svc+0x1c/0x28 [ 59.394915] el0_svc+0x34/0xf4 [ 59.397966] el0t_64_sync_handler+0xa0/0xe4 [ 59.402143] el0t_64_sync+0x198/0x19c [ 59.405801] ---[ end trace 0000000000000000 ]--- Address this issue by moving the streaming preparation and cleanup to the vb2 .prepare_streaming() and .unprepare_streaming() operations. This also simplifies the driver by allowing direct usage of the v4l2_m2m_ioctl_streamon() and v4l2_m2m_ioctl_streamoff() helpers. Fixes: cf21f328fc ("media: nxp: Add i.MX8 ISI driver") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250821135123.29462-1-laurent.pinchart@ideasonboard.com Signed-off-by: Guoniu Zhou <guoniu.zhou@nxp.com> Co-developed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by: Guoniu Zhou <guoniu.zhou@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> [ Adjust context ] Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2025-10-23 16:20:24 +02:00
..
cec	media: cec: extron-da-hd-4k-plus: drop external-module make commands	2025-10-19 16:33:46 +02:00
common	media: videobuf2: use sgtable-based scatterlist wrappers	2025-06-27 11:11:18 +01:00
dvb-core	media: dvbdev: fix the logic when DVB_DYNAMIC_MINORS is not set	2024-11-06 22:32:52 +01:00
dvb-frontends	media: dvb-frontends: w7090p: fix null-ptr-deref in w7090p_tuner_write_serpar and w7090p_tuner_read_serpar	2025-08-20 18:30:45 +02:00
firewire	media: firewire: firedtv-avc.c: replace BUG with proper, error return	2023-08-10 07:58:37 +02:00
i2c	media: i2c: mt9v111: fix incorrect type for ret	2025-10-19 16:33:46 +02:00
mc	media: mc: Clear minor number before put device	2025-10-19 16:34:00 +02:00
mmc	media: mmc: siano: simplify module initialization	2024-04-08 13:48:19 +02:00
pci	media: pci: mg4b: fix uninitialized iio scan data	2025-10-19 16:33:46 +02:00
platform	media: nxp: imx8-isi: m2m: Fix streaming cleanup on release	2025-10-23 16:20:24 +02:00
radio	media: wl128x: Fix atomicity violation in fmc_send_cmd()	2024-12-05 14:02:56 +01:00
rc	media: lirc: Fix error handling in lirc_register()	2025-10-19 16:33:47 +02:00
spi	media: gs1662: remove unused struct 'gs_reg_fmt_custom'	2024-05-31 13:51:16 +02:00
test-drivers	media: vivid: fix disappearing <Vendor Command With ID> messages	2025-10-19 16:33:47 +02:00
tuners	media: tuner: xc5000: Fix use-after-free in xc5000_release	2025-10-06 11:17:52 +02:00
usb	media: uvcvideo: Mark invalid entities with id UVC_INVALID_ENTITY_ID	2025-10-06 11:17:52 +02:00
v4l2-core	media: v4l2-ctrls: Don't reset handler's error in v4l2_ctrl_handler_free()	2025-08-28 16:31:01 +02:00
Kconfig	media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y	2022-12-07 17:58:46 +01:00
Makefile	media: Makefiles: remove extra spaces	2022-03-12 16:59:52 +01:00