kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-11-08 18:57:22 +00:00
Code Issues Releases Packages Activity
linux/drivers/dpll
History
Ivan Vecera dfec0501db dpll: Prevent duplicate registrations 
[ Upstream commit f3ddbaaaaf ]

Modify the internal registration helpers dpll_xa_ref_{dpll,pin}_add()
to reject duplicate registration attempts.

Previously, if a caller attempted to register the same pin multiple
times (with the same ops, priv, and cookie) on the same device, the core
silently increments the reference count and return success. This behavior
is incorrect because if the caller makes these duplicate registrations
then for the first one dpll_pin_registration is allocated and for others
the associated dpll_pin_ref.refcount is incremented. During the first
unregistration the associated dpll_pin_registration is freed and for
others WARN is fired.

Fix this by updating the logic to return `-EEXIST` if a matching
registration is found to enforce a strict "register once" policy.

Fixes: 9431063ad3 ("dpll: core: Add DPLL framework base functions")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20260121130012.112606-1-ivecera@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2026-01-30 10:28:44 +01:00
..
dpll_core.c dpll: Prevent duplicate registrations 2026-01-30 10:28:44 +01:00
dpll_core.h dpll: rely on rcu for netdev_dpll_pin() 2024-02-26 18:39:34 -08:00
dpll_netlink.c dpll: add Embedded SYNC feature for a pin 2024-08-26 19:21:14 -07:00
dpll_netlink.h dpll: netlink: Add DPLL framework base functions 2023-09-17 11:50:20 +01:00
dpll_nl.c dpll: add Embedded SYNC feature for a pin 2024-08-26 19:21:14 -07:00
dpll_nl.h dpll: fix possible deadlock during netlink dump operation 2024-02-08 18:29:21 -08:00
Kconfig dpll: indent DPLL option type by a tab 2024-03-25 19:40:23 -07:00
Makefile dpll: core: Add DPLL framework base functions 2023-09-17 11:50:20 +01:00