linux/sound/soc/fsl
Fabio Estevam 32bcebea15 ASoC: fsl: imx-card: Do not force slot width to sample width
commit 9210f5ff63 upstream.

imx-card currently sets the slot width to the physical sample width
for I2S links. This breaks controllers that use fixed-width slots
(e.g. 32-bit FIFO words), causing the unused bits in the slot to
contain undefined data when playing 16-bit streams.

Do not override the slot width in the machine driver and let the CPU
DAI select an appropriate default instead. This matches the behavior
of simple-audio-card and avoids embedding controller-specific policy
in the machine driver.

On an i.MX8MP-based board using SAI as the I2S master with 32-bit slots,
playing 16-bit audio resulted in spurious frequencies and an incorrect
SAI data waveform, as the slot width was forced to 16 bits. After this
change, audio artifacts are eliminated and the 16-bit samples correctly
occupy the first half of the 32-bit slot, with the remaining bits padded
with zeroes.

Cc: stable@vger.kernel.org
Fixes: aa736700f4 ("ASoC: imx-card: Add imx-card machine driver")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Link: https://patch.msgid.link/20260118205030.1532696-1-festevam@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2026-02-06 16:55:45 +01:00
..
efika-audio-fabric.c ASoC: Explicitly include correct DT includes 2023-10-09 13:13:56 +01:00
eukrea-tlv320.c ASoC: fsl: use devm_snd_soc_register_card() 2024-01-22 00:06:02 +00:00
fsl-asoc-card.c ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios 2024-12-05 14:01:40 +01:00
fsl_asrc.c ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode 2025-07-17 18:37:01 +02:00
fsl_asrc.h ASoC: fsl_asrc: Move common definition to fsl_asrc_common 2020-04-21 16:34:09 +01:00
fsl_asrc_common.h ASoC: fsl_asrc_dma: Fix data copying speed issue with EDMA 2020-06-12 14:18:04 +01:00
fsl_asrc_dma.c ASoC: fsl_asrc_dma: get codec or cpu dai from backend 2025-05-02 07:59:26 +02:00
fsl_aud2htx.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
fsl_aud2htx.h ASoC: fsl_aud2htx: Add aud2htx module driver 2020-11-05 17:06:16 +00:00
fsl_audmix.c ASoC: fsl_audmix: register card device depends on 'dais' property 2025-04-20 10:15:15 +02:00
fsl_audmix.h ASoC: fsl_audmix: Add spin lock to protect tdms 2019-11-11 13:01:37 +00:00
fsl_dma.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
fsl_dma.h ASoC: fsl-dma: Switch to SPDX identifier 2019-04-08 13:51:01 +07:00
fsl_easrc.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
fsl_easrc.h ASoC: fsl_easrc: use snd_pcm_format_t type for sample_format 2022-07-21 13:38:51 +01:00
fsl_esai.c ASoC: fsl_esai: change dev_warn to dev_dbg in irq handler 2024-10-11 12:06:49 +01:00
fsl_esai.h ASoC: fsl_esai: Switch to SPDX identifier 2018-05-03 10:29:05 +09:00
fsl_micfil.c ASoC: fsl_micfil: Enable default case in micfil_set_quality() 2025-02-27 04:30:22 -08:00
fsl_micfil.h ASoC: fsl_micfil: Expand the range of FIFO watermark mask 2024-07-29 13:36:13 +01:00
fsl_mqs.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
fsl_qmc_audio.c ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event 2025-04-25 10:47:49 +02:00
fsl_rpmsg.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
fsl_rpmsg.h ASoC: fsl_rpmsg: add soc specific data structure 2021-09-13 01:59:15 +01:00
fsl_sai.c ASoC: fsl_sai: Add missing registers to cache default 2026-01-17 16:31:29 +01:00
fsl_sai.h ASoC: fsl_sai: Enable 'FIFO continue on error' FCONT bit 2024-09-30 23:30:32 +01:00
fsl_spdif.c ASoC: fsl_spdif: change IFACE_PCM to IFACE_MIXER 2024-12-19 18:13:18 +01:00
fsl_spdif.h ASoC: fsl_spdif: Add support for 22.05 kHz sample rate 2023-07-19 18:47:18 +01:00
fsl_ssi.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
fsl_ssi.h ASoC: fsl: no need to check return value of debugfs_create functions 2019-06-14 16:37:48 +01:00
fsl_ssi_dbg.c ASoC: fsl: fsl_ssi_dbg: remove spurious kernel-doc comment start 2020-07-03 16:09:24 +01:00
fsl_utils.c ASoC: fsl: fsl-utils: remove useless assignment 2022-08-31 12:13:03 +01:00
fsl_utils.h ASoC: fsl_utils: Add function to handle PLL clock source 2022-07-05 13:00:37 +01:00
fsl_xcvr.c ASoC: fsl_xcvr: clear the channel status control memory 2025-12-18 13:55:08 +01:00
fsl_xcvr.h ASoC: fsl_xcvr: Add support for i.MX95 platform 2024-06-03 17:04:40 +01:00
imx-audio-rpmsg.c ASoC: fsl: Let imx-audio-rpmsg register platform device for card 2024-03-25 00:32:50 +00:00
imx-audmix.c ASoC: fsl: Rename stream name of SAI DAI driver 2025-03-07 18:25:30 +01:00
imx-audmux.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
imx-audmux.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
imx-card.c ASoC: fsl: imx-card: Do not force slot width to sample width 2026-02-06 16:55:45 +01:00
imx-es8328.c ASoC: fsl: Remove unused of_gpio.h 2024-06-10 12:48:37 +01:00
imx-hdmi.c ASoC: fsl: Use snd_soc_substream_to_rtd() for accessing private_data 2024-05-06 23:59:51 +09:00
imx-pcm-dma.c ASoC: fsl: add missing MODULE_DESCRIPTION() macro 2024-06-03 15:59:20 +01:00
imx-pcm-fiq.c ASoC: fsl: imx-pcm-fiq: add missing MODULE_DESCRIPTION() macro 2024-06-17 13:08:28 +01:00
imx-pcm-rpmsg.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
imx-pcm-rpmsg.h ASoC: imx-pcm-rpmsg: Fix warning of incorrect type in assignment 2021-05-10 13:05:38 +01:00
imx-pcm.h ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data() 2022-09-23 13:56:25 +01:00
imx-rpmsg.c ASoC: fsl: Remove unused of_gpio.h 2024-06-10 12:48:37 +01:00
imx-sgtl5000.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
imx-ssi.h dmaengine: imx: Move header to include/dma/ 2022-04-19 12:06:18 +01:00
Kconfig firmware: arm_scmi: Fix i.MX build dependency 2024-12-27 14:01:57 +01:00
lpc3xxx-i2s.c ASoC: fsl: lpc3xxx: Make some symbols static 2024-08-02 14:05:32 +01:00
lpc3xxx-i2s.h ASoC: fsl: lpc3xxx-i2s: Include bitfield.h for FIELD_PREP 2024-07-01 20:07:28 +01:00
lpc3xxx-pcm.c ASoC: fsl: lpc3xxx: Make some symbols static 2024-08-02 14:05:32 +01:00
Makefile ASoC: fsl-asoc-card: merge spdif support from imx-spdif.c 2024-07-08 16:09:38 +01:00
mpc5200_dma.c ASoC: fsl: mpc5200_dma.c: Fix warning of Function parameter or member not described 2023-10-10 12:39:37 +01:00
mpc5200_dma.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mpc5200_psc_ac97.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
mpc5200_psc_i2s.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
p1022_ds.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
p1022_rdk.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00
pcm030-audio-fabric.c ASoC: Switch back to struct platform_driver::remove() 2024-09-09 18:26:49 +01:00