linux/drivers/phy/tegra
Ma Ke b2ea5f4958 phy: Fix error handling in tegra_xusb_port_init
If device_add() fails, do not use device_unregister() for error
handling. device_unregister() consists two functions: device_del() and
put_device(). device_unregister() should only be called after
device_add() succeeded because device_del() undoes what device_add()
does if successful. Change device_unregister() to put_device() call
before returning from the function.

As comment of device_add() says, 'if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count'.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 53d2a715c2 ("phy: Add Tegra XUSB pad controller support")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20250303072739.3874987-1-make24@iscas.ac.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
History 2025-05-14 12:28:43 +01:00
..
Kconfig phy: tegra194: p2u: Allow to enable driver on Tegra234 2024-12-04 19:15:48 +05:30
Makefile phy: tegra: xusb: Add Tegra234 support 2023-01-12 22:57:06 +05:30
phy-tegra194-p2u.c phy: Explicitly include correct DT includes 2023-07-17 11:52:56 +05:30
xusb-tegra124.c phy: tegra: xusb: Remove usb3 supply 2022-11-07 10:20:25 +05:30
xusb-tegra186.c phy: tegra: xusb: remove a stray unlock 2025-05-14 12:21:18 +01:00
xusb-tegra210.c phy: tegra: xusb: Remove usb3 supply 2022-11-07 10:20:25 +05:30
xusb.c phy: Fix error handling in tegra_xusb_port_init 2025-05-14 12:28:43 +01:00
xusb.h phy: tegra: xusb: Support sleepwalk for Tegra234 2023-03-20 18:14:59 +05:30