linux/drivers/platform
Bartosz Golaszewski 19d61f032c platform/x86: intel: chtwc_int33fe: don't dereference swnode args
commit 527250cd90 upstream.

Members of struct software_node_ref_args should not be dereferenced
directly but set using the provided macros. Commit d7cdbbc93c
("software node: allow referencing firmware nodes") changed the name of
the software node member and caused a build failure. Remove all direct
dereferences of the ref struct as a fix.

However, this driver also seems to abuse the software node interface by
waiting for a node with an arbitrary name "intel-xhci-usb-sw" to appear
in the system before setting up the reference for the I2C device, while
the actual software node already exists in the intel-xhci-usb-role-switch
module and should be used to set up a static reference. Add a FIXME for
a future improvement.

Fixes: d7cdbbc93c ("software node: allow referencing firmware nodes")
Fixes: 53c24c2932 ("platform/x86: intel_cht_int33fe: use inline reference properties")
Cc: stable@vger.kernel.org
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20251121111534.7cdbfe5c@canb.auug.org.au/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2026-01-02 12:57:29 +01:00
..
arm64 platform: arm64: thinkpad-t14s-ec: sleep after EC access 2025-11-21 19:05:27 +02:00
chrome platform/chrome: cros_ec_ishtp: Fix UAF after unbinding driver 2026-01-02 12:57:19 +01:00
cznic treewide: rename GPIO set callbacks back to their original names 2025-08-07 10:07:06 +02:00
goldfish Get rid of 'remove_new' relic from platform driver struct 2024-12-01 15:12:43 -08:00
loongarch platform/loongarch: laptop: Unregister generic_sub_drivers on exit 2025-06-07 11:37:15 +08:00
mellanox platform/mellanox: mlxbf-pmc: add sysfs_attr_init() to count_clock init 2025-10-15 11:12:57 +03:00
mips platform: mips: cpu_hwmon: Disable driver on unsupported hardware 2024-06-21 10:22:10 +02:00
olpc platform-drivers-x86 for v6.12-1 2024-09-19 09:16:04 +02:00
surface platform: Do not enable by default during compile testing 2025-04-24 15:53:35 +03:00
x86 platform/x86: intel: chtwc_int33fe: don't dereference swnode args 2026-01-02 12:57:29 +01:00
Kconfig platform: cznic: Add preliminary support for Turris Omnia MCU 2024-07-01 15:46:36 +02:00
Makefile platform-drivers-x86 for v6.11-1 2024-07-17 17:05:21 -07:00