Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Qu Wenruo f79a80c7fc btrfs: fix a potential path leak in print_data_reloc_error() ...

[ Upstream commit 313ef70a9f ]

Inside print_data_reloc_error(), if extent_from_logical() failed we
return immediately.

However there are the following cases where extent_from_logical() can
return error but still holds a path:

- btrfs_search_slot() returned 0

- No backref item found in extent tree

- No flags_ret provided
  This is not possible in this call site though.

So for the above two cases, we can return without releasing the path,
causing extent buffer leaks.

Fixes: b9a9a85059 ("btrfs: output affected files when relocation fails")
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2026-01-02 12:56:37 +01:00

10594 lines

303 KiB

Raw Permalink Blame History