Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Ewan D. Milne 0a2c5495b6 nvme: nvme-fc: Ensure ->ioerr_work is cancelled in nvme_fc_delete_ctrl() ... nvme_fc_delete_assocation() waits for pending I/O to complete before returning, and an error can cause ->ioerr_work to be queued after cancel_work_sync() had been called. Move the call to cancel_work_sync() to be after nvme_fc_delete_association() to ensure ->ioerr_work is not running when the nvme_fc_ctrl object is freed. Otherwise the following can occur: [ 1135.911754] list_del corruption, ff2d24c8093f31f8->next is NULL [ 1135.917705] ------------[ cut here ]------------ [ 1135.922336] kernel BUG at lib/list_debug.c:52! [ 1135.926784] Oops: invalid opcode: 0000 [#1] SMP NOPTI [ 1135.931851] CPU: 48 UID: 0 PID: 726 Comm: kworker/u449:23 Kdump: loaded Not tainted 6.12.0 #1 PREEMPT(voluntary) [ 1135.943490] Hardware name: Dell Inc. PowerEdge R660/0HGTK9, BIOS 2.5.4 01/16/2025 [ 1135.950969] Workqueue: 0x0 (nvme-wq) [ 1135.954673] RIP: 0010:__list_del_entry_valid_or_report.cold+0xf/0x6f [ 1135.961041] Code: c7 c7 98 68 72 94 e8 26 45 fe ff 0f 0b 48 c7 c7 70 68 72 94 e8 18 45 fe ff 0f 0b 48 89 fe 48 c7 c7 80 69 72 94 e8 07 45 fe ff <0f> 0b 48 89 d1 48 c7 c7 a0 6a 72 94 48 89 c2 e8 f3 44 fe ff 0f 0b [ 1135.979788] RSP: 0018:ff579b19482d3e50 EFLAGS: 00010046 [ 1135.985015] RAX: 0000000000000033 RBX: ff2d24c8093f31f0 RCX: 0000000000000000 [ 1135.992148] RDX: 0000000000000000 RSI: ff2d24d6bfa1d0c0 RDI: ff2d24d6bfa1d0c0 [ 1135.999278] RBP: ff2d24c8093f31f8 R08: 0000000000000000 R09: ffffffff951e2b08 [ 1136.006413] R10: ffffffff95122ac8 R11: 0000000000000003 R12: ff2d24c78697c100 [ 1136.013546] R13: fffffffffffffff8 R14: 0000000000000000 R15: ff2d24c78697c0c0 [ 1136.020677] FS: 0000000000000000(0000) GS:ff2d24d6bfa00000(0000) knlGS:0000000000000000 [ 1136.028765] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1136.034510] CR2: 00007fd207f90b80 CR3: 000000163ea22003 CR4: 0000000000f73ef0 [ 1136.041641] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1136.048776] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 [ 1136.055910] PKRU: 55555554 [ 1136.058623] Call Trace: [ 1136.061074] <TASK> [ 1136.063179] ? show_trace_log_lvl+0x1b0/0x2f0 [ 1136.067540] ? show_trace_log_lvl+0x1b0/0x2f0 [ 1136.071898] ? move_linked_works+0x4a/0xa0 [ 1136.075998] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.081744] ? __die_body.cold+0x8/0x12 [ 1136.085584] ? die+0x2e/0x50 [ 1136.088469] ? do_trap+0xca/0x110 [ 1136.091789] ? do_error_trap+0x65/0x80 [ 1136.095543] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.101289] ? exc_invalid_op+0x50/0x70 [ 1136.105127] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.110874] ? asm_exc_invalid_op+0x1a/0x20 [ 1136.115059] ? __list_del_entry_valid_or_report.cold+0xf/0x6f [ 1136.120806] move_linked_works+0x4a/0xa0 [ 1136.124733] worker_thread+0x216/0x3a0 [ 1136.128485] ? __pfx_worker_thread+0x10/0x10 [ 1136.132758] kthread+0xfa/0x240 [ 1136.135904] ? __pfx_kthread+0x10/0x10 [ 1136.139657] ret_from_fork+0x31/0x50 [ 1136.143236] ? __pfx_kthread+0x10/0x10 [ 1136.146988] ret_from_fork_asm+0x1a/0x30 [ 1136.150915] </TASK> Fixes: 19fce0470f ("nvme-fc: avoid calling _nvme_fc_abort_outstanding_ios from interrupt context") Cc: stable@vger.kernel.org Tested-by: Marco Patalano <mpatalan@redhat.com> Reviewed-by: Justin Tee <justin.tee@broadcom.com> Signed-off-by: Ewan D. Milne <emilne@redhat.com> Signed-off-by: Keith Busch <kbusch@kernel.org>		History 2025-11-17 09:00:42 -08:00
..
apple.c	nvme: apple: Add Apple A11 support	2025-09-06 10:04:32 +02:00
auth.c	nvme-auth: update sc_c in host response	2025-10-14 08:28:31 -07:00
constants.c	nvme: fix typo in status code constant for self-test in progress	2025-07-17 13:38:07 +02:00
core.c	nvme: fix admin request_queue lifetime	2025-11-05 12:50:46 -08:00
fabrics.c	nvme: spelling fixes	2025-06-04 10:23:28 +02:00
fabrics.h	nvme: spelling fixes	2025-06-04 10:23:28 +02:00
fault_inject.c	fault-inject: improve build for CONFIG_FAULT_INJECTION=n	2024-09-01 20:43:33 -07:00
fc.c	nvme: nvme-fc: Ensure ->ioerr_work is cancelled in nvme_fc_delete_ctrl()	2025-11-17 09:00:42 -08:00
fc.h	nvme-fc: Update header and host for common definitions for LS handling	2020-05-09 16:18:33 -06:00
hwmon.c	move asm/unaligned.h to linux/unaligned.h	2024-10-02 17:23:23 -04:00
ioctl.c	for-6.18/block-20250929	2025-10-02 10:16:56 -07:00
Kconfig	block-6.16-20250606	2025-06-06 13:12:50 -07:00
Makefile	nvme: rework NVME_AUTH Kconfig selection	2023-10-12 08:04:49 -07:00
multipath.c	nvme-multipath: fix lockdep WARN due to partition scan work	2025-11-17 08:08:00 -08:00
nvme.h	block: switch ->getgeo() to struct gendisk	2025-08-13 02:59:29 -04:00
pci.c	nvme-pci: use blk_map_iter for p2p metadata	2025-10-22 19:46:25 -07:00
pr.c	nvme: fix command limits status code	2025-06-04 09:51:10 +02:00
rdma.c	nvme: fix multiple spelling and grammar issues in host drivers	2025-07-17 13:38:06 +02:00
sysfs.c	for-6.16/block-20250523	2025-05-26 11:39:36 -07:00
tcp.c	nvme/tcp: handle tls partially sent records in write_space()	2025-10-16 11:32:04 -07:00
trace.c	nvme: parse reservation commands's action and rtype to string	2024-11-13 08:51:24 -08:00
trace.h	nvme: fix async event trace event	2023-04-13 08:59:04 +02:00
zns.c	nvme: zns: Simplify nvme_zone_parse_entry()	2025-03-20 16:53:55 -07:00