linux/fs/erofs
Gao Xiang 823ba1d210 erofs: fix inconsistent per-file compression format
[ Upstream commit 118a8cf504 ]

EROFS can select compression algorithms on a per-file basis, and each
per-file compression algorithm needs to be marked in the on-disk
superblock for initialization.

However, syzkaller can generate inconsistent crafted images that use
an unsupported algorithmtype for specific inodes, e.g. use MicroLZMA
algorithmtype even it's not set in `sbi->available_compr_algs`.  This
can lead to an unexpected "BUG: kernel NULL pointer dereference" if
the corresponding decompressor isn't built-in.

Fix this by checking against `sbi->available_compr_algs` for each
m_algorithmformat request.  Incorrect !erofs_sb_has_compr_cfgs preset
bitmap is now fixed together since it was harmless previously.

Reported-by: <bugreport@ubisectech.com>
Fixes: 8f89926290 ("erofs: get compression algorithms directly on mapping")
Fixes: 622ceaddb7 ("erofs: lzma compression support")
Reviewed-by: Yue Hu <huyue2@coolpad.com>
Link: https://lore.kernel.org/r/20240113150602.1471050-1-hsiangkao@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-01-25 15:35:57 -08:00
..
compress.h erofs: simplify compression configuration parser 2024-01-25 15:35:57 -08:00
data.c mm: remove enum page_entry_size 2023-08-24 16:20:30 -07:00
decompressor.c erofs: fix inconsistent per-file compression format 2024-01-25 15:35:57 -08:00
decompressor_deflate.c erofs: simplify compression configuration parser 2024-01-25 15:35:57 -08:00
decompressor_lzma.c erofs: simplify compression configuration parser 2024-01-25 15:35:57 -08:00
dir.c erofs: keep meta inode into erofs_buf 2023-04-17 01:15:50 +08:00
erofs_fs.h erofs: update on-disk format for xattr name filter 2023-08-11 12:11:44 +08:00
fscache.c erofs: avoid hardcoded blocksize for subpage block support 2023-04-17 01:15:44 +08:00
inode.c v6.6-vfs.ctime 2023-08-28 09:31:32 -07:00
internal.h erofs: simplify compression configuration parser 2024-01-25 15:35:57 -08:00
Kconfig erofs: boost negative xattr lookup with bloom filter 2023-08-11 12:11:44 +08:00
Makefile erofs: DEFLATE compression support 2023-08-11 12:11:17 +08:00
namei.c erofs: sunset erofs_dbg() 2023-04-17 01:15:54 +08:00
pcpubuf.c erofs: mark z_erofs_lzma_init/erofs_pcpubuf_init w/ __init 2023-03-09 22:49:30 +08:00
super.c erofs: simplify compression configuration parser 2024-01-25 15:35:57 -08:00
sysfs.c erofs: make kobj_type structures constant 2023-02-15 08:11:26 +08:00
utils.c erofs: fix erofs_insert_workgroup() lockref usage 2023-11-20 11:59:23 +01:00
xattr.c erofs: boost negative xattr lookup with bloom filter 2023-08-11 12:11:44 +08:00
xattr.h Changes since last update: 2023-04-24 14:25:39 -07:00
zdata.c erofs: fix memory leak on short-lived bounced pages 2024-01-25 15:35:17 -08:00
zmap.c erofs: fix inconsistent per-file compression format 2024-01-25 15:35:57 -08:00