kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-26 19:14:18 +00:00
Code Issues Releases Packages Activity
linux/drivers/infiniband/hw
History
Chengfeng Ye 67288cbb7a IB/hfi1: Fix potential deadlock on &irq_src_lock and &dd->uctxt_lock 
[ Upstream commit 2f19c4b839 ]

handle_receive_interrupt_napi_sp() running inside interrupt handler
could introduce inverse lock ordering between &dd->irq_src_lock
and &dd->uctxt_lock, if read_mod_write() is preempted by the isr.

          [CPU0]                                        |          [CPU1]
hfi1_ipoib_dev_open()                                   |
--> hfi1_netdev_enable_queues()                         |
--> enable_queues(rx)                                   |
--> hfi1_rcvctrl()                                      |
--> set_intr_bits()                                     |
--> read_mod_write()                                    |
--> spin_lock(&dd->irq_src_lock)                        |
                                                        | hfi1_poll()
                                                        | --> poll_next()
                                                        | --> spin_lock_irq(&dd->uctxt_lock)
                                                        |
                                                        | --> hfi1_rcvctrl()
                                                        | --> set_intr_bits()
                                                        | --> read_mod_write()
                                                        | --> spin_lock(&dd->irq_src_lock)
<interrupt>                                             |
   --> handle_receive_interrupt_napi_sp()               |
   --> set_all_fastpath()                               |
   --> hfi1_rcd_get_by_index()                          |
   --> spin_lock_irqsave(&dd->uctxt_lock)               |

This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.

To prevent the potential deadlock, the patch use spin_lock_irqsave()
on &dd->irq_src_lock inside read_mod_write() to prevent the possible
deadlock scenario.

Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Link: https://lore.kernel.org/r/20230926101116.2797-1-dg573847474@gmail.com
Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-08-29 17:33:29 +02:00
..
bnxt_re bnxt_re: Fix imm_data endianness 2024-08-03 08:54:04 +02:00
cxgb4 RDMA/cxgb4: Check skb value for failure to allocate 2023-09-11 14:55:53 +03:00
efa RDMA/efa: Fix wrong resources deallocation order 2023-08-22 17:21:53 +03:00
erdma RDMA/erdma: Fix NULL pointer access in regmr_cmd 2023-09-18 10:42:19 +03:00
hfi1 IB/hfi1: Fix potential deadlock on &irq_src_lock and &dd->uctxt_lock 2024-08-29 17:33:29 +02:00
hns RDMA/hns: Fix insufficient extend DB for VFs. 2024-08-03 08:54:03 +02:00
irdma RDMA/irdma: Remove duplicate assignment 2024-03-26 18:19:58 -04:00
mana RDMA/mana_ib: Ignore optional access flags for MRs 2024-06-27 13:49:10 +02:00
mlx4 RDMA/mlx4: Fix truncated output warning in alias_GUID.c 2024-08-03 08:53:59 +02:00
mlx5 RDMA/mlx5: Set mkeys for dmabuf at PAGE_SIZE 2024-08-03 08:53:57 +02:00
mthca RDMA/usnic: Silence uninitialized symbol smatch warnings 2024-01-25 15:35:31 -08:00
ocrdma RDMA: Remove unnecessary ternary operators 2023-07-31 15:16:12 +03:00
qedr RDMA/qedr: Fix qedr_create_user_qp error flow 2024-03-01 13:35:05 +01:00
qib qibfs: fix dentry leak 2024-05-17 12:02:20 +02:00
usnic mm/gup: remove vmas parameter from pin_user_pages() 2023-06-09 16:25:26 -07:00
vmw_pvrdma RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode 2023-06-09 14:11:53 -03:00
Makefile RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter 2022-11-11 11:40:09 +02:00