kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-10-26 19:14:18 +00:00
Code Issues Releases Packages Activity
linux/drivers/i3c/master
History
Kaixin Wang ea0256e393 i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition 
[ Upstream commit 609366e7a0 ]

In the cdns_i3c_master_probe function, &master->hj_work is bound with
cdns_i3c_master_hj. And cdns_i3c_master_interrupt can call
cnds_i3c_master_demux_ibis function to start the work.

If we remove the module which will call cdns_i3c_master_remove to
make cleanup, it will free master->base through i3c_master_unregister
while the work mentioned above will be used. The sequence of operations
that may lead to a UAF bug is as follows:

CPU0                                      CPU1

                                     | cdns_i3c_master_hj
cdns_i3c_master_remove               |
i3c_master_unregister(&master->base) |
device_unregister(&master->dev)      |
device_release                       |
//free master->base                  |
                                     | i3c_master_do_daa(&master->base)
                                     | //use master->base

Fix it by ensuring that the work is canceled before proceeding with
the cleanup in cdns_i3c_master_remove.

Signed-off-by: Kaixin Wang <kxwang23@m.fudan.edu.cn>
Link: https://lore.kernel.org/r/20240911153544.848398-1-kxwang23@m.fudan.edu.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2024-10-17 15:24:17 +02:00
..
mipi-i3c-hci i3c: mipi-i3c-hci: Error out instead on BUG_ON() in IBI DMA setup 2024-09-12 11:11:38 +02:00
ast2600-i3c-master.c i3c: Explicitly include correct DT includes 2023-07-27 23:23:41 +02:00
dw-i3c-master.c i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling 2024-03-26 18:20:01 -04:00
dw-i3c-master.h i3c: dw: Add a platform facility for IBI PEC workarounds 2023-04-28 08:20:07 +02:00
i3c-master-cdns.c i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition 2024-10-17 15:24:17 +02:00
Kconfig i3c: ast2600: Add AST2600 platform-specific driver 2023-04-28 08:19:01 +02:00
Makefile i3c: ast2600: Add AST2600 platform-specific driver 2023-04-28 08:19:01 +02:00
svc-i3c-master.c i3c: master: svc: Fix use after free vulnerability in svc_i3c_master Driver Due to Race Condition 2024-10-10 11:57:53 +02:00