Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Linus Torvalds 4356e9f841 work around gcc bugs with 'asm goto' with outputs ... We've had issues with gcc and 'asm goto' before, and we created a 'asm_volatile_goto()' macro for that in the past: see commits 3f0116c323 ("compiler/gcc4: Add quirk for 'asm goto' miscompilation bug") and a9f180345f ("compiler/gcc4: Make quirk for asm_volatile_goto() unconditional"). Then, much later, we ended up removing the workaround in commit 43c249ea0b ("compiler-gcc.h: remove ancient workaround for gcc PR 58670") because we no longer supported building the kernel with the affected gcc versions, but we left the macro uses around. Now, Sean Christopherson reports a new version of a very similar problem, which is fixed by re-applying that ancient workaround. But the problem in question is limited to only the 'asm goto with outputs' cases, so instead of re-introducing the old workaround as-is, let's rename and limit the workaround to just that much less common case. It looks like there are at least two separate issues that all hit in this area: (a) some versions of gcc don't mark the asm goto as 'volatile' when it has outputs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98619 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 which is easy to work around by just adding the 'volatile' by hand. (b) Internal compiler errors: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110422 which are worked around by adding the extra empty 'asm' as a barrier, as in the original workaround. but the problem Sean sees may be a third thing since it involves bad code generation (not an ICE) even with the manually added 'volatile'. but the same old workaround works for this case, even if this feels a bit like voodoo programming and may only be hiding the issue. Reported-and-tested-by: Sean Christopherson <seanjc@google.com> Link: https://lore.kernel.org/all/20240208220604.140859-1-seanjc@google.com/ Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Uros Bizjak <ubizjak@gmail.com> Cc: Jakub Jelinek <jakub@redhat.com> Cc: Andrew Pinski <quic_apinski@quicinc.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		History 2024-02-09 15:57:48 -08:00
..
boot	xtensa: boot/lib: fix function prototypes	2023-09-20 05:03:30 -07:00
configs	treewide: drop CONFIG_EMBEDDED	2023-08-21 13:46:25 -07:00
include	work around gcc bugs with 'asm goto' with outputs	2024-02-09 15:57:48 -08:00
kernel	lsm/stable-6.8 PR 20240105	2024-01-09 12:57:46 -08:00
lib	xtensa: Use PCI_HEADER_TYPE_MFD instead of literal	2023-11-29 02:07:52 -08:00
mm	xtensa: tlb: include <asm/tlb.h> for missing prototype	2023-09-20 05:03:21 -07:00
platforms	tty: xtensa/iss: use u8	2023-12-08 12:02:38 +01:00
variants	xtensa: add test_kc705_be variant	2018-08-20 12:34:45 -07:00
Kbuild	xtensa: move core-y in arch/xtensa/Makefile to arch/xtensa/Kbuild	2021-08-11 11:37:13 -07:00
Kconfig	Xtensa updates for v6.8	2024-01-17 11:40:52 -08:00
Kconfig.debug	xtensa: dump userspace code around the exception PC	2023-06-24 06:34:27 -07:00
Makefile	xtensa: don't produce FDPIC output with fdpic toolchain	2024-01-11 18:58:47 -08:00