kernel/linux
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ synced 2026-09-26 18:16:26 +00:00
Code Issues Releases Packages Activity
linux/sound/virtio
History
Aiswarya Cyriac ba00e413fa ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning. 
This commit fixes the following warning when building virtio_snd driver.

"
*** CID 1583619:  Uninitialized variables  (UNINIT)
sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op()
288
289     		break;
290     	}
291
292     	kfree(tlv);
293
vvv     CID 1583619:  Uninitialized variables  (UNINIT)
vvv     Using uninitialized value "rc".
294     	return rc;
295     }
296
297     /**
298      * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED element type.
299      * @snd: VirtIO sound device.
"

This warning is caused by the absence of the "default" branch in the
switch-block, and is a false positive because the kernel calls
virtsnd_kctl_tlv_op() only with values for op_flag processed in
this block.

Also, this commit unifies the cleanup path for all possible control
paths in the callback function.

Signed-off-by: Anton Yakovlev <anton.yakovlev@opensynergy.com>
Signed-off-by: Aiswarya Cyriac <aiswarya.cyriac@opensynergy.com>
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1583619 ("Uninitialized variables")
Fixes: d6568e3de4 ("ALSA: virtio: add support for audio controls")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://lore.kernel.org/r/20240216100643.688590-1-aiswarya.cyriac@opensynergy.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
History 2024-02-16 15:01:31 +01:00
..
Kconfig ALSA: virtio: add virtio sound driver 2021-03-07 09:07:16 +01:00
Makefile ALSA: virtio: add support for audio controls 2024-02-09 14:01:15 +01:00
virtio_card.c ALSA: virtio: add support for audio controls 2024-02-09 14:01:15 +01:00
virtio_card.h ALSA: virtio: add support for audio controls 2024-02-09 14:01:15 +01:00
virtio_chmap.c ALSA: virtio: introduce PCM channel map support 2021-03-07 09:08:20 +01:00
virtio_ctl_msg.c ALSA: virtio: remove duplicate check if queue is broken 2024-01-24 14:41:37 +01:00
virtio_ctl_msg.h ALSA: virtio: handling control messages 2021-03-07 09:07:27 +01:00
virtio_jack.c ALSA: virtio: introduce jack support 2021-03-07 09:08:11 +01:00
virtio_kctl.c ALSA: virtio: Fix "Coverity: virtsnd_kctl_tlv_op(): Uninitialized variables" warning. 2024-02-16 15:01:31 +01:00
virtio_pcm.c ALSA: virtio: use ack callback 2023-10-27 11:25:07 +02:00
virtio_pcm.h ALSA: virtio: use ack callback 2023-10-27 11:25:07 +02:00
virtio_pcm_msg.c ALSA: virtio: remove duplicate check if queue is broken 2024-01-24 14:41:37 +01:00
virtio_pcm_ops.c ALSA: virtio: use ack callback 2023-10-27 11:25:07 +02:00