mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/
synced 2026-11-10 20:48:12 +00:00
1aa9e143bf
rtnl_create_link() assigns IFLA_TXQLEN directly to dev->tx_queue_len
without going through netif_change_tx_queue_len(), so a device created
with "ip link add ... txqueuelen 500000" bypasses the S16_MAX cap and
still triggers the oversized ring allocations in pfifo_fast, tun and
tap. The veth peer nest (rtnl_nla_parse_ifinfomsg()) and the
RTM_NEWLINK-on-existing-device path reach the same sinks.
Enforce the cap in ifla_policy instead: IFLA_TXQLEN becomes
NLA_POLICY_FULL_RANGE(NLA_U32, &txqlen_range) with
txqlen_range = { .min = 0, .max = S16_MAX }. All netlink consumers
parse against this policy - rtnl_setlink(), rtnl_newlink() (create
and change), and the veth peer nest - so every netlink path is capped
at parse time and rejects the attribute with -ERANGE plus a proper
"integer out of range" extack message before any device state is
modified (the RTM_SETLINK half-application wart is gone with it).
Document the bound in the rt-link.yaml netlink spec.
Conditions to recreate the bug:
- CONFIG_NET_SCHED=y, CONFIG_VETH=y, CONFIG_USER_NS=y, CONFIG_NET_NS=y.
- Unprivileged user in a fresh user+net namespace (unshare -Urn):
ip link add v0 txqueuelen 500000 type veth peer name v1
-> on the fixed kernel this is rejected with -ERANGE ("integer out
of range" extack) instead of installing an oversized tx_queue_len
that later inflates pfifo_fast/tun/tap ring allocations.
- ip link set v0 txqueuelen 500000 is likewise rejected at parse time.
Fixes:
|
History
|
|
|---|---|---|
| .. | ||
| binder.yaml | ||
| conntrack.yaml | ||
| dev-energymodel.yaml | ||
| devlink.yaml | ||
| dpll.yaml | ||
| drm_ras.yaml | ||
| ethtool.yaml | ||
| fou.yaml | ||
| handshake.yaml | ||
| index.rst | ||
| lockd.yaml | ||
| mptcp_pm.yaml | ||
| net_shaper.yaml | ||
| netdev.yaml | ||
| nfsd.yaml | ||
| nftables.yaml | ||
| nl80211.yaml | ||
| nlctrl.yaml | ||
| ovpn.yaml | ||
| ovs_datapath.yaml | ||
| ovs_flow.yaml | ||
| ovs_packet.yaml | ||
| ovs_vport.yaml | ||
| psp.yaml | ||
| rt-addr.yaml | ||
| rt-link.yaml | ||
| rt-neigh.yaml | ||
| rt-route.yaml | ||
| rt-rule.yaml | ||
| sunrpc_cache.yaml | ||
| tc.yaml | ||
| tcp_metrics.yaml | ||
| team.yaml | ||
| wireguard.yaml | ||