From f8e8829c3adad41a48b1615a1084c55c07df206b Mon Sep 17 00:00:00 2001 From: Hydra de lerne <162022179+Hydralerne@users.noreply.github.com> Date: Thu, 12 Nov 2026 18:03:33 +0200 Subject: [PATCH 01/84] fix: unify project settings, refine web navigation, and restore CI (#1738) * chore: keep generated review artifacts out of git * fix(dashboard): keep single apps in the service settings flow * fix(web): refine Arabic landing and navigation * fix(core): align host channel branding with dashboard copy --- .gitignore | 3 + .../[id]/components/BuildSettings.tsx | 330 +++--------------- .../[id]/components/DomainSettings.tsx | 19 +- .../components/environment-scope.test.tsx | 93 ++++- .../services/ProjectApplicationPanel.tsx | 17 +- .../services/service-domains.test.tsx | 33 +- .../BuildSettings.domains.test.tsx | 26 ++ .../import-project/BuildSettings.tsx | 25 +- .../ApplicationSettingsForm.tsx | 233 +++++++++++++ .../src/i18n/locales/ar/projectSettings.json | 10 +- .../src/i18n/locales/de/projectSettings.json | 10 +- .../src/i18n/locales/en/projectSettings.json | 10 +- .../src/i18n/locales/es/projectSettings.json | 10 +- .../src/i18n/locales/fr/projectSettings.json | 10 +- .../src/i18n/locales/ja/projectSettings.json | 10 +- .../src/i18n/locales/pt/projectSettings.json | 10 +- .../src/i18n/locales/ru/projectSettings.json | 10 +- .../src/i18n/locales/tr/projectSettings.json | 10 +- .../src/i18n/locales/zh/projectSettings.json | 10 +- .../translate language-115-1663582874.png | Bin 0 -> 1823 bytes apps/web/src/app/globals.css | 14 +- apps/web/src/components/landing/hero.tsx | 4 +- .../components/landing/language-switcher.tsx | 4 +- apps/web/src/components/landing/navbar.tsx | 21 +- apps/web/src/i18n/messages/ar.json | 6 +- artifacts/project-consistency/.gitignore | 1 - .../after-add-postgres-form.png | Bin 80884 -> 0 bytes .../project-consistency/after-add-service.png | Bin 105388 -> 0 bytes .../project-consistency/after-app-apply.png | Bin 74825 -> 0 bytes .../project-consistency/after-app-dark.png | Bin 75620 -> 0 bytes .../project-consistency/after-app-dim.png | Bin 76280 -> 0 bytes .../after-app-environment.png | Bin 69397 -> 0 bytes .../project-consistency/after-app-light.png | Bin 75866 -> 0 bytes .../after-app-overview.png | Bin 44541 -> 0 bytes .../after-app-with-postgres.png | Bin 75622 -> 0 bytes .../after-arabic-mobile.png | Bin 67612 -> 0 bytes .../project-consistency/after-mobile.png | Bin 70729 -> 0 bytes .../after-postgres-environment.png | Bin 72750 -> 0 bytes .../after-project-settings.png | Bin 45194 -> 0 bytes .../project-consistency/after-single-app.png | Bin 32855 -> 0 bytes .../after-with-postgres.png | Bin 38747 -> 0 bytes .../before-after-comparison.png | Bin 32693 -> 0 bytes .../before-apps-services.png | Bin 40548 -> 0 bytes .../before-settings-editor.png | Bin 51542 -> 0 bytes .../project-consistency/browser-checks.json | 68 ---- artifacts/project-consistency/index.html | 11 - .../single-to-postgres-comparison.png | Bin 22462 -> 0 bytes artifacts/project-consistency/validation.json | 14 - .../after-application-apply.png | Bin 81828 -> 0 bytes .../after-application-arabic-mobile.png | Bin 57567 -> 0 bytes .../after-application-dim.png | Bin 66063 -> 0 bytes .../after-application-environment.png | Bin 65549 -> 0 bytes .../after-application-light.png | Bin 65789 -> 0 bytes .../after-application-mobile.png | Bin 61626 -> 0 bytes .../after-apps-services-docker.png | Bin 43625 -> 0 bytes .../after-apps-services.png | Bin 41956 -> 0 bytes .../after-browser-checks.json | 40 --- .../after-settings-editor.png | Bin 52611 -> 0 bytes .../app-card-comparison.png | Bin 33598 -> 0 bytes .../before-apps-services.png | Bin 40548 -> 0 bytes .../before-browser-checks.json | 5 - .../before-settings-editor.png | Bin 51542 -> 0 bytes artifacts/project-environment/index.html | 14 - .../settings-comparison.png | Bin 59142 -> 0 bytes artifacts/project-environment/validation.json | 16 - docs/client-icons.md | 2 + docs/dashboard-design.md | 9 +- packages/core/src/host-channel.ts | 2 +- .../project-consistency/Preview.tsx | 17 +- .../screenshots/project-consistency/README.md | 11 +- .../project-consistency/capture.mjs | 62 +++- .../project-consistency/fixture.mjs | 32 +- .../project-consistency/review.mjs | 18 +- 73 files changed, 685 insertions(+), 565 deletions(-) create mode 100644 apps/dashboard/src/components/project-settings/ApplicationSettingsForm.tsx create mode 100644 apps/web/public/icons/translate language-115-1663582874.png delete mode 100644 artifacts/project-consistency/.gitignore delete mode 100644 artifacts/project-consistency/after-add-postgres-form.png delete mode 100644 artifacts/project-consistency/after-add-service.png delete mode 100644 artifacts/project-consistency/after-app-apply.png delete mode 100644 artifacts/project-consistency/after-app-dark.png delete mode 100644 artifacts/project-consistency/after-app-dim.png delete mode 100644 artifacts/project-consistency/after-app-environment.png delete mode 100644 artifacts/project-consistency/after-app-light.png delete mode 100644 artifacts/project-consistency/after-app-overview.png delete mode 100644 artifacts/project-consistency/after-app-with-postgres.png delete mode 100644 artifacts/project-consistency/after-arabic-mobile.png delete mode 100644 artifacts/project-consistency/after-mobile.png delete mode 100644 artifacts/project-consistency/after-postgres-environment.png delete mode 100644 artifacts/project-consistency/after-project-settings.png delete mode 100644 artifacts/project-consistency/after-single-app.png delete mode 100644 artifacts/project-consistency/after-with-postgres.png delete mode 100644 artifacts/project-consistency/before-after-comparison.png delete mode 100644 artifacts/project-consistency/before-apps-services.png delete mode 100644 artifacts/project-consistency/before-settings-editor.png delete mode 100644 artifacts/project-consistency/browser-checks.json delete mode 100644 artifacts/project-consistency/index.html delete mode 100644 artifacts/project-consistency/single-to-postgres-comparison.png delete mode 100644 artifacts/project-consistency/validation.json delete mode 100644 artifacts/project-environment/after-application-apply.png delete mode 100644 artifacts/project-environment/after-application-arabic-mobile.png delete mode 100644 artifacts/project-environment/after-application-dim.png delete mode 100644 artifacts/project-environment/after-application-environment.png delete mode 100644 artifacts/project-environment/after-application-light.png delete mode 100644 artifacts/project-environment/after-application-mobile.png delete mode 100644 artifacts/project-environment/after-apps-services-docker.png delete mode 100644 artifacts/project-environment/after-apps-services.png delete mode 100644 artifacts/project-environment/after-browser-checks.json delete mode 100644 artifacts/project-environment/after-settings-editor.png delete mode 100644 artifacts/project-environment/app-card-comparison.png delete mode 100644 artifacts/project-environment/before-apps-services.png delete mode 100644 artifacts/project-environment/before-browser-checks.json delete mode 100644 artifacts/project-environment/before-settings-editor.png delete mode 100644 artifacts/project-environment/index.html delete mode 100644 artifacts/project-environment/settings-comparison.png delete mode 100644 artifacts/project-environment/validation.json diff --git a/.gitignore b/.gitignore index 691f3db59..5c5f64566 100644 --- a/.gitignore +++ b/.gitignore @@ -65,3 +65,6 @@ pnpm-debug.log* .react-router .wrangler next-env.d.ts + +# Local review screenshots and generated previews (not product assets) +/artifacts/ diff --git a/apps/dashboard/src/app/(dashboard)/projects/[id]/components/BuildSettings.tsx b/apps/dashboard/src/app/(dashboard)/projects/[id]/components/BuildSettings.tsx index 5cd3d24ee..f3014f53a 100644 --- a/apps/dashboard/src/app/(dashboard)/projects/[id]/components/BuildSettings.tsx +++ b/apps/dashboard/src/app/(dashboard)/projects/[id]/components/BuildSettings.tsx @@ -1,29 +1,16 @@ +"use client"; + import { Icon as UiIcon, type IconName } from "@repo/ui/icons"; import React, { useState } from "react"; -import { useRouter } from "next/navigation"; -import { getRuntimeVersionPolicy, isServicesFramework, normalizeRepoPath } from "@repo/core"; -import { useProjectSettings } from "@/context/ProjectSettingsContext"; -import { workloadOf } from "@/context/deployment/types"; -import { useI18n } from "@/components/i18n-provider"; -import { encodeLocalSlug, encodeRepoSlug } from "@/utils/repoSlug"; -import { EnvVarsEditor } from "./EnvVarsEditor"; -import { StorageSettings } from "./StorageSettings"; -import { BuildCacheMigration } from "@/components/project-settings/DeploymentAutomation"; -import { ResourceSettings } from "./ResourceSettings"; -import { CommandEnvironmentNotice } from "@/components/import-project/CommandEnvironmentNotice"; -import { RuntimeSourceUpdate } from "@/components/updates/RuntimeSourceUpdate"; import Link from "next/link"; +import { isServicesFramework } from "@repo/core"; +import { useProjectSettings } from "@/context/ProjectSettingsContext"; +import { useI18n } from "@/components/i18n-provider"; +import { BuildCacheMigration } from "@/components/project-settings/DeploymentAutomation"; +import { RuntimeSourceUpdate } from "@/components/updates/RuntimeSourceUpdate"; import { projectApplication } from "@/lib/project-application"; - -/** - * Configuration cards within project Settings. Build settings link to the deploy wizard; project - * environment, resources and storage use their existing focused editors. - * Shared project environment remains available for every workload type. - * - * Visual shell (SectionCard + ICON_TONES) mirrors the sibling settings tabs - * (GitSettings / BackupSettings / DomainSettings) so the tab fills the same - * column width and reads as part of the same design system. - */ +import { EnvVarsEditor } from "./EnvVarsEditor"; +import { ResourceSettings } from "./ResourceSettings"; const ICON_TONES = { primary: "bg-primary/10 text-primary", @@ -71,84 +58,29 @@ function SectionCard({ ); } -function Row({ label, value, mono }: { label: string; value?: React.ReactNode; mono?: boolean }) { - const empty = value === undefined || value === null || value === ""; - return ( -
{bs.deployConfig}
+{surface === "settings" ? t.projectSettings.build.runtime.title : bs.deployConfig}
- {config?.framework + {surface === "settings" ? t.projectSettings.build.runtime.description : config?.framework ? interpolate(bs.defaultsApplied, { framework: config.framework }) : bs.configureOptions}
diff --git a/apps/dashboard/src/components/project-settings/ApplicationSettingsForm.tsx b/apps/dashboard/src/components/project-settings/ApplicationSettingsForm.tsx new file mode 100644 index 000000000..7114c979d --- /dev/null +++ b/apps/dashboard/src/components/project-settings/ApplicationSettingsForm.tsx @@ -0,0 +1,233 @@ +"use client"; + +import { useEffect, useMemo, useRef, useState } from "react"; +import Link from "next/link"; +import { Icon } from "@repo/ui/icons"; +import { normalizeRepoPath, resolveWorkload } from "@repo/core"; +import { RuntimeSourceUpdate } from "@/components/updates/RuntimeSourceUpdate"; +import BuildSettingsFields from "@/components/import-project/BuildSettings"; +import { CommandEnvironmentNotice } from "@/components/import-project/CommandEnvironmentNotice"; +import { Button } from "@/components/ui/button"; +import { useI18n } from "@/components/i18n-provider"; +import { useProjectSettings } from "@/context/ProjectSettingsContext"; +import { useToast } from "@/context/ToastContext"; +import { projectsApi, type ProjectOptionsBody } from "@/lib/api/projects"; +import { getApiErrorMessage } from "@/lib/api/client"; +import { invalidateProjectCaches } from "@/hooks/useProjectEndpoints"; + +type Config = ReturnType+ {copy.projectSettingsHint}{" "} + + {t.projects.sidebar.tabs.settings} + +
+