Check the font build in ImGui_ImplWin32_NewFrame #3487

Closed
opened 2020-09-23 09:46:19 +00:00 by actboy168 · 1 comment
actboy168 commented 2020-09-23 09:46:19 +00:00 (Migrated from github.com)

ImGui_ImplWin32_NewFrame will check if the font is built. If the Renderer releases the resource (ClearTexData) after creating the font resource, this check will fail. But it has no effect. Does this mean that this check is wrong?

ImGui_ImplWin32_NewFrame will check if the font is built. If the Renderer releases the resource (ClearTexData) after creating the font resource, this check will fail. But it has no effect. Does this mean that this check is wrong?
ocornut commented 2021-06-29 16:18:51 +00:00 (Migrated from github.com)

Hello @actboy168,
Sorry for my very late answer to this.
You are very right, the assert was incorrectly formulated, preventing the use of ClearTexData().
I fixed it now.
We don't expect ClearTexData() to be used by many people but still.
Note that work on #3761 when enabled will probably require user to keep CPU copy in memory.

We'll keep allow manual warming / baking of ranges + discarding of CPU/RAM data, can be useful for low-specs platforms.

Hello @actboy168, Sorry for my very late answer to this. You are very right, the assert was incorrectly formulated, preventing the use of `ClearTexData()`. I fixed it now. We don't expect `ClearTexData()` to be used by many people but still. Note that work on #3761 when enabled will probably require user to keep CPU copy in memory. We'll keep allow manual warming / baking of ranges + discarding of CPU/RAM data, can be useful for low-specs platforms.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ocornut/imgui#3487
No description provided.