compiler warnings with -pedantic and -Wextra on gcc #626

Closed
opened 2016-05-03 11:49:09 +00:00 by freanux · 5 comments
freanux commented 2016-05-03 11:49:09 +00:00 (Migrated from github.com)

Firstly, thanks for this very useful library. Please compile your library with following flags:
-Wall -pedantic -Wextra

You will see that the function ShowMetricsWindow needs to be fixed or the warning should be muted with:
#pragma GCC diagnostic ignored "-Wformat"

Firstly, thanks for this very useful library. Please compile your library with following flags: `-Wall -pedantic -Wextra` You will see that the function ShowMetricsWindow needs to be fixed or the warning should be muted with: `#pragma GCC diagnostic ignored "-Wformat"`
ocornut commented 2016-05-03 11:55:42 +00:00 (Migrated from github.com)

Please report the actual warnings first to see if they are better fixed or ignored.

Travis is running Makefile with -Wall https://travis-ci.org/ocornut/imgui
I suppose I could increase the warning level of those Makefile but in my experience it creates more daily maintenance than not, considering I'm not running GCC here.

Please report the actual warnings first to see if they are better fixed or ignored. Travis is running Makefile with `-Wall` https://travis-ci.org/ocornut/imgui I suppose I could increase the warning level of those Makefile but in my experience it creates more daily maintenance than not, considering I'm not running GCC here.
freanux commented 2016-05-03 11:57:38 +00:00 (Migrated from github.com)
have a look here: https://gist.github.com/freanux/6d2fdb85bedce2cdc27fe60bdb67d133
ocornut commented 2016-05-03 12:05:48 +00:00 (Migrated from github.com)

Thanks. PS use triple backword apostrophe to quote a block of code.

Thanks. PS use triple backword apostrophe to quote a block of code.
freanux commented 2016-05-03 12:25:52 +00:00 (Migrated from github.com)

Okay. Thanks.

Okay. Thanks.
ocornut commented 2016-05-04 21:28:23 +00:00 (Migrated from github.com)

Should be all fixed now.

Should be all fixed now.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ocornut/imgui#626
No description provided.