solidity-lean/SolidCore/Witness/DeleteMemoryNestedRef.lean
Dan Robinson 2c74c40644 Fix #168 DELETE-MEMORY-NESTED-REF: runtime-aware memory delete zeroing
`delete` on a MEMORY struct/array zeroed via `Value.defaultLike`, which has no
`Runtime` and returned the SAME inner `memoryRef`. A struct's dynamic-array
member therefore stayed pointing at the old, non-empty array: `delete s` on
`S { uint x; uint[] arr }` gave `(s.x, s.arr.length) = (0, 3)` instead of solc's
`(0, 0)` (wrong value, replay-reachable).

solc's memory `delete` allocates a brand-new, fully-zeroed object graph at the
free-memory pointer, so nested references become FRESH empty/zeroed cells, never
aliases of the old ones. Replace `defaultLike` in the three memory delete paths
(local memoryRef, memoryCell, valueIndex) with `Runtime.deleteZeroValue`, a
runtime-aware recursion over the value graph: dynamic array -> fresh empty,
fixed array -> same length each element zeroed, struct (tuple) -> each field
zeroed, value fields -> zero word, and every inner `memoryRef` dereferenced,
zeroed, and re-allocated as a NEW cell. Storage and value-type `delete` paths
are unchanged.

Isolation ladder (pinned solc 0.8.35 legacy + real EVM, all matched):
  f          (delete S, read x/arr.length) => (0, 0)
  freshAfter (fresh new uint[](2) after delete) => (2, 5)
  g          (delete uint[][2] memory)      => (0, 0)
  nested     (delete Outer{S inner; uint[] tail}) => (0, 0, 0)
  aliasCase  (b = s.arr; delete s;) b keeps OLD array, s.arr fresh => (3, 42, 0)
  valueStruct/topArray/scalarLocal (unchanged) => (0,0)/0/0

Witness SolidCore/Witness/DeleteMemoryNestedRef.lean (9 #guards) + Forge lane
tests/forge-harness/delete-memory-nested-ref (8 real-EVM tests) + manifest case.
Full `lake build` green (1124 jobs).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
(cherry picked from commit 5683db1da0fdb6ed6614c8bec3dd4ff7c1fbef02)
(cherry picked from commit 683dfe3f75cac1627fd6be3d6ea2fee376bddbd0)
2026-07-11 08:41:24 -07:00

225 lines
15 KiB