mirror of
https://github.com/s2-streamstore/s2.git
synced 2026-09-27 18:19:36 +00:00
Follow-up to #766. Exposes the `s2 lite` storage flags the chart was missing, and folds the README feedback from that review into a combined storage section. **Chart.** The main store is now `objectStorage` (`--bucket`) or `persistentVolume` (`--local-root` on a PVC), and the WAL is `walStorage.bucket` (`--wal-bucket`) or `walStorage.persistentVolume` (`--wal-local-root` on a PVC). The two volume blocks share one shape (`enabled`, `mountPath`, `size`, `storageClass`, `existingClaim`) and one `pvc.yaml` template; claims are named `<fullname>-data` and `<fullname>-wal` and default to `/data` and `/wal`. `walStorage.endpoint`/`region` map to `S2LITE_WAL_AWS_ENDPOINT_URL_S3`/`S2LITE_WAL_AWS_REGION`; separate credentials go through `env`, as for the main store. Templates fail on `objectStorage` + `persistentVolume` both enabled, on `walStorage` without a persistent main store, and on both WAL modes at once. `NOTES.txt` reports the storage and WAL locations. The deployment already uses `strategy: Recreate`, so `ReadWriteOnce` claims do not block upgrades. **README.** Replaces the "Separate WAL storage" section with a "Storage" section presenting main-store and WAL settings side by side in one table (bucket/directory, endpoint, region, credentials, session token). The chart README links there instead of repeating it. Both READMEs and `values.yaml` note that the WAL location must stay the same across restarts, since changing it does not migrate data and the server does not error. **Merge after the next lite release.** `walStorage` passes `--wal-bucket`/`--wal-local-root`, which the current default image (`appVersion` 0.42.12) does not have; #766 ships in the next release. Wait for its `appVersion` bump commit on `main` before merging. `persistentVolume` alone works on 0.42.12. Chart-created PVCs are deleted by `helm uninstall`; both volume blocks expose `annotations` for `helm.sh/resource-policy: keep`, documented in the chart README. Chart `version` is not bumped; the `Bump Chart Version` workflow handles that before release. --------- Co-authored-by: Cursor <cursoragent@cursor.com> |
History
|
|
|---|---|---|
| .. | ||
| actions/rust-dependency-cooldown | ||
| workflows | ||