0
Fork 0
mirror of https://github.com/zeronsh/comet.git synced 2026-11-16 18:57:19 +00:00

Plugins: a host named exactly asks, whatever it reads as (the rebind hole)

A plugin allowed any public host could update to name `rebind.example.com`,
pointed at 127.0.0.1. Nothing asked (it read as public) and the window didn't
flag it, yet a named host reaches a private address it resolves to. `127.1` and
`0x7f.1` went the same way through the app's transport.

- `net::risky`: a name ending in a number reads as local, so it's flagged and
  asks.
- `capability::diff` (crates/engine): over an any-public grant, a newly named
  exact host asks. `*.` names still don't: they never reach a private address.
  This reverses "narrowing to named hosts doesn't ask" for exact names.
- The permission window, under exact names that don't read as local: "A named
  host can be on this computer or your network." en and zh-Hans.

Names like `.ts.net` and split DNS keep working once named and allowed, with no
manifest change. A plugin allowed as it is isn't asked again. Nothing here
works out where a name points: DNS can change after consent, so the person's
yes is what allows it, and the new line is what makes that yes honest.

Engine change: ships in a stable release before a beta.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
This commit is contained in:
Wing 2026-11-03 22:37:12 -07:00
commit 8e582ffc6e
9 changed files with 123 additions and 10 deletions