0
Fork 0
mirror of https://github.com/zeronsh/comet.git synced 2026-11-16 18:57:19 +00:00

Release engines run Luau without its asserts, and each package checks it

The engine links Luau (mlua's luau0-src: visuals, plugin services) and
was built from the root, where nothing sets LUAU_CXXFLAGS: its Luau kept
its asserts, about a fifth of script time. LUAU_CXXFLAGS=-DNDEBUG now
goes on the builds of a release's engine, not a root .cargo/config.toml,
so test and development builds keep them:

- zgx-beta.yml: each job's "the engine, from this commit" step (macOS,
  Linux, Windows' whole zeron.exe).
- release.yml's engines, which the packaging scripts build themselves:
  package-linux.sh's release build, package-macos.sh, package-windows.ps1
  without -BetaVersion (so a local package is right too).

Each package refuses an engine with them. The engine has no zgx-script,
so not the app's warning; instead what LUAU_ASSERT keeps when asserts
are on (Luau/Common.h: #expr, __FILE__): each Luau source file's path,
VM/src/l*.cpp, either separator. The workflow's engine build, exactly,
here: 36 such paths without the flag, none with it (no luau0-src path at
all); the check fails the first and passes the second. A debug package
(package-linux.sh PROFILE=debug) is left alone: luau0-src turns asserts
on in any debug build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
This commit is contained in:
Wing 2026-11-11 11:15:12 -07:00
commit d1bf8d327d
5 changed files with 47 additions and 3 deletions