0
Fork 0
mirror of https://github.com/zeronsh/comet.git synced 2026-11-16 18:57:19 +00:00
Commit graph

12 commits

Author SHA1 Message Date
fate
e5466c5336
Windows browser, image previews in tool calls, selectable tool output (#813)
* Embed the browser on Windows and preview images in tool calls

- Browser tabs render pages inside Zeron on Windows (WebView2), matching macOS and Linux.
- Expanded tool calls preview the images they touch and free them on collapse.
  Right-click any transcript image to copy its path or the image itself.
- Paths, commands and output in expanded tool calls can be selected and copied.
- Fix: answering an agent question with multiple lines now grows the card instead
  of spilling text below it.

* Address review: repin zui upstream, harden the Windows browser and previews

- Depend on zeronsh/zui dce5c1f (zui#15 merged) and gpui-component
  47ccd07 instead of patching every gpui crate to a personal fork.
- Tool image previews: refuse UNC/device/drive-relative paths in the UI
  and, before any filesystem call, lexically jail requested paths in the
  engine (canonicalizing \\host\share opened an SMB session and leaked
  the user's NTLM hash); read chunks on the blocking pool; bound decodes
  with the shared raster limits; release keys a chip stops showing;
  decode base64 off the UI thread; copy sanitized SVG; cap output lines.
- Windows browser: fail closed on unreadable navigation targets; police
  subframes and cancel external-scheme launches; open tabs only for
  user-initiated popups (handled first); deny permission requests;
  disable web messages and host objects; cancel downloads silently
  unless the page itself is the file; recover from a browser-process
  exit on Reload; give each BrowserData its own InPrivate profile (no
  persistent fallback); sweep only folders of exited processes; never
  remount from an older composition generation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Wing <contact@winglee.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 23:06:18 -07:00
Daniel Katulevskiy
e96eccb1aa
Keep activity loaders pulsing with system reduced motion (#754) 2026-10-02 22:46:24 -07:00
José Gurruchaga
df0cd2980a
Replace Pi ACP adapter with native RPC integration (#630)
* feat(pi): add native RPC transport and compatibility contracts

* feat(pi): implement native harness and event normalization

* feat(pi): resume native and legacy ACP sessions

* feat(pi): support native steering and reliable cancellation

* feat(pi): expose native models commands and skills

* feat(pi): bridge extension dialogs to desktop and mobile input

* feat(pi): preserve Zeron MCP delegation in native sessions

* feat(pi): activate native RPC driver and CLI discovery

* refactor(pi): retire ACP adapter and verify native lifecycle parity

* fix(pi): preserve switched sessions empty resumes and composer drafts

* docs(pi): translate RPC migration research into English

* style(ios): trim whitespace in updated question bindings

* test(acp): wait for scenario progress before steering

* test(pi): compare canonical session paths on Windows

* fix(pi): deliver steering bursts in the same model step

* fix(ios): preserve generated Swift binding whitespace

* fix(pi): scrub nested-agent env and keep dropped-resolver semantics

Pi's native launch skipped owned::configure, so CLAUDECODE and the other
nested-agent variables the ACP launch removed leaked into pi. The engine's
new input-cancellation task also turned a dropped resolver into an empty
answer; keep it an error for harnesses (opencode rejects on error).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: run the native Pi RPC driver tests

pi_rpc needs the native-fixture feature and pi_resume is an engine test;
neither ran in any workflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(pi): never overwrite a configured Pi steering mode

set_steering_mode persists to Pi's global settings.json. Selecting `all` on
every session start silently rewrote the user's standalone Pi preference and
undid any `/steering` choice on the next run. Select `all` only while neither
the global nor the project settings configure a mode.

PiHarness::with_agent_dir lets tests (and callers) pin PI_CODING_AGENT_DIR for
both the child and Zeron's own reads, so fixture tests never consult the
developer's real Pi settings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ios): don't trap on duplicate question ids when prefilling answers

Dictionary(uniqueKeysWithValues:) crashes on a repeated key; question ids come
from agents and synced docs, so keep the first instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* style(pi): rustfmt the steering-mode guard and its tests

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(pi): start fresh with a notice when a session can't be restored

The native driver hard-failed a resume whose Pi session file was missing.
The engine injects the chat's stored session id on every dispatch, so one
unwritten or deleted session file left the chat failing every message for
good. The ACP adapter and the Codex driver start a new session and announce
the lost context instead; do the same. Proven-empty sessions still keep
their UUID via --session-id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(pi): never fail a turn over an attachment Pi can't inline

Composer uploads include SVG, HEIC, BMP, TIFF and AVIF. The native driver
errored the whole run on any of those (or an unreadable path), while the
Claude driver skips them and the retired adapter ignored attachments: the
path refs already ride the prompt text. Load images best-effort instead.

Also give native startup the 120s budget the ACP handshake gave Pi, since
extensions can start cold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* style(pi): rustfmt the lost-session live test

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Wing <contact@winglee.io>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-29 17:14:54 -07:00
Wing
109b39f301
Durable desktop updates: Check for Updates, background download, install on quit, Windows installer (#595)
Update detection was late and fragile: the only checker lived in the engine
on a 6h monotonic timer (a laptop's sleep stretched it by the whole night),
the sidebar compared the release against whichever engine the UI attached to
(a daemon of another version hid or faked updates), nothing downloaded until
clicked, and several install paths could not update at all.

- zeron-update: hourly wall-clock schedule with failure backoff (1m→30m),
  re-read on window activation; desktop (report-only) checker role; staged
  payloads are unpacked beside their final name and must answer
  `--version` with the promised release before they can replace anything;
  up-front blockers (App Translocation, disk image, unwritable install dir)
  instead of a failed download; Linux managed installs update from the app;
  a service daemon restarts into a newer installed binary once idle.
- UI: app-level controller with its own checker against this binary; a found
  release downloads in the background, the strip offers restart, and a
  staged update installs on quit. "Check for Updates…" under About in the
  macOS app menu, "Check for updates" in the account menu elsewhere, with a
  live result dialog.
- Linux: the tarball's install.sh uses the self-updating ~/.zeron/app layout.
- Windows: per-user Inno Setup installer (LocalAppData, Start menu, zeron://,
  uninstall entry kept current after in-app updates), built in release and
  CI, with a silent install/uninstall smoke test.
- Fix: closing the window on X11 panicked in the geometry save, skipping the
  engine drain and any quit hooks.

Co-authored-by: wing-anara <wing@anara.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-27 17:46:55 -07:00
Ani Betts
aff9a4983c
Allow Windows builds for ARM64 (#545)
* Name Windows packages by host architecture so ARM64 updates resolve.

package-windows.ps1 always wrote windows-x86_64 artifacts, but the updater looks up zeron-<ver>-windows-<ARCH>.exe using Rust's architecture token. Native ARM64 builds now ship as windows-aarch64.

* Document Clang as a Windows ARM64 build requirement.

ring 0.17 has no MSVC assembly path for aarch64-pc-windows-msvc, so native ARM64 builds need LLVM clang on PATH.

* Name Windows packages by the built executable's architecture.

The PowerShell process architecture can disagree with the binary rustc
produced: x64 pwsh under ARM64 emulation reports X64 while a native
aarch64 toolchain builds an ARM64 zeron.exe (and vice versa), which would
publish an artifact the updater never looks up. Read the PE machine type
of target/release/zeron.exe instead. Also note that published releases
are still x64 only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: wing-anara <wing@anara.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-25 00:27:40 -07:00
wing-anara
68ed902ed5 Fail closed on unresolved Windows shells and exercise login and startup in CI 2026-09-15 20:11:09 +00:00
hoangvu12
6f5a40a206 Resolve and launch npm .cmd shims through cmd.exe
Both the resolver and the spawner were hard-coded to .exe, so
npm-installed agents were undiscoverable and unlaunchable: npm leaves
only a `name.cmd` shim on PATH with the real binary buried under
node_modules. Discovery is now PATHEXT-aware — per directory,
extensions in PATHEXT order, limited to what we can launch (.com,
.exe, .bat, .cmd) — and overrides accept batch shims that exist on
disk, so availability and launches agree.

Resolved .cmd/.bat scripts spawn through `cmd.exe /d /s /c` with
cross-spawn-style per-argument escaping: the shim is the only
interpreted layer, agent arguments stay literal (spaces, backslashes,
quotes, unicode, cmd metacharacters round-trip verbatim — proven by
re-invoking a real program through a shim fixture), and Job Object
ownership covers the whole tree through cmd.exe's membership. The
codex node_modules vendor special-case is deleted: it searched the
wrong vendor subdirectory (`bin/` instead of `codex/`), and its
fixture encoded that wrong layout, so CI passed while real npm
installs failed. GUI launches additionally backfill %APPDATA%\npm,
%LOCALAPPDATA%\{pnpm,Programs\nodejs}, scoop shims, and
%USERPROFILE%\{.local\bin,.bun\bin} from PATH.

opencode and cursor resolution migrate off raw $HOME to the shared
USERPROFILE-aware home helper; cursor also probes
%LOCALAPPDATA%\cursor-agent. The engine catalog and login tests use
the real npm shim layout, batch-override harness tests assert safe
launch instead of rejection, and the shell-script fixture suites are
gated to Unix where they actually run.
2026-09-11 16:49:14 +07:00
hoangvu12
eccabbb7fa Publish Windows packages with the cross-platform release 2026-09-11 08:24:43 +07:00
hoangvu12
076fd87d8f Keep Windows CI and development notes focused
Remove unrelated workflow reorganization, retain shared Rust coverage, and shorten the Windows setup guide.
2026-09-11 05:51:11 +07:00
hoangvu12
4841084829 Keep Windows PR focused on implementation and development guide 2026-09-11 03:50:30 +07:00
hoangvu12
8a659d7cb8 Run renamed upstream Windows layout tests 2026-09-11 03:32:33 +07:00
hoangvu12
e2dd4dcf14 Add native Windows source-build support 2026-09-11 03:31:00 +07:00