0
Fork 0
mirror of https://github.com/zeronsh/comet.git synced 2026-11-16 18:57:19 +00:00
Commit graph

2 commits

Author SHA1 Message Date
Alexandre V.L
ea3dcc8115
Pull request links: honor Default browser and Open links in Zeron, add In-app browser (#1026)
* Pull request links: honor Default browser and Open links in Zeron, add In-app browser

Settings → General → Links → Open pull requests in now offers Pull request
view, In-app browser and Default browser, and covers links in messages as
well as badges and the board.

- Default browser sends a pull request link in a message to the system
  browser. It used to open a Browser tab in Zeron.
- With Open links in Zeron off, a pull request link leaves Zeron like any
  other link. It used to open the pull request view.
- In-app browser opens a Browser tab beside the conversation, from links,
  sidebar badges and board rows.
- An outside press only hides a link's destination card: the message's
  links keep their ids, so the next link opens on its first press.
- Unknown destinations read back as the default. v0.2.120 and older reject
  "browser" and reset every UI setting.
- pull-request-destination-fixture captures each path natively; captures
  from main and this branch are in docs/screenshots/pull-request-destination.

* Linux unit tests start no WebKitGTK helper for a Browser tab

ui-tests failed on transcript_pull_request_links_open_where_settings_send_them:
its Browser tab's browser-startup thread could not reach a display and woke
the test scheduler from outside it ("Your test is not deterministic").

Under cfg(test), NativePage::start now fails at once unless the test brings
its own helper, as page creation already fails synchronously on macOS. Tests
no longer extract and spawn the real helper either.

* Settings: keep pullRequestDestination readable by older builds

Every build shares ui-settings.json, and builds up to v0.2.122 derive
PullRequestDestination: an unknown "browser" fails the whole file, so
they fall back to defaults and the next save overwrites every UI
setting. Store the full pick under pullRequestOpenIn and keep writing
pullRequestDestination with the names those builds know (an in-app
browser pick reads there as the pull request view). Load prefers the
new key and falls back to the legacy one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>

---------

Co-authored-by: Wing <44917547+wingleeio@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
2026-10-25 01:55:28 +00:00
José Gurruchaga
a9de0352a9
Open transcript web links in Browser with destination tooltips and truncation (#355)
* refactor(ui): model transcript link targets and activation

* feat(ui): open transcript web links in session browser tabs

* feat(ui): add transcript link actions and keyboard access

* feat(ui): show full web destinations on hover and focus

* feat(ui): truncate long transcript links without losing content

* test(ui): cover transcript browser links end to end

Add native transcript link fixtures, preserve focus when action menus mount, and document interaction, Linux runtime requirements, and platform validation limits.

Fixes #351

* feat(ui): open Markdown preview links in session browser tabs

* fix(ui): make link destination tooltips compact

* fix(ui): suppress link tooltips while context menus are open

* feat(ui): add default link destination toggle

* fix(ui): use shared context menu rows for links
2026-09-14 00:43:01 -07:00