0
Fork 0
mirror of https://github.com/zeronsh/comet.git synced 2026-11-16 18:57:19 +00:00
comet/docs/screenshots/command-palette
José Gurruchaga 3487b507fa
Unified workspace search on fff, content search, and a tabbed cmd+K palette (#856)
* build: add fff-search

* test(engine): add a workspace search benchmark

* feat(engine): add WorkspaceSearch on top of fff

* feat(engine): serve SearchFiles (@) from fff

* feat(engine): serve SearchWorkspaceFiles (file tree) from fff

* chore: drop nucleo-matcher

* feat(rpc): add WarmWorkspaceSearch

* test(ui): add the missing images field to a ToolItem fixture

* feat(ui): warm workspace search on chat focus

* feat(rpc): add SearchWorkspaceContent

* feat(ui): scored thread search for the command palette

* refactor(ui): split the command palette into sections and tabs

* feat(ui): command palette tabs with mod-1…4

* feat(ui): empty-state sections in the command palette

* feat(ui): ranked thread search in the command palette

* feat(ui): search file names from the command palette

* feat(ui): search file contents from the command palette

* perf(engine): return an evicted index's memory to the allocator

* perf(engine): cap each search index's content cache at 16 MB

* docs: workspace search on fff

* feat(rpc): add SearchHomeFolders

* feat(ui): search folders under home when adding a project

* perf(engine): index workspace paths only, grep contents without a bigram index

* perf(engine): keep idle search indexes 15 min, up to 7, warmed once on focus

* fix(ui): refresh palette content search while indexing

* fix(engine): preserve literal workspace content queries

* fix(ui): refresh palette file search while indexing

* fix(ui): refresh home folder search while indexing

* fix: handle extended Windows and UNC paths in home folder picker

* fix(ui): convert content search byte columns for editor navigation

* fix(engine): normalize Windows separators in name searches

* fix(ui): back off palette content refreshes while indexing

* perf(ui): skip the palette's index probe once the workspace is ready

* fix(ui): match Windows folder paths regardless of drive letter case

* docs(ui): describe the home index release without pins

* Workspace search: review fixes and palette polish

Engine
- Drop content matches reached through a symlink, and name results
  through a symlinked folder (ReadWorkspaceFile's rule); fff's watcher
  follows links created after the first scan.
- @ and file-tree name searches wait up to 2 s for a fresh index, since
  their answers can't report that it is still building.
- Evict the LRU index only after its replacement is created, and report
  "indexing" (not a final empty answer) when an index is released mid-search.
- File-name search accepts an empty query (not with "show ignored"),
  listing the workspace's files by the index's recency.
- Home folder results are spelled from the session's home, not its
  canonical path, so a symlinked home doesn't duplicate projects.

Palette
- The Files tab and All's Recent Files list opened files, then the
  workspace's recency list, when there is no query.
- Arrowing onto a section's first row scrolls its header into view.
- Tabs use the shared tab chip; shortcut legends are plain sidebar-style
  text set in the system font (the UI font lacks ⇧ ↵); footer keys keep
  their caps, with icon glyphs for arrows and return.
- Leaving for the PR board releases the new-project home index.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Wing <44917547+wingleeio@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
History 2026-10-10 15:11:35 -07:00
..
action-search.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
actions-and-history.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
history-search.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
hover-isolation.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
light-search.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
light.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
README.md Unified workspace search on fff, content search, and a tabbed cmd+K palette (#856) 2026-10-10 15:11:35 -07:00
settings-menu.png Add Cmd+K palette for actions and chat history (#399) 2026-09-15 23:37:53 -07:00
tabs-commands-no-results.png Unified workspace search on fff, content search, and a tabbed cmd+K palette (#856) 2026-10-10 15:11:35 -07:00
tabs-empty-state.png Unified workspace search on fff, content search, and a tabbed cmd+K palette (#856) 2026-10-10 15:11:35 -07:00
tabs-thread-search.png Unified workspace search on fff, content search, and a tabbed cmd+K palette (#856) 2026-10-10 15:11:35 -07:00

These screenshots show the real GPUI shell with isolated sample chats from crates/ui/examples/command-palette-fixture.rs. The fixture uses temporary storage and does not start an engine or connect to an account, so it shows no Files or In Files results.

Run cargo run -p zeron-ui --example command-palette-fixture on a desktop, then press Cmd+K (Ctrl+K on Linux/Windows). Set ZERON_PALETTE_LIGHT=1 for light mode.

Tabs and sections

The palette searches threads, commands and the focused chat's workspace. Tabs under the search field narrow it: All, Threads, Commands and Files. Cmd+1…4 (Ctrl+1…4) select them while the palette is open — the bindings live in the palette's CommandPalette key context, where they outrank the same keys' session jumps; with the palette closed those keys jump to sessions as before. Tab and Shift+Tab cycle the tabs. The palette always opens on All.

With an empty query, All shows:

  1. Recent Files — up to five files the focused chat opened in editor tabs, newest first, with the parent folder in muted text.
  2. Quick Actions — New chat, New project, Open settings, the theme switch and, with a focused unarchived chat, Archive thread, each with its shortcut.
  3. Recent Threads — up to five other unarchived top-level threads by latest activity.

With a query, All shows Threads (five), Commands, Files (five) and In Files (five); empty sections are omitted. The Threads tab lists up to 50 threads, the Files tab up to 50 file names and 100 content matches (three per file).

  • Threads are ranked in the UI (crates/ui/src/shell/thread_search.rs): every query word must match the title (weight 100), project (40), branch (30), device or pull request (20); a match starting a word earns half its weight again; archived threads score half; ties go to recent activity. Side chats and subagent workers never appear.
  • Files and In Files query the focused chat's host (SearchWorkspaceFiles at once, SearchWorkspaceContent after an 80 ms pause) once the query has two characters. Their headers read "Searching…" while a request runs and "Indexing…" while the host is still building its index; a host too old for content search says so in the In Files header.
  • Answers to superseded queries are dropped, and the highlighted row is kept by identity, so results arriving never move the selection.
  • Enter opens the row: a thread, a command (the theme switch keeps the palette open), a file in an editor tab, a folder revealed in the files tree, or a content match at its line.

Footer hints: ↑ ↓ Navigate, ↵ Open, Cmd/Ctrl+1…4 Tabs, Esc Close.

tabs-empty-state.png, tabs-thread-search.png and tabs-commands-no-results.png show the redesign (captured under Xvfb, so without the backdrop blur). The other images predate the tabs.

Earlier verification

Verified interactively on Linux/X11 before the tabs:

  • First-open typing searches the palette, leaving the composer untouched.
  • Matching text keeps a compact rounded code wash and code text color while preserving the row font and original text spacing. This applies to action labels and chat metadata.
  • Palette chat hover leaves the sidebar pixels unchanged (including Archive state).
  • Chat rows use the sidebar height calculation and 2px gap; action rows are 32px.
  • Up/Down wraps and scrolls the selected result into view; Enter opens it.
  • New chat, New project, and Open settings reach their respective screens.
  • Escape, a second Ctrl+K, and clicking outside dismiss the palette.
  • No matches produces the empty state.

The palette uses the composer's frosted tint and 16px backdrop blur, with its opaque fallback when frost is disabled. The platform-specific Cmd key binding has not been exercised on macOS in this Linux environment.