* Pull request links: honor Default browser and Open links in Zeron, add In-app browser
Settings → General → Links → Open pull requests in now offers Pull request
view, In-app browser and Default browser, and covers links in messages as
well as badges and the board.
- Default browser sends a pull request link in a message to the system
browser. It used to open a Browser tab in Zeron.
- With Open links in Zeron off, a pull request link leaves Zeron like any
other link. It used to open the pull request view.
- In-app browser opens a Browser tab beside the conversation, from links,
sidebar badges and board rows.
- An outside press only hides a link's destination card: the message's
links keep their ids, so the next link opens on its first press.
- Unknown destinations read back as the default. v0.2.120 and older reject
"browser" and reset every UI setting.
- pull-request-destination-fixture captures each path natively; captures
from main and this branch are in docs/screenshots/pull-request-destination.
* Linux unit tests start no WebKitGTK helper for a Browser tab
ui-tests failed on transcript_pull_request_links_open_where_settings_send_them:
its Browser tab's browser-startup thread could not reach a display and woke
the test scheduler from outside it ("Your test is not deterministic").
Under cfg(test), NativePage::start now fails at once unless the test brings
its own helper, as page creation already fails synchronously on macOS. Tests
no longer extract and spawn the real helper either.
* Settings: keep pullRequestDestination readable by older builds
Every build shares ui-settings.json, and builds up to v0.2.122 derive
PullRequestDestination: an unknown "browser" fails the whole file, so
they fall back to defaults and the next save overwrites every UI
setting. Store the full pick under pullRequestOpenIn and keep writing
pullRequestDestination with the names those builds know (an in-app
browser pick reads there as the pull request view). Load prefers the
new key and falls back to the legacy one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
---------
Co-authored-by: Wing <44917547+wingleeio@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: zeronsh[bot] <346184242+zeronsh[bot]@users.noreply.github.com>
|
History
|
|
|---|---|---|
| .. | ||
| after-default-browser.png | ||
| after-in-app-browser.png | ||
| after-links-off.png | ||
| after-next-link.png | ||
| after-settings-menu.png | ||
| before-default-browser.png | ||
| before-links-off.png | ||
| before-next-link.png | ||
| before-settings-menu.png | ||
| README.md | ||
Pull request destination captures
Captured on macOS on 2026-10-24 by the opt-in pull-request-destination-fixture example: the production Shell in an offscreen window that is never activated, a real engine and IPC server on temporary data, the local gh, and native mouse events on a message's links. The session and its message are synthetic; the links point at real zeronsh/zeron pull requests. A link that leaves Zeron opens in the default browser for real.
before-*.png:mainat1ec71a31(v0.2.120), with this fixture copied in.after-*.png: this branch.
Captures read the window back with render_to_image, which leaves out WebKit's page: a Browser tab shows its tabs and address bar over an empty page. Each frame follows a press on empty space, which dismisses link tooltips.
| Check | main |
This branch |
|---|---|---|
default-browser: Default browser, click #1005 |
FAIL: Browser tab on #1005 | PASS: nothing opens in Zeron |
links-off: Open links in Zeron off, click #1012 |
FAIL: pull request view on #1012 | PASS: nothing opens in Zeron |
next-link: click #997 with links off, then #1019 once with links on |
FAIL: the press does nothing | PASS: Browser tab on #1019 |
in-app-browser: In-app browser, click #1020 |
no such option | PASS: Browser tab on #1020 |
pull-request-view: Pull request view, click #1013 |
PASS | PASS |
"Nothing opens in Zeron": no Browser tab, and the frame is identical to the one before the press.
Regenerate:
cargo build -p zeron-ui --example pull-request-destination-fixture \
--features pull-request-fixture,browser-fixture
bash scripts/run-macos-browser-fixture.sh \
target/debug/examples/pull-request-destination-fixture /tmp/pull-request-destination
The run writes result.txt and exits non-zero when a check fails. These files document the PR and are not bundled into the app.