mirror of
https://github.com/Continuum-AI-Corp/Orca-Code-Review.git
synced 2026-09-27 09:29:03 +00:00
a49ffb5981Both flags survived the cascade that gave them meaning. --held marked a cheap pass withholding a strong review, and --fix-first let the blocking count follow the fix-first set on such a run, because block-on need not contain those severities. There is no withholding and no tier line any more, so the count has followed block-on alone for some time — while the two flags went on being parsed, and --fix-first went on being validated, with neither value read by anything downstream. fix-first REMAINS an action input. It stops the exhaustive loop early (action.yml), which is a different question from what the summary counts; the header now says so, so the name cannot argue its way back into this count later. Removing a flag the script no longer understands is safe to ship on its own: the argument loop has no else branch, so an unrecognised flag and the value after it are skipped one token at a time without shifting the flags that follow. The surviving block-on test now passes --fix-first in the MIDDLE of the argv to hold that property down. Also scopes the action-inputs reference to this action: the hosted App runs a different review engine, so fix-first and exhaustive can behave differently there, and the file now says to answer App questions from the console instead. Test suite is unchanged by this: 558 pass / 9 fail before and after, the failures being a pre-existing CRLF mismatch in the action.yml input tests on a Windows checkout. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> |
History
|
|
|---|---|---|
| .. | ||
| check-result.mjs | ||
| check-result.test.mjs | ||
| control-plane.mjs | ||
| control-plane.test.mjs | ||
| conventions-directive.test.mjs | ||
| diff-guard.mjs | ||
| diff-guard.test.mjs | ||
| exhaustive-merge.mjs | ||
| exhaustive-merge.test.mjs | ||
| fact-proxy.mjs | ||
| fact-proxy.test.mjs | ||
| gate.mjs | ||
| gate.test.mjs | ||
| harness.test.mjs | ||
| i18n.test.mjs | ||
| inject-summary.mjs | ||
| inject-summary.test.mjs | ||
| installer.test.mjs | ||
| judge.mjs | ||
| judge.test.mjs | ||
| localconfig.test.mjs | ||
| platforms.test.mjs | ||
| postfilter.mjs | ||
| postfilter.test.mjs | ||
| prompt.test.mjs | ||
| quiet-filter.mjs | ||
| recipe.test.mjs | ||
| report-filter.mjs | ||
| report-filter.test.mjs | ||
| report.mjs | ||
| report.test.mjs | ||
| selection.test.mjs | ||
| settings.mjs | ||
| settings.test.mjs | ||
| severity.mjs | ||
| severity.test.mjs | ||
| summary-comment.mjs | ||
| summary-comment.test.mjs | ||
| usage-summary.mjs | ||
| usage-summary.test.mjs | ||