Orca-Code-Review/scripts/fact-proxy.test.mjs
Zhenghua Bao 9b484d0fd9
fix: point the action at the router's current name (#29)
* fix: point the action at the router's current name

The `router` input defaulted to `orcarouter/code-review`. That router is
provisioned as `orcacode-review` — the old name is renamed on setup, and the
gateway addresses a router by its current name with no fallback at resolution
time, so the default named an alias that a provisioned workspace does not have.
The worker path already used the current name, so the two review paths pointed
at different aliases.

A workspace still holding the old name gets `model router 'code-review' not
found` once this ships, and the fix is to run setup, which renames it. That is
also what the console already tells them: the router card reads red for a
workspace on the pre-rename name, deliberately, because the relay cannot
address it.

Renamed the recipe file alongside it so the pasteable artifact matches the
router it is pasted into, and the header now says what to do when a review
fails with the not-found error.

The recipe's default model is now `deepseek/deepseek-v4-flash`, which is what
setup provisions — so this file and a freshly created router agree. It said
`openai/gpt-5.5` and called it validated, which meant the documented recipe and
the one we actually write disagreed on the one line that decides review cost
and quality. The note above it now says plainly that this is the line to edit
and that it is the highest-leverage change available in this file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs: the not-found error names the alias that was requested

The migration note had both upgrade states backwards. `resolveOrcaRouterModel`
formats the error from the REQUESTED name, so a workspace still on the old name
fails with `orcacode-review` not found, and a `code-review` not found means
something is still explicitly asking for the old alias — a `router:` override or
a recipe pasted into a router of that name. Setup fixes the first and cannot fix
the second, and the note pointed each at the other's remedy.

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-26 15:02:41 +08:00

1132 lines
44 KiB