0
Fork 0
mirror of https://github.com/TanStack/router.git synced 2026-11-16 19:38:07 +00:00
Commit graph

6,706 commits

Author SHA1 Message Date
Sarah Gerrard
454207874a fix(start): collect Rsbuild assets by route loading context
Collect JavaScript and CSS from route chunk groups instead of reconstructing global chunk imports. Preserve parent-path intersection and the Vite chunk-based manifest path.

Include entry-owned hydration styles so root-level deferred content is styled without loading its JavaScript. Cover shared loading groups and root hydration with compiler and production browser regressions.
2026-10-29 12:02:45 -07:00
Sarah Gerrard
8bb4af824e
Merge branch 'main' into fix/rsbuild-static-chunk-availability 2026-10-24 11:24:27 -07:00
github-actions[bot]
6b9fe6d295
ci: Version Packages (#8745) release-2026-10-22-2011 @tanstack/start-static-server-functions@1.167.44 @tanstack/start-storage-context@1.167.41 @tanstack/solid-start@1.169.4 @tanstack/solid-start-client@1.168.42 @tanstack/start-server-core@1.169.45 @tanstack/vue-start-server@1.167.50 @tanstack/solid-router@1.170.43 @tanstack/vue-start-client@1.167.45 @tanstack/start-client-core@1.170.39 @tanstack/start-plugin-core@1.171.55 @tanstack/solid-start-server@1.167.50 @tanstack/vue-router@1.170.42 @tanstack/vue-start@1.169.4 @tanstack/react-start@1.169.4 @tanstack/router-cli@1.167.46 @tanstack/react-start-server@1.167.52 @tanstack/react-start-rsc@0.1.65 @tanstack/react-start-client@1.168.44 @tanstack/router-core@1.171.39 @tanstack/router-generator@1.167.46 @tanstack/router-plugin@1.168.48 @tanstack/router-vite-plugin@1.167.48 @tanstack/react-router@1.170.46
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-22 22:05:39 +02:00
autofix-ci[bot]
3e09e471e9 ci: apply automated fixes 2026-10-21 12:23:29 -07:00
Sarah Gerrard
a4796ed5ce fix(start-plugin-core): resolve Rsbuild static chunk imports in their own loading context 2026-10-21 12:23:29 -07:00
Sarah Gerrard
ce696ad6c7 fix(start-plugin-core): intersect Rsbuild static chunk availability across loading paths
A shared chunk recorded static imports to every chunk in the union of its groups and their ancestors, so it pointed at each sibling route's copy of a duplicated module. Compute availability per chunk group as its own chunks plus the intersection of its parents, iterate to a shrinking fixed point for cyclic async graphs, and intersect across the chunk's groups.
2026-10-21 12:23:29 -07:00
Flo
08a419c109
chore: update Node.js to 26.12.1 (#8779) 2026-10-21 19:28:23 +02:00
Guru 🦄
ed5577593a
fix(start-plugin-core): skip the Rsbuild import-protection loader when disabled (#8748)
* fix(start-plugin-core): skip the Rsbuild import-protection loader when disabled

- With import protection disabled, the Rsbuild integration still added
  its post loader for every JS and TS module, node_modules included,
  plus its virtual modules plugin. The loader returned at once, but every
  module still paid for a loader step.
- Register nothing when import protection is disabled, as the Vite
  plugin does.

* test(start-plugin-core): drop the disabled import-protection unit test
2026-10-19 08:51:03 +02:00
Guru 🦄
63a886da90
fix(start-plugin-core): skip unchanged server function resolver rebuilds in Rsbuild dev (#8750)
* fix(start-plugin-core): skip unchanged server function resolver rebuilds in Rsbuild dev

- Skip the resolver rebuild at the end of make when the resolver has not
  been written since this compiler last rebuilt it. Rebuilding an
  unchanged resolver made Rspack rebuild the server chunk graph after
  every edit.
- Child compilations still rebuild every time and do not change the
  parent compiler's state.
- The RSC resolver hook skips unchanged writes in dev, like the non-RSC
  hook.

* docs: drop the COMPILER_ARCHITECTURE.md change
2026-10-19 08:50:39 +02:00
Shkumbin Hasani
d9b07e8d3b
perf(start-plugin-core): skip resolving member calls on non-namespace receivers (#8758)
* perf(start-plugin-core): skip resolving member calls on non-namespace receivers

A top-level `a.b()` initializer was a direct-call candidate for any `a`, so
`const Input = z.object({...})` resolved `z` and, in dev, loaded and parsed all
of zod through `?server-fn-module-lookup` while every compiled file waited.

For a receiver that is not a namespace import, resolution gives the call the
kind of the receiver itself, which only yields a candidate when the receiver
is an env-only factory and the code calls one of its properties. Skip those
calls; namespace calls, identifier calls and method chains resolve as before.

Refs #8757

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(start-plugin-core): cover member calls across compiler modes

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Sheraff <me@florianpellet.com>
2026-10-18 23:17:05 +02:00
Flo
a8f4dce5f4
ci: skip bundle size comment on fork pull requests (#8764) 2026-10-18 22:51:44 +02:00
Flo
336fdfba42
ci: skip labeler on fork pull requests (#8763) 2026-10-18 22:46:57 +02:00
Manuel Schiller
b1b111761b
bump node version to 26.10.0 (#8509)
* bump node version to 26.10.0

* run benchmarks on  .nvmrc changes

* Rename client-nav-benchmarks.yml to benchmarks.yml

* chore(ci): update references to the renamed benchmarks workflow

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 17:04:18 +02:00
Flo
76cd9e178d
ci: keep bundle-size measurement out of the Test workflow (#8669)
The measurement target was named `build`, so `test:pr`/`test:ci` and
`build:all` picked it up via `--targets=...,build`. Its cache entry was
never reused: the Bundle Size workflow runs with NX_NO_CLOUD and
--skipRemoteCache. Rename it to `measure` (with explicit `cache: true`,
previously inherited from the `build` target default).

Since dependency-only changes no longer reach this target through
`nx affected`, add `.nvmrc`, `package.json` and `pnpm-lock.yaml` to the
Bundle Size workflow path filters so toolchain bumps are still measured.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 12:35:23 +02:00
Flo
647cb737a5
refactor(router-plugin): remove enableRouteGeneration option (#8737)
Disabling route generation also silently disabled autoCodeSplitting,
because the code splitter relies on route metadata populated by the
generator. Remove the option instead of patching the interaction, so the
generator always runs.

Closes #5087

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 12:22:15 +02:00
Flo
32a3360cba
docs(skills): reference cross-package skills by intent ID (#8670)
@tanstack/intent 0.5.4 rejects SKILL.md links that resolve outside the
owning package, which fails the "Validate intent skills" CI job. Replace
those relative links with `<package>#<skill>` identifiers that
`intent load` resolves regardless of node_modules layout.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 11:10:53 +02:00
Flo
689a7c5419
fix(react-router): publish agent skills (#8671)
The skills added in #6866 were never published for @tanstack/react-router
because its `files` list, unlike the other packages with skills, omitted
`skills`.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-17 09:11:16 +02:00
github-actions[bot]
caaf32da35
ci: Version Packages (#8733) release-2026-10-16-2111 @tanstack/react-router@1.170.45 @tanstack/react-start-client@1.168.43 @tanstack/react-start-rsc@0.1.64 @tanstack/react-start-server@1.167.51 @tanstack/react-start@1.169.3 @tanstack/router-cli@1.167.45 @tanstack/router-core@1.171.38 @tanstack/router-generator@1.167.45 @tanstack/router-plugin@1.168.47 @tanstack/router-vite-plugin@1.167.47 @tanstack/solid-router@1.170.42 @tanstack/solid-start-client@1.168.41 @tanstack/solid-start-server@1.167.49 @tanstack/solid-start@1.169.3 @tanstack/start-client-core@1.170.38 @tanstack/start-plugin-core@1.171.54 @tanstack/start-server-core@1.169.44 @tanstack/start-static-server-functions@1.167.43 @tanstack/start-storage-context@1.167.40 @tanstack/vue-router@1.170.41 @tanstack/vue-start-client@1.167.44 @tanstack/vue-start-server@1.167.49 @tanstack/vue-start@1.169.3
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-16 23:05:28 +02:00
Max Katz
18154b1c45
perf: lower manifest script preload priority (#8212)
* perf: lower manifest script preload priority

* fix(start-server-core): forward fetchPriority into static Early Hints

Static script hints were built from getScriptPreloadAttrs but copied only
href, rel, as and crossOrigin, so Chromium started hinted preloads at
MEDIUM before the HTML's fetchPriority="low" arrived. Build them with the
shared addEarlyHintFetchAttrs helper, which the dynamic hint path already
uses, so fetchPriority (and crossOrigin) are carried into 103 hints and the
response Link header.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: cover low-priority manifest preloads in Solid and Vue

Add a Solid server-suite SSR test for module and IIFE preloads and assert
fetchpriority="low" on rendered preloads in the Solid and Vue HeadContent
tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs: note low-priority JavaScript Early Hints

Mention that JavaScript Early Hints carry fetchpriority=low and extend the
changeset to start-server-core.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Manuel Schiller <6340397+schiller-manuel@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 15:35:33 +02:00
Manuel Schiller
7a06725038
chore(deps): upgrade Vitest to 5 and migrate benchmarks to the bench fixture (#8723) 2026-10-16 00:41:32 +02:00
Flo
6777b8b0a5
add AI rules to CONTRIBUTING.md (#8714) 2026-10-14 17:40:27 +02:00
github-actions[bot]
140efa4347
ci: Version Packages (#8701) release-2026-10-14-1451 @tanstack/react-start-rsc@0.1.63 @tanstack/react-start-server@1.167.50 @tanstack/react-start@1.169.2 @tanstack/router-cli@1.167.44 @tanstack/router-generator@1.167.44 @tanstack/router-plugin@1.168.46 @tanstack/router-utils@1.162.4 @tanstack/router-vite-plugin@1.167.46 @tanstack/solid-start-server@1.167.48 @tanstack/solid-start@1.169.2 @tanstack/start-plugin-core@1.171.53 @tanstack/start-server-core@1.169.43 @tanstack/vue-start-server@1.167.48 @tanstack/vue-start@1.169.2
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-14 16:46:30 +02:00
Flo
fdc10fa13f
chore(deps): bump srvx to ^1.0.0 and @vitejs/plugin-rsc to ^0.5.37 (#8708)
* chore(deps): bump srvx to ^1.0.0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(deps): bump @vitejs/plugin-rsc to ^0.5.37

0.5.37 depends on srvx ^1.0.5, which drops the last srvx 0.11 copy from
the lockfile. It is temporarily excluded from minimumReleaseAge until it
is 24h old.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: drop minimumReleaseAge exclusion for @vitejs/plugin-rsc

0.5.37 is now older than the 24h minimum release age.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(ci): TEMP experiment - rsc e2e on srvx 0.10 (revert before merge)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Revert "test(ci): TEMP experiment - rsc e2e on srvx 0.10 (revert before merge)"

This reverts commit 2c7279a0b9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 15:24:04 +02:00
Flo
08181cc1f7
test(rsc): make progressive streaming e2e tests independent of fixed sleeps (#8713)
test(rsc): wait for streamed notifications instead of fixed sleeps

The progressive-streaming tests slept 500ms and expected the initial batch
of 3 notifications to be rendered. React throttles Suspense reveals by
300ms, so the batch can legitimately land after that window. Wait for the
3rd notification, assert the stream is still open with fewer than all
notifications, then wait for the next one and for completion.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 15:04:11 +02:00
Flo
71d9694da6
chore(deps): bump fetchdts to ^0.2.0 (#8710)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 00:53:46 +02:00
Flo
a80cd74105
chore(router-cli): replace yargs with cac (#8711)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 00:51:58 +02:00
Flo
923d98b18b
chore(deps): bump diff to ^9.0.0 (#8709)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 00:28:28 +02:00
github-actions[bot]
4ff63eb8a4
ci: Version Packages (#8700) release-2026-10-12-2358 @tanstack/react-router@1.170.44 @tanstack/react-start-client@1.168.42 @tanstack/react-start-rsc@0.1.62 @tanstack/react-start-server@1.167.49 @tanstack/react-start@1.169.1 @tanstack/router-cli@1.167.43 @tanstack/router-core@1.171.37 @tanstack/router-generator@1.167.43 @tanstack/router-plugin@1.168.45 @tanstack/router-vite-plugin@1.167.45 @tanstack/solid-router@1.170.41 @tanstack/solid-start-client@1.168.40 @tanstack/solid-start-server@1.167.47 @tanstack/solid-start@1.169.1 @tanstack/start-client-core@1.170.37 @tanstack/start-plugin-core@1.171.52 @tanstack/start-server-core@1.169.42 @tanstack/start-static-server-functions@1.167.42 @tanstack/start-storage-context@1.167.39 @tanstack/vue-router@1.170.40 @tanstack/vue-start-client@1.167.43 @tanstack/vue-start-server@1.167.47 @tanstack/vue-start@1.169.1
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-13 01:43:37 +02:00
Manuel Schiller
ff85a51deb
docs (#8699) 2026-10-13 01:35:59 +02:00
Manuel Schiller
740b0ce177
perf: skip unused Start request setup (#8451)
Create the request middleware deduplication set only when request
middleware is configured, and pass Start's serialization adapters to the
router without copying them when the router adds none.

Server route handlers and route middleware now receive the router's
decoded pathname, the one used for route matching.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 01:33:36 +02:00
Manuel Schiller
d6ba115d57
perf: reuse prepared SSR request locations (#8441) 2026-10-13 01:33:36 +02:00
github-actions[bot]
80e2eabf48
ci: Version Packages (#8661) release-2026-10-12-2321 @tanstack/react-router@1.170.43 @tanstack/react-start-client@1.168.41 @tanstack/react-start-rsc@0.1.61 @tanstack/react-start-server@1.167.48 @tanstack/react-start@1.169.0 @tanstack/router-cli@1.167.42 @tanstack/router-core@1.171.36 @tanstack/router-generator@1.167.42 @tanstack/router-plugin@1.168.44 @tanstack/router-vite-plugin@1.167.44 @tanstack/solid-router@1.170.40 @tanstack/solid-start-client@1.168.39 @tanstack/solid-start-server@1.167.46 @tanstack/solid-start@1.169.0 @tanstack/start-client-core@1.170.36 @tanstack/start-plugin-core@1.171.51 @tanstack/start-server-core@1.169.41 @tanstack/start-static-server-functions@1.167.41 @tanstack/start-storage-context@1.167.38 @tanstack/vue-router@1.170.39 @tanstack/vue-start-client@1.167.42 @tanstack/vue-start-server@1.167.46 @tanstack/vue-start@1.169.0
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-13 01:14:33 +02:00
Sarah Gerrard
4104b8ef11
fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS (#8695)
* fix(start-plugin-core): preload transitive static imports and fix Rsbuild shared-chunk CSS

Route preloads read a chunk's `imports` as a complete list, which only
holds when the bundler hoists transitive imports. Walk the static import
graph instead, and derive Rsbuild chunk imports from the module graph
rather than chunk-group siblings so shared chunks stop attaching
unrelated route CSS to the SSR response.

Fixes #8415
Fixes #8511

* refactor(start-plugin-core): share one static import walk for preloads and CSS

The manifest builder walked the static import graph twice, once breadth-first
for preloads and once recursively for stylesheets. A single memoized
depth-first walk now records discovered file names for preloads and chunks in
post-order for stylesheets, which also keeps every chunk in an import cycle
seeing the whole cycle instead of a partially cached result.

The Rsbuild adapter resolved static dependency chunks again for every CSS-only
chunk reached from each importer; the resolution is now memoized per chunk.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* docs(start-plugin-core): drop Rollup from the imports contract comments

Rollup is no longer a supported client bundler, so the `imports` contract is
described in terms of the direct-imports-only lists Rolldown and Rsbuild emit.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Manuel Schiller <6340397+schiller-manuel@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-10-13 01:07:27 +02:00
Manuel Schiller
f243c61e95
Start stable (#8696) 2026-10-13 00:45:16 +02:00
Manuel Schiller
021e05da71
chore: remove experimental Nitro v2 Vite plugin (#8537) 2026-10-13 00:42:07 +02:00
Manuel Schiller
550f478810
refactor(start)!: remove the deprecated inputValidator (#8694)
* refactor(start)!: remove the deprecated inputValidator

createServerFn().inputValidator() and createMiddleware().inputValidator()
were deprecated aliases of validator(). Remove both, the inputValidator
option the builders set, and the compiler's deprecation warnings, so
validator() is the only way to declare a validator. Server functions now
store their validator under the key middleware reads.

The compiler test of diagnostic locations across line terminators now
checks the code frame of the destructuring diagnostic instead of the
removed warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(agents): do not test that a removed API is gone

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-13 00:32:10 +02:00
Manuel Schiller
94d6d8e496
response reconciliation (#7588) 2026-10-13 00:01:04 +02:00
Flo
f3d7ee3374
fix(start-plugin-core): declare image and news namespaces in sitemap.xml (#8692)
The sitemap writer emitted image:* and news:* elements, but <urlset> only
declared the default sitemap namespace and xmlns:xhtml. xmlbuilder2
serialized those elements with xmlns="" and an undeclared prefix, so
sitemaps with images or news were not namespace-well-formed XML. Declare
xmlns:image and xmlns:news on <urlset>.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-12 22:38:03 +02:00
Flo
19524ccdd7
fix(start-plugin-core): keep prerender-specific properties out of public pages.json (#8691)
* fix(start-plugin-core): keep prerender credentials out of public pages.json

pages.json and sitemap.xml are now built from schema-validated public page
fields, so prerender headers and extra data returned by prerender.onSuccess
are stripped from the published files. Invalid sitemap metadata returned by
prerender.onSuccess now fails the build with an error naming the page and
the offending field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changeset): describe previous onSuccess sitemap behavior accurately

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-12 19:43:29 +02:00
Flo
57bd1a92f9
fix(router-generator): don't scaffold over a route file mid in-place save (#8664)
* fix(router-generator): don't scaffold over a route file mid in-place save

An in-place save truncates the file and then writes it. If the generator
reads the route file in between, it sees empty content and scaffolds a
template. Its mtime guard before renaming the template into place does not
catch the completed save, because the truncation and the write usually share
one mtime tick on Linux, so the user's content was replaced by the template.

Route file writes now also confirm the file still has the content the
generator read before replacing it.

This was the main cause of flaky tanstack-react-start-e2e-hmr runs, where SSR
rendered `Hello "/route"!` after the test restored a route file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(router-generator): check for concurrent saves right before the rename

safeFileWrite compared the target's mtime and content before preparing the
temporary file's mode and owner, so a save completing during those steps was
still replaced. Run the check last, immediately before the rename.

The regression test now also completes the save during the temporary file
stat, and keeps the generator's tmpDir inside the test directory so the
rename never crosses filesystems (EXDEV on CI).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(router-generator): match generator paths on Windows in concurrent save test

The generator reads route files through forward-slash paths, also on Windows,
so compare resolved paths when injecting the concurrent save.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* perf(router-generator): only read files whose content is compared

The final concurrent-change check before the rename read the whole target
file even for the route tree, whose content is never compared. Stat it
instead, as before, and read only route files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-11 10:23:54 +02:00
Guru 🦄
e66da18266
fix(router-plugin): remove redundant string excludes from the reference filter (#8655)
* fix(router-plugin): remove redundant string excludes from the reference filter

* fix(router-plugin): remove unused tsrShared import
2026-10-10 19:51:17 +02:00
Flo
4fea98aff8
test(start-plugin-core): match Rolldown module ids on Windows in bundled dev styles test (#8660)
Rolldown module ids use forward slashes on Windows, so looking up the
native entry path never matched and the test waited until it timed out.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 18:27:40 +02:00
Flo
e26735166f
ci: test the compilers on Windows, macOS, Linux arm64 and musl (#8626)
* ci: test the compilers on Windows, macOS, Linux arm64 and musl

The main PR workflow only runs on Linux x64 (glibc). The compilers load a
native Yuku binary per platform and handle platform-specific paths, so run
their unit tests and Vite and Rsbuild production builds of the React Start
e2e app on the other platforms we ship to. Runs on PRs touching the
compiler packages or the lockfile, weekly, and on demand.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci: run all compiler platforms in one matrix job and keep LF on Windows

Merge the musl job into the matrix through a matrix container, so the
install, test and build steps exist once. Disable autocrlf before checkout:
Windows runners otherwise check out the LF snapshot files as CRLF and every
file snapshot mismatches.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci: check out LF on Windows compiler runs

With `* text=auto`, disabling core.autocrlf alone still converts text files
to the native (CRLF) eol on Windows, so also set core.eol=lf.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-10 17:23:18 +02:00
Flo
42a7914cd5
test: format compiler output before comparing snapshots (#8658)
* test: format compiler output before comparing file snapshots

The router-plugin and start-plugin-core compiler snapshots record the
layout choices of the code generator (object wrapping, blank lines,
parentheses around JSX) along with the emitted program, so swapping the
code generator rewrites most snapshot files even when the output is the
same.

Format the output with Prettier before comparing it: fixed options,
`objectWrap: 'collapse'`, and blank lines outside template literals
removed. Comments are kept. Output that does not parse is compared as is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: regenerate compiler snapshots with formatted output

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: format inline compiler snapshots before comparing them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 14:09:42 +02:00
github-actions[bot]
c79c620bf4
ci: Version Packages (#8580) release-2026-10-10-0730 @tanstack/history@1.162.5 @tanstack/react-router@1.170.42 @tanstack/react-start-client@1.168.40 @tanstack/react-start-rsc@0.1.60 @tanstack/react-start-server@1.167.47 @tanstack/react-start@1.168.61 @tanstack/router-cli@1.167.41 @tanstack/router-core@1.171.35 @tanstack/router-generator@1.167.41 @tanstack/router-plugin@1.168.43 @tanstack/router-vite-plugin@1.167.43 @tanstack/solid-router@1.170.39 @tanstack/solid-start-client@1.168.38 @tanstack/solid-start-server@1.167.45 @tanstack/solid-start@1.168.58 @tanstack/start-client-core@1.170.35 @tanstack/start-plugin-core@1.171.50 @tanstack/start-server-core@1.169.40 @tanstack/start-static-server-functions@1.167.40 @tanstack/start-storage-context@1.167.37 @tanstack/vue-router@1.170.38 @tanstack/vue-start-client@1.167.41 @tanstack/vue-start-server@1.167.45 @tanstack/vue-start@1.168.57
ci: changeset release

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-10-10 09:25:30 +02:00
Manuel Schiller
41916400b9
fix(start): preserve dev SSR CSS order (#7830)
* fix(start): preserve dev SSR CSS order

fixes #7794

* add e2e tests for solid and vue, handle vue style urls

* test(start): cover bundled dev styles and SSR reload lifecycle

* fix(start): use completed bundled graph for dev SSR styles

* fix(start): preserve import reachability across bundled dev variants

* test(start): cover layered inline CSS without build observers

* test(start): wait for bundled HMR route registration

* test(start): await HMR readiness in both Vite modes

* test(start): trace initial bundled HMR update in CI

* test(start): trace native bundled HMR watcher in CI

* test(start): inspect initial native watch registrations

* fix(start): support the latest bundled dev toolchain
2026-10-10 09:18:39 +02:00
Flo
f6d21de12b
revert: keep server-rendered pending UI of no-SSR routes through hydration (#8643) (#8646)
This reverts commit ff9f753c09.

#8643 introduced a React hydration mismatch for `ssr: false` and
`ssr: 'data-only'` routes without a pending component: the client load can
commit before React hydrates the route's Suspense boundary, which then
hydrates the route component against the server's pending UI. Revert while a
proper fix is worked on.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-09 21:41:47 +02:00
Flo
ff9f753c09
fix: keep server-rendered pending UI of no-SSR routes through hydration (#8643)
* fix: keep server-rendered pending UI of no-SSR routes through hydration

Fixes #8640. The server rendered a no-SSR match's pending UI in a
ClientOnly fallback, while the hydrating client renders the presented
pending match through MatchInner. After hydration the switch replaced
(React: hid and duplicated) the server node. Render the server pending UI
through the same MatchInner pending path and drop the ClientOnly wrapper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: cover terminal no-SSR boundaries through hydration

Add error, notFound and URL not-found cases for `ssr: 'data-only'` and
`ssr: false` boundaries (plus a terminal child below a data-only boundary)
in React, Solid and Vue. Each case asserts the server payload, that the
server skeleton is the only one and is held for `pendingMinMs`, and that no
hydration mismatch is reported. The hold check catches mismatches that React
and Solid error boundaries replace silently.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-09 20:40:06 +02:00
Flo
17a3121ff4
chore: add AI contribution guidance to GitHub templates (#8641) 2026-10-08 20:45:44 +02:00
VihaanAgarwal
663282b0eb
fix(router-core): avoid null bytes in dehydrated SSR match ids (#7654)
* fix(router-core): avoid null bytes in dehydrated SSR match ids

dehydrateSsrMatchId replaced "/" with U+0000 so dehydrated ids would not
look like crawlable URLs (#6739). U+0000 is forbidden in the HTML input
stream though, so the inlined hydration payload tripped a
control-character-in-input-stream parse error and failed markup
validation. Encode with U+FFFD instead, which is valid in HTML and which
hydrateSsrMatchId already decodes back to "/".

* test(router-core): cover legacy null-byte decode in hydrateSsrMatchId

The codec keeps the U+0000 -> "/" decode branch so SSR payloads from a deploy before the U+FFFD switch still hydrate. That branch was the one path the suite didn't exercise, so add a test for it.

* fix(router-core): compare SSR match ids in encoded form

Encode slashes as U+FFFD with no further escaping, and have the client
encode its own match id instead of decoding the server's. Payload and
client always ship from the same build, so the legacy null-byte decode
and the reversible escape scheme are no longer needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* perf(router-core): keep dehydrated SSR match ids one-byte

A U+FFFD delimiter made V8 widen the encoded ids, and every HTML string
concatenated with them, to two-byte strings, slowing Solid SSR
serialization by ~5%. Use ASCII `|` instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(router-core): delimit dehydrated SSR match ids with '#'

`|` is a valid static route character, so `/a/b` and `/a|b` encoded to
the same id. A decoded pathname keeps `%23` encoded and params encode
`#`, so a matched id cannot get a '#' from the URL. Seroval emits it
unescaped and it keeps the HTML one-byte.

Tighten the regression test to reject any non-whitespace control
character and any char above U+00FF in the inlined hydration HTML.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Flo <me@florianpellet.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 08:27:20 +02:00