regulator: of: Fixes to of_regulator_bulk_get_all()

Browse source

Alexey Charkov <alchark@flipper.net> says:

of_regulator_bulk_get_all() only fills in the .consumer part of the
struct regulator_bulk_data for the regulators it gets, leaving .supply as
garbage, while the rest of the regulator core expects a meaningful name
there (e.g. for error prints), causing uninitialized memory access in any
failure paths in the core.

It also allocates the supplies array and hands it to callers, but never
says the callers need to free it (which they don't currently), causing
leaks.

Fix the former and document the latter in the kerneldoc to help any new
users avoid the leak.

Link: https://patch.msgid.link/20260930-regulator-get-all-v2-0-ca82070d22f2@flipper.net

...

This commit is contained in:

Mark Brown 2026-10-04 18:29:13 +02:00

parent 2f15518682 b35ff7bd7d

commit 5a26d7d96a

1 changed files with 22 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

29

drivers/regulator/of_regulator.c

View file