mtd: nand: denali: use more FIELD_PREP / FIELD_GET where appropriate

Browse source

In several places in this driver, the register fields are retrieved
as follows:

  val = reg & FOO_MASK;

Then, modified as follows:

  reg &= ~FOO_MASK;
  reg |= val;

This code relies on its shift is 0, which we will never know until
we check the definition of FOO_MASK.  Use FIELD_PREP / FIELD_GET
where appropriate.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

...

This commit is contained in:

Masahiro Yamada 2017-09-22 12:46:44 +09:00 • committed by Boris Brezillon

parent e0d53b3f8e

commit 8e4cbf7f0a

1 changed files with 11 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

22

drivers/mtd/nand/denali.c

View file