drm/i915: Refactor common list iteration over GGTT vma

Browse source

In quite a few places, we have a list iteration over the vma on an
object that only want to inspect GGTT vma. By construction, these are
placed at the start of the list, so we have copied that knowledge into
many callsites. Pull that knowledge back to i915_vma.h and provide a
for_each_ggtt_vma() to tidy up the code.

v2: Add a backreference from vma_create() to remind ourselves why we put
ggtt vma at the head of the obj->vma_list (and ppgtt vma at the tail).
v3: Fixup s/vma/V/

Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20171207211407.31549-1-chris@chris-wilson.co.uk

...

This commit is contained in:

Chris Wilson 2017-12-07 21:14:07 +00:00

parent 7125397b82

commit e2189dd078

6 changed files with 30 additions and 29 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/gpu/drm/i915/i915_debugfs.c

View file

18

drivers/gpu/drm/i915/i915_gem.c

View file

5

drivers/gpu/drm/i915/i915_gem_gtt.c

View file

10

drivers/gpu/drm/i915/i915_gem_tiling.c

View file

6

drivers/gpu/drm/i915/i915_vma.c

View file

16

drivers/gpu/drm/i915/i915_vma.h

View file