Commit graph

361,091 commits

Author SHA1 Message Date
Lukas Czerner
5de35e8d5c ext4: Avoid underflow in ext4_trim_fs()
Currently if len argument in ext4_trim_fs() is smaller than one block,
the 'end' variable underflow. Avoid that by returning EINVAL if len is
smaller than file system block.

Also remove useless unlikely().

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2012-10-22 18:01:19 -04:00
Russell King
b43b1ffa82 Merge tag 'fixes-for-rmk' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into fixes 2012-10-22 22:56:09 +01:00
Russell King
00b7dede8b ARM: drop experimental status for hotplug and Thumb2
Both these features have been around for a long time now, and haven't
had any recent issues brought up.  So lets drop their experimental
status.

In any case, hotplugis  selected by other non-experimental options
which then cause a Kconfig warning.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2012-10-22 22:54:30 +01:00
Greg Kroah-Hartman
69afc09042 First round of new IIO drivers and cleanups for the 3.8 cycle.
Here we have
 
 * New driver ad5449 with the introduction of a new IIO return type
   to simplify power of 2 dividers (extremely common case).
 * Some coccinelle warning fixing patches (dull but worthwhile as
   make for easier automated testing and cut down on false positives).
 * Some trivial bits of formatting cleanup and spelling corrections.
 * Use kcalloc in a few places for semantic reasons.
 * Stop lis3l02dq driver (soon to be dropped I hope) using now non
   existent irq_to_gpio.
 * Some dead code/unused variable removal
 * Convert a few drivers to generic core provided functions instead
   of their own versions.
 
 So all in all a nice new driver and a lot of worthy but dull cleanup.
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.19 (GNU/Linux)
 
 iQIcBAABAgAGBQJQgm++AAoJEFSFNJnE9BaI2IkP/AuM7ITQQ737wUGAi0IHayBa
 JjQniXlEDelifbEDLXA2jq+KIJ2kEA+khHz6uB2944RV+v5VJOAIQd2LyOS0N8DN
 l2Ne6+hPzBCGqQ2iYbfPEKzCw9Y4HYNBisCpcjgoLfhvKXjV4Re8qu89lJs457J1
 YvfbYRxCId8wBML20m7P9eEMS0OsXyq6dfU59KZQBKVfOF8dsGEoyxgHTfjzzj7S
 hJNo/9wQPkXMX3O3Cvs8qUmwRGBrTy7vQ5JDjQRYDbcSFXdo9NZtmCSAk6I5fg3T
 HLOQ9k+07QQ762HDIsgg0JO5VCiOcRobw/ZjPTuatN3jAQavVBChRxcAqMHp/uzo
 LSfOzWWOP7c+00YoRCz1BkaQU0WMD19fg6gp2yDsDjeKz9ADaOWuov2tc7oe7pBf
 PbfcK1hrtbyqIK/4xAHyVus5sTZc2aaRzQY/OMzx99nGc9xf5XCfmpB8jf0LjkO5
 kWXqAgajo8RoKtFmiJ7tAE89jIhjRPYeUZDGZgDOz/V3wfkqUMp94AiMTsVZQWLp
 AZkXD7j/cHIfkaajYfJuGDmxU6tagqqbFq4Cfz6r668j9UQrYvuKrqUS3tgFzKGI
 +exh8W5IhNdDlP9CSjE+QbfZpTqo0EcuN/6ySGhxLwiGe1x3P4LrGG1rDkg/Kt2t
 S1JXQia86vz93S1iK3bQ
 =uRm3
 -----END PGP SIGNATURE-----

Merge tag 'iio-for-3.8a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next

First round of new IIO drivers and cleanups for the 3.8 cycle.

Here we have

* New driver ad5449 with the introduction of a new IIO return type
  to simplify power of 2 dividers (extremely common case).
* Some coccinelle warning fixing patches (dull but worthwhile as
  make for easier automated testing and cut down on false positives).
* Some trivial bits of formatting cleanup and spelling corrections.
* Use kcalloc in a few places for semantic reasons.
* Stop lis3l02dq driver (soon to be dropped I hope) using now non
  existent irq_to_gpio.
* Some dead code/unused variable removal
* Convert a few drivers to generic core provided functions instead
  of their own versions.

So all in all a nice new driver and a lot of worthy but dull cleanup.
2012-10-22 14:52:19 -07:00
Sunhee Hwang
9385f21b29 Staging: csr: fix code indent coding style issues in csr_wifi_hip_signals.h
This is a patch that fixes up code indent coding style warnings
in the csr_wifi_hip_signals.h found by checkpatch.pl tool.

Signed-off-by: Sunhee Hwang <sunheehwang821@gmail.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:48:14 -07:00
Jugwan Eom
906836f6e3 Staging: csr: csr_wifi_router_ctrl_sef.c: fix line over 80 characters
This patch fixes line over 80 characters problem found by checkpatch.pl
tool.

Signed-off-by: Jugwan Eom <zugwan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:46:49 -07:00
Jugwan Eom
057ed67170 Staging: csr: csr_wifi_router_ctrl_sef.c: fix tab mess
This patch converts spaces to tabs.

Signed-off-by: Jugwan Eom <zugwan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:46:49 -07:00
Jugwan Eom
86a598cd86 Staging: csr: csr_wifi_router_ctrl_sef.c: fix up brace placement
This patch fixes a brace placement error found by checkpatch.pl tool.

Signed-off-by: Jugwan Eom <zugwan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:46:48 -07:00
Sangho Yi
0288f91dbb staging: csr: csr_wifi_sme_sef.h: fixed indentation warnings
Fixed indentation warnings on comments

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:54 -07:00
Sangho Yi
9bf8ff7f18 staging: csr: csr_wifi_sme_serialize.h: fixed indentation warnings
Fixed indentation warnings from the comments.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:54 -07:00
Sangho Yi
f0dbd1dcb1 staging: csr: csr_wifi_sme_sef.h: Fixed lines over 80 chars per line
Fixed lines over 80 characters per line.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:54 -07:00
Sangho Yi
1ac80e498a staging: csr: csr_wifi_sme_sef.h: Fixed from foo* bar to foo *bar
Fixed coding style errors like foo* bar to foo *bar for the definition
of input and output variables of the function interfaces.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:53 -07:00
Sangho Yi
6b74b192f6 staging: csr: csr_wifi_sme_serialize.h: fixed over 80 char lines
Appropriately modified the lines over 80 characters.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:53 -07:00
Sangho Yi
095cc7143d staging: csr: csr_wifi_sme_serialize.h: Fixed from foo* bar to foo *bar
Fixed the coding style convention warnings for the statements of the
pointer variable declaration.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:53 -07:00
Sangho Yi
9851c29c7f staging: csr: csr_wifi_sme_task.h: fixed indentation coding style
Removed coding style warnings occurred on the comments.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:43:53 -07:00
Sangho Yi
936a8b4c29 Drivers: Staging: CSR: fixed coding style errors in csr_wifi_router_free_upstream_contents.c
Originally there were a lot of coding style errors so, I cleaned up the
coding style errors including braces and indentations.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 14:01:42 -07:00
Sunhee Hwang
ae485c27c7 Staging: csr: fix pointer(asterisk) position coding style issue in sme_userspace.h
This is a patch in the sme_userspace.h that fixes up
a pointer(asterisk) position warning found by checkpatch.pl tool

Signed-off-by: Sunhee Hwang <sunheehwang821@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:59:05 -07:00
SeongJae Park
cf174b0ef5 staging: csr: csr_framework_ext_types.h: fix coding style
Fix coding style of csr_framework_ext_types.h
    
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:58:10 -07:00
Daniel Vetter
397fe15715 drm: extract drm_dp_max_lane_count helper
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2012-10-22 22:56:43 +02:00
Sangho Yi
3f38ea7de4 Staging: CSR: csr_time.h: Removed unnecessary typedef struct
I removed the unnecessary typedef struct from the csr_time.h.
There is no actual usage of the typedef definition.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:53:53 -07:00
Sangho Yi
7177572556 Staging: CSR: csr_time.h: fixed indentation warnings based on coding style
I fixed the indentation warnings on csr_time.h.

Signed-off-by: Sangho Yi <antiroot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:53:09 -07:00
Greg Kroah-Hartman
0567e1ec43 Staging: csr: data_tx: remove extra space in printk
This saves us 1 byte!

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:48:04 -07:00
Greg Kroah-Hartman
dbff11c9d3 Staging: csr: data_tx: fix up brace placement
This cleans up the brace placement coding issues.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:48:04 -07:00
Greg Kroah-Hartman
7c5745cc08 Staging: csr: data_tx: clean up tab mess
This patch converts spaces to tabs.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:48:04 -07:00
Homin Lee
60ac2e9f7f Staging: csr: csr_log_configure.h: clean up tab mess
Signed-off-by: Homin Lee <homin.lee@suapapa.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:48:04 -07:00
Wei Yongjun
36dab6e5f0 staging: csr: remove unused including <linux/version.h>
Remove including <linux/version.h> that don't need it.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:48:04 -07:00
Nitin Gupta
c8f2f0db1d staging: zram: Fix handling of incompressible pages
Change 130f315a (staging: zram: remove special handle of uncompressed page)
introduced a bug in the handling of incompressible pages which resulted in
memory allocation failure for such pages.

When a page expands on compression, say from 4K to 4K+30, we were trying to
do zsmalloc(pool, 4K+30). However, the maximum size which zsmalloc can
allocate is PAGE_SIZE (for obvious reasons), so such allocation requests
always return failure (0).

For a page that has compressed size larger than the original size (this may
happen with already compressed or random data), there is no point storing
the compressed version as that would take more space and would also require
time for decompression when needed again. So, the fix is to store any page,
whose compressed size exceeds a threshold (max_zpage_size), as-it-is i.e.
without compression.  Memory required for storing this uncompressed page can
then be requested from zsmalloc which supports PAGE_SIZE sized allocations.

Lastly, the fix checks that we do not attempt to "decompress" the page which
we stored in the uncompressed form -- we just memcpy() out such pages.

Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Reported-by: viechweg@gmail.com
Reported-by: paerley@gmail.com
Reported-by: wu.tommy@gmail.com
Acked-by: Minchan Kim <minchan@kernel.org>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:45:19 -07:00
Minchan Kim
55dcbbb1bf staging: zram: correct obsolete comment on max_zpage_size
Zram doesn't use xv_malloc any more so it doesn't have
limitation about zobj_header.

Signed-off-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:43:46 -07:00
Wei Yongjun
1055d62790 staging: ste_rmi4: use module_i2c_driver to simplify the code
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:43:46 -07:00
Bernard Blackham
9e1b6cb9dc staging: usbip: Avoid superfluous set HC_STATE_RUNNING in vhci_start
HC_STATE_RUNNING is already set by the usb core.

Signed-off-by: Bernard Blackham <b-linuxgit@largestprime.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:38:40 -07:00
Bernard Blackham
3d0a2a22c9 staging: usbip: Don't leak struct file.
usbip takes a reference on a struct file which is passed in via
sysfs.  Previously, this reference was never cleaned up, although
the socket it referred to was.

This patch drops the corresponding reference (found with the
socket's ->file backpointer) instead of just closing the socket.

Signed-off-by: Bernard Blackham <b-linuxgit@largestprime.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:38:04 -07:00
Tony Lindgren
1d8643dd05 ARM: OMAP3: Fix 3430 legacy mux names for ssi1 signals.
On n900 uart1 pins are not not used for uart, instead they are
used to connect to a cell modem over ssi. Looks like we're
currently missing these signal names for 3430 for some reason,
and only have some of them listed for 3630. Obviously the signals
are there for 3430 if n900 is using them and they are documented
in some TRMs.

Note that these will eventually be replaced by device tree
based pinctrl-single.c driver. But for now these are needed
to verify the SSI pins for devices like Nokia N900.

Signed-off-by: Tony Lindgren <tony@atomide.com>
2012-10-22 13:37:37 -07:00
Tony Lindgren
24942e8af1 ARM: OMAP2+: Fix location of select PINCTRL
Commit 8f31cefe (ARM: OMAP2+: select PINCTRL in Kconfig)
added select PINCTRL, but accdentally added it to a wrong
location.

We want to select if for ARCH_OMAP2PLUS, not for
ARCH_OMAP2PLUS_TYPICAL.

Signed-off-by: Tony Lindgren <tony@atomide.com>
2012-10-22 13:37:34 -07:00
Peter Ujfalusi
eef6fcaa42 ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio
Fixes the following errors:
[    2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
[    2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel

Which is because we failed to link the sidetone hwmod for McBSP2/3. The
missing sidetone hwmod link will prevent omap_device_alloc() to append the
DMA resources since we - accidentally - end up having the same number of
resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
without the ST resources.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Benoit Cousson <b-cousson@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
2012-10-22 13:36:53 -07:00
Bart Westgeest
c7f0089931 staging: usbip: cleanup of comments
Removed commented-out code, obsolete comments, and fixed comment typos.

Signed-off-by: Bart Westgeest <bart@elbrys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:36:29 -07:00
Bart Westgeest
20960faca5 staging: usbip: make rh_port_disconnect static
Signed-off-by: Bart Westgeest <bart@elbrys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:36:28 -07:00
Bart Westgeest
36ac9b055f staging: usbip: replaced pointer arithmetic, and strongly type function return.
Replaced pointer arithmetic by using array indexing, and changed
function return type for usbip_alloc_iso_desc_pdu from 'void*' to
'struct usbip_iso_packet_descriptor'.

Signed-off-by: Bart Westgeest <bart@elbrys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:36:28 -07:00
Devendra Naga
a297ad936e staging: crystalhd: fix a style warning
we dont need braces around a single statement blocks

style WARNINGS:
drivers/staging/crystalhd/crystalhd_cmds.c:311: WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:35:37 -07:00
Kevin Hilman
44b1d42a60 ARM: OMAP2: UART: fix console UART mismatched runtime PM status
The runtime PM framework assumes that the hardware state of devices
when initialized is disabled.  For all omap_devices, we idle/disable
device by default.  However, the console uart uses a "no idle" option
during omap_device init in order to allow earlyprintk usage to work
seamlessly during boot.

Because the hardware is left partially enabled after init (whatever
the bootloader settings were), the omap_device should later be fully
initialized (including mux) and the runtime PM framework should be
told that the device is active, and not disabled so that the hardware
state is in sync with runtime PM state.

To fix, after the device has been created/registered, call
omap_device_enable() to finialize init and use pm_runtime_set_active()
to tell the runtime PM core the device is enabled.

Tested on 2420/n810, 3530/Overo, 3530/Beagle, 3730/OveroSTORM,
3730/Beagle-xM, 4460/PandaES.

Suggested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
2012-10-22 13:35:17 -07:00
Paul Walmsley
856c3c5b28 ARM: OMAP3: PM: apply part of the erratum i582 workaround
On OMAP34xx/35xx, and OMAP36xx chips with ES < 1.2, if the PER
powerdomain goes to OSWR or OFF while CORE stays at CSWR or ON, or if,
upon chip wakeup from OSWR or OFF, the CORE powerdomain goes ON before
PER, the UART3/4 FIFOs and McBSP2/3 SIDETONE memories will be
unusable.  This is erratum i582 in the OMAP36xx Silicon Errata
document.

This patch implements one of several parts of the workaround: the
addition of the wakeup dependency between the PER and WKUP
clockdomains, such that PER will wake up at the same time CORE_L3
does.

This is not a complete workaround.  For it to be complete:

1. the PER powerdomain's next power state must not be set to OSWR or
   OFF if the CORE powerdomain's next power state is set to CSWR or
   ON;

2. the UART3/4 FIFO and McBSP2/3 SIDETONE loopback tests should be run
   if the LASTPOWERSTATEENTERED bits for PER and CORE indicate that
   PER went OFF while CORE stayed on.  If loopback tests fail, then
   those devices will be unusable until PER and CORE can undergo a
   transition from ON to OSWR/OFF and back ON.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
Signed-off-by: Kevin Hilman <khilman@ti.com>
2012-10-22 13:35:17 -07:00
Daniel Vetter
3b5c662e8f drm: extract dp link bw helpers
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2012-10-22 22:34:47 +02:00
Daniel Vetter
a7c9655fdd drm/i915: use the new dp train delay helpers
Only really required for dp 1.2. I've hoped this would help with some
link training woes I'm fighting, but alas those are only dp 1.1
devices.

Also move a comment that went misplaced in the recent refactorings to
the right spot again.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2012-10-22 22:34:46 +02:00
Daniel Vetter
1a644cd47c drm: extract dp link train delay functions from radeon
This requires a few changes since that dpcd value is above the
range currently cached by radeon. I've check the dp specs, and
above 0xf there's a big gap and nothing that looks like we should
cache it while a given device is plugged in. It's also the same value
that i915.ko uses.

Hence extend the various dpcd arrays in the radeon driver, use
proper symbolic constants where applicable (one place overallocated
the dpcd array to 25 bytes). Then also drop the rd_interval cache -
radeon_dp_link_train_init re-reads the dpcd block, so the values we'll
consume in train_cr and train_ce will always be fresh.

To avoid needless diff-churn, #define the old size of dpcd as the new
one and keep it around.

v2: Alex Deucher noticed one place where I've forgotten to replace 8
with DP_RECEIVER_CAP_SIZE.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2012-10-22 22:34:46 +02:00
Daniel Vetter
0f037bdee1 drm: extract helpers to compute new training values from sink request
Safe for the minor difference that the intel versions get an offset
into the link_status as an argument, both are the same again.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2012-10-22 22:34:45 +02:00
Daniel Vetter
01916270b8 drm: dp helper: extract drm_dp_clock_recovery_ok
radeon and intel use the exact same definition.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Dave Airlie <airlied@gmail.com>

v2: Kill 2 more helpers in intel_dp.c that I've missed.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
2012-10-22 22:34:37 +02:00
Wei Yongjun
605fba82a2 staging: r8712u: fix potential NULL pointer dereference in r871x_wps_start()
The dereference should be moved below the NULL test.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:30:01 -07:00
Wei Yongjun
a5e0f69c98 Staging: ced1401: fix missing unlock on error in FreeCircBlock()
Add the missing unlock on the error handle path in function
FreeCircBlock().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:28:43 -07:00
Devendra Naga
7d82c65f04 staging: ced1401: remove kernel version ifdef 's
We dont need these kernel versioning checks anyways.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:28:13 -07:00
Devendra Naga
0965be3964 staging: ced1401: fix some style warnings
this fixes:

comments to in kernel comment style
the opening brace of if statement must be beside the if not below
to it

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:28:13 -07:00
Devendra Naga
ff549e4772 staging: ced1401: remove an obvious commit about the minor number
in disconnect we assign the device minor number from the interface
pointer to the localvarible minor, and then print it at the end,

this code seems self explanatory so remove the comment of assigning
the minor number to a local variable.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 13:28:12 -07:00