Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Mike Christie 27354cbd69 vhost-scsi: Fix log flooding with target does not exist errors ... [ Upstream commit 69cd720a8a ] As part of the normal initiator side scanning the guest's scsi layer will loop over all possible targets and send an inquiry. Since the max number of targets for virtio-scsi is 256, this can result in 255 error messages about targets not existing if you only have a single target. When there's more than 1 vhost-scsi device each with a single target, then you get N * 255 log messages. It looks like the log message was added by accident in: commit 3f8ca2e115 ("vhost/scsi: Extract common handling code from control queue handler") when we added common helpers. Then in: commit 09d7583294 ("vhost/scsi: Use common handling code in request queue handler") we converted the scsi command processing path to use the new helpers so we started to see the extra log messages during scanning. The patches were just making some code common but added the vq_err call and I'm guessing the patch author forgot to enable the vq_err call (vq_err is implemented by pr_debug which defaults to off). So this patch removes the call since it's expected to hit this path during device discovery. Fixes: 09d7583294 ("vhost/scsi: Use common handling code in request queue handler") Signed-off-by: Mike Christie <michael.christie@oracle.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20250611210113.10912-1-michael.christie@oracle.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		History 2025-08-28 16:24:11 +02:00
..
iotlb.c	vhost: handle error while adding split ranges to iotlb	2022-04-08 14:24:12 +02:00
Kconfig	vhost_vdpa: implement IRQ offloading in vhost_vdpa	2020-08-05 11:08:42 -04:00
Makefile	vhost: introduce vDPA-based backend	2020-04-02 10:41:40 -04:00
net.c	vhost_net: revert upend_idx only on retriable error	2023-06-28 10:29:53 +02:00
scsi.c	vhost-scsi: Fix log flooding with target does not exist errors	2025-08-28 16:24:11 +02:00
test.c	tools/virtio: Add --reset	2020-06-22 12:34:21 -04:00
test.h	tools/virtio: Add --reset	2020-06-22 12:34:21 -04:00
vdpa.c	vhost_vdpa: assign irq bypass producer token correctly	2024-10-17 15:11:06 +02:00
vhost.c	vhost: Add smp_rmb() in vhost_vq_avail_empty()	2024-04-17 11:15:16 +02:00
vhost.h	vhost: support PACKED when setting-getting vring_base	2023-06-14 11:13:09 +02:00
vringh.c	vringh: don't use vringh_kiov_advance() in vringh_iov_xfer()	2023-10-10 21:59:05 +02:00
vsock.c	vhost/vsock: always initialize seqpacket_allow	2024-08-19 05:45:06 +02:00