Reference in a new issue

Blame

Copy permalink

Reference in a new issue

Copy permalink

Cezary Rojewski 2ff28b22a3 ASoC: Intel: skl_hda_dsp_common: Fix global-out-of-bounds bug ... commit 15adb20f64 upstream. Definitions for idisp snd_soc_dai_links within skl_hda_dsp_common are missing platform component. Add it to address following bug reported by KASAN: [ 10.538502] BUG: KASAN: global-out-of-bounds in skl_hda_audio_probe+0x13a/0x2b0 [snd_soc_skl_hda_dsp] [ 10.538509] Write of size 8 at addr ffffffffc0606840 by task systemd-udevd/299 (...) [ 10.538519] Call Trace: [ 10.538524] dump_stack+0x62/0x95 [ 10.538528] print_address_description+0x2f5/0x3b0 [ 10.538532] ? skl_hda_audio_probe+0x13a/0x2b0 [snd_soc_skl_hda_dsp] [ 10.538535] __kasan_report+0x134/0x191 [ 10.538538] ? skl_hda_audio_probe+0x13a/0x2b0 [snd_soc_skl_hda_dsp] [ 10.538542] ? skl_hda_audio_probe+0x13a/0x2b0 [snd_soc_skl_hda_dsp] [ 10.538544] kasan_report+0x12/0x20 [ 10.538546] __asan_store8+0x57/0x90 [ 10.538550] skl_hda_audio_probe+0x13a/0x2b0 [snd_soc_skl_hda_dsp] [ 10.538553] platform_drv_probe+0x51/0xb0 [ 10.538556] really_probe+0x311/0x600 [ 10.538559] driver_probe_device+0x87/0x1b0 [ 10.538562] device_driver_attach+0x8f/0xa0 [ 10.538565] ? device_driver_attach+0xa0/0xa0 [ 10.538567] __driver_attach+0x102/0x1a0 [ 10.538569] ? device_driver_attach+0xa0/0xa0 [ 10.538572] bus_for_each_dev+0xe8/0x160 [ 10.538574] ? subsys_dev_iter_exit+0x10/0x10 [ 10.538577] ? preempt_count_sub+0x18/0xc0 [ 10.538580] ? _raw_write_unlock+0x1f/0x40 [ 10.538582] driver_attach+0x2b/0x30 [ 10.538585] bus_add_driver+0x251/0x340 [ 10.538588] driver_register+0xd3/0x1c0 [ 10.538590] __platform_driver_register+0x6c/0x80 [ 10.538592] ? 0xffffffffc03e8000 [ 10.538595] skl_hda_audio_init+0x1c/0x1000 [snd_soc_skl_hda_dsp] [ 10.538598] do_one_initcall+0xd0/0x36a [ 10.538600] ? trace_event_raw_event_initcall_finish+0x160/0x160 [ 10.538602] ? kasan_unpoison_shadow+0x36/0x50 [ 10.538605] ? __kasan_kmalloc+0xcc/0xe0 [ 10.538607] ? kasan_unpoison_shadow+0x36/0x50 [ 10.538609] ? kasan_poison_shadow+0x2f/0x40 [ 10.538612] ? __asan_register_globals+0x65/0x80 [ 10.538615] do_init_module+0xf9/0x36f [ 10.538619] load_module+0x398e/0x4590 [ 10.538625] ? module_frob_arch_sections+0x20/0x20 [ 10.538628] ? __kasan_check_write+0x14/0x20 [ 10.538630] ? kernel_read+0x9a/0xc0 [ 10.538632] ? __kasan_check_write+0x14/0x20 [ 10.538634] ? kernel_read_file+0x1d3/0x3c0 [ 10.538638] ? cap_capable+0xca/0x110 [ 10.538642] __do_sys_finit_module+0x190/0x1d0 [ 10.538644] ? __do_sys_finit_module+0x190/0x1d0 [ 10.538646] ? __x64_sys_init_module+0x50/0x50 [ 10.538649] ? expand_files+0x380/0x380 [ 10.538652] ? __kasan_check_write+0x14/0x20 [ 10.538654] ? fput_many+0x20/0xc0 [ 10.538658] __x64_sys_finit_module+0x43/0x50 [ 10.538660] do_syscall_64+0xce/0x700 [ 10.538662] ? syscall_return_slowpath+0x230/0x230 [ 10.538665] ? __do_page_fault+0x51e/0x640 [ 10.538668] ? __kasan_check_read+0x11/0x20 [ 10.538670] ? prepare_exit_to_usermode+0xc7/0x200 [ 10.538673] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: a78959f407 ("ASoC: Intel: skl_hda_dsp_common: use modern dai_link style") Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Link: https://lore.kernel.org/r/20200122181254.22801-1-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		History 2020-02-11 04:37:21 -08:00
..
adi	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 177	2019-05-30 11:29:19 -07:00
amd	ASoC: AMD: Enable clk in startup intead of hw_params	2019-11-27 12:50:08 +00:00
atmel	ASoC: atmel: atmel-pcm-pdc: remove snd_pcm_ops	2019-10-08 13:42:57 +01:00
au1x	ASoC: Remove superfluous snd_dma_continuous_data()	2019-11-09 18:02:52 +01:00
bcm	ASoC: bcm: cygnus-pcm: remove snd_pcm_ops	2019-10-08 13:49:12 +01:00
cirrus	sound: Fix Kconfig indentation	2019-10-07 03:53:03 +02:00
codecs	ASoC: sgtl5000: Fix VDDA and VDDIO comparison	2020-02-11 04:37:21 -08:00
dwc	ASoC: Remove superfluous snd_dma_continuous_data()	2019-11-09 18:02:52 +01:00
fsl	ASoC: fsl_audmix: add missed pm_runtime_disable	2019-12-24 23:56:18 +00:00
generic	ASoC: simple-card: Don't create separate link when platform is present	2019-12-10 13:10:40 +00:00
hisilicon	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 340	2019-06-05 17:37:07 +02:00
img	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 422	2019-06-05 17:37:15 +02:00
intel	ASoC: Intel: skl_hda_dsp_common: Fix global-out-of-bounds bug	2020-02-11 04:37:21 -08:00
jz4740	ASoC: jz4740: Remove unused match variable	2019-10-09 10:58:01 +01:00
kirkwood	Merge branch 'for-5.4' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into asoc-5.5	2019-11-06 16:29:34 +00:00
mediatek	ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency	2019-10-23 17:45:34 +01:00
meson	ASoC: meson: axg-fifo: fix fifo threshold setup	2020-02-11 04:37:16 -08:00
mxs	ASoC: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:12:31 +01:00
pxa	sound updates for 5.5-rc1	2019-11-26 20:04:35 -08:00
qcom	ASoC: More updates for v5.5	2019-11-25 14:27:41 +01:00
rockchip	ASoC: Fixes for v5.4	2019-11-07 13:52:17 +01:00
samsung	sound updates for 5.5-rc1	2019-11-26 20:04:35 -08:00
sh	ASoC: More updates for v5.5	2019-11-25 14:27:41 +01:00
sirf	ASoC: sirf: use devm_platform_ioremap_resource() to simplify code	2019-07-31 12:05:39 +01:00
sof	ASoC: SOF: core: release resources on errors in probe_continue	2020-02-11 04:36:57 -08:00
spear	ASoC: spear: use devm_platform_ioremap_resource() to simplify code	2019-07-31 12:06:18 +01:00
sprd	ASoC: sprd: sprd-pcm-dma: remove snd_pcm_ops	2019-10-08 13:44:40 +01:00
sti	ASoC: sti: fix possible sleep-in-atomic	2020-01-13 15:12:26 +00:00
stm	ASoC: stm32: dfsdm: fix 16 bits record	2020-01-10 13:30:10 +00:00
sunxi	ASoC: sunxi: sun4i-codec: remove unneeded semicolon	2019-10-28 13:12:39 +00:00
tegra	ASoC: tegra: Revert 24 and 32 bit support	2020-02-11 04:36:52 -08:00
ti	ASoC: ti: davinci-mcasp: Use dma_request_chan() directly for channel request	2019-11-15 12:03:16 +00:00
txx9	ASoC: txx9: txx9aclc: remove snd_pcm_ops	2019-10-08 13:44:23 +01:00
uniphier	ASoC: uniphier: aio-dma: remove snd_pcm_ops	2019-10-08 13:44:05 +01:00
ux500	ASoC: ux500: Remove redundant variable "status"	2019-11-04 13:22:25 +00:00
xilinx	ASoC: Updates for v5.5	2019-11-07 14:12:30 +01:00
xtensa	ASoC: xtensa: xtfpga-i2s: remove snd_pcm_ops	2019-10-08 13:43:25 +01:00
zte	sound: Fix Kconfig indentation	2019-10-07 03:53:03 +02:00
Kconfig	ASoC: remove w90x900/nuc900 platform drivers	2019-08-12 14:00:29 +01:00
Makefile	ASoC: remove w90x900/nuc900 platform drivers	2019-08-12 14:00:29 +01:00
soc-ac97.c	ASoC: ac97: convert to SPDX identifiers	2018-07-02 10:56:09 +01:00
soc-acpi.c	ASoC: soc-acpi: fix implicit header use of module.h/export.h	2019-05-08 18:06:28 +09:00
soc-component.c	ASoC: Fixes for v5.5	2020-01-16 14:14:26 +01:00
soc-compress.c	ASoC: core: Init pcm runtime work early to avoid warnings	2019-12-04 11:15:30 +00:00
soc-core.c	ASoC: core: Fix access to uninitialized list heads	2019-12-24 23:56:15 +00:00
soc-dai.c	ASoC: soc-dai: move snd_soc_dai_stream_valid() to soc-dai.c	2019-07-23 18:14:26 +01:00
soc-dapm.c	ASoC: soc-core: add snd_soc_dapm_init()	2019-09-02 13:21:20 +01:00
soc-devres.c	ASoC: soc-devres.c: convert to SPDX identifiers	2018-07-02 10:55:22 +01:00
soc-generic-dmaengine-pcm.c	ASoC: dmaengine: Use dma_request_chan() directly for channel request	2019-11-15 12:02:58 +00:00
soc-io.c	ASoC: soc-io.c: convert to SPDX identifiers	2018-07-02 10:53:55 +01:00
soc-jack.c	ASoC: Jack: Fix NULL pointer dereference in snd_soc_jack_report	2019-11-12 17:12:56 +00:00
soc-ops.c	ASoC: soc-ops: use snd_soc_card_get_kcontrol() at snd_soc_limit_volume()	2019-10-03 14:37:20 +01:00
soc-pcm.c	ASoC: Fixes for v5.5	2019-12-17 14:18:32 +01:00
soc-topology.c	ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order	2020-02-11 04:36:52 -08:00
soc-utils.c	ASoC: soc-utils: remove snd_pcm_ops	2019-10-08 13:50:43 +01:00