linux/drivers/scsi/mpi3mr
Guixin Liu 19b248069d scsi: mpi3mr: Fix possible crash when setting up bsg fails
[ Upstream commit 295006f6e8 ]

If bsg_setup_queue() fails, the bsg_queue is assigned a non-NULL value.
Consequently, in mpi3mr_bsg_exit(), the condition "if(!mrioc->bsg_queue)"
will not be satisfied, preventing execution from entering
bsg_remove_queue(), which could lead to the following crash:

BUG: kernel NULL pointer dereference, address: 000000000000041c
Call Trace:
  <TASK>
  mpi3mr_bsg_exit+0x1f/0x50 [mpi3mr]
  mpi3mr_remove+0x6f/0x340 [mpi3mr]
  pci_device_remove+0x3f/0xb0
  device_release_driver_internal+0x19d/0x220
  unbind_store+0xa4/0xb0
  kernfs_fop_write_iter+0x11f/0x200
  vfs_write+0x1fc/0x3e0
  ksys_write+0x67/0xe0
  do_syscall_64+0x38/0x80
  entry_SYSCALL_64_after_hwframe+0x78/0xe2

Fixes: 4268fa7513 ("scsi: mpi3mr: Add bsg device support")
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Link: https://lore.kernel.org/r/20250107022032.24006-1-kanie@linux.alibaba.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
History 2025-02-08 09:57:57 +01:00
..
mpi scsi: mpi3mr: Update MPI Headers to revision 34 2024-09-12 21:10:13 -04:00
Kconfig scsi: mpi3mr: Select CONFIG_SCSI_SAS_ATTRS 2022-10-22 03:14:51 +00:00
Makefile scsi: mpi3mr: Refer CONFIG_SCSI_MPI3MR in Makefile 2022-12-14 03:01:38 +00:00
mpi3mr.h scsi: mpi3mr: Fix corrupt config pages PHY state is switched in sysfs 2025-01-02 10:34:19 +01:00
mpi3mr_app.c scsi: mpi3mr: Fix possible crash when setting up bsg fails 2025-02-08 09:57:57 +01:00
mpi3mr_debug.h scsi: mpi3mr: Update copyright year 2023-03-16 23:54:29 -04:00
mpi3mr_fw.c scsi: mpi3mr: Handling of fault code for insufficient power 2025-01-02 10:34:19 +01:00
mpi3mr_os.c scsi: mpi3mr: Start controller indexing from 0 2025-01-02 10:34:19 +01:00
mpi3mr_transport.c scsi: mpi3mr: Validate SAS port assignments 2024-10-15 22:17:17 -04:00