linux/drivers/net/can
Marc Kleine-Budde 86bc2c660b can: netlink: can_changelink(): allow disabling of automatic restart
commit 8e93ac51e4 upstream.

Since the commit c1f3f9797c ("can: netlink: can_changelink(): fix NULL
pointer deref of struct can_priv::do_set_mode"), the automatic restart
delay can only be set for devices that implement the restart handler struct
can_priv::do_set_mode. As it makes no sense to configure a automatic
restart for devices that doesn't support it.

However, since systemd commit 13ce5d4632e3 ("network/can: properly handle
CAN.RestartSec=0") [1], systemd-networkd correctly handles a restart delay
of "0" (i.e. the restart is disabled). Which means that a disabled restart
is always configured in the kernel.

On systems with both changes active this causes that CAN interfaces that
don't implement a restart handler cannot be brought up by systemd-networkd.

Solve this problem by allowing a delay of "0" to be configured, even if the
device does not implement a restart handler.

[1] 13ce5d4632

Cc: stable@vger.kernel.org
Cc: Andrei Lalaev <andrey.lalaev@gmail.com>
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Closes: https://lore.kernel.org/all/20251020-certain-arrogant-vole-of-sunshine-141841-mkl@pengutronix.de
Fixes: c1f3f9797c ("can: netlink: can_changelink(): fix NULL pointer deref of struct can_priv::do_set_mode")
Link: https://patch.msgid.link/20251020-netlink-fix-restart-v1-1-3f53c7f8520b@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
History 2025-10-29 14:08:56 +01:00
..
c_can can: c_can: Use of_property_present() to test existence of DT property 2025-05-29 11:02:45 +02:00
cc770 can: {cc770,sja1000}_isa: allow building on x86_64 2024-11-04 17:46:06 +01:00
ctucanfd can: ctucanfd: handle skb allocation failure 2025-02-21 14:01:33 +01:00
dev can: netlink: can_changelink(): allow disabling of automatic restart 2025-10-29 14:08:56 +01:00
esd can: esd: acc_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb() 2025-10-29 14:08:54 +01:00
flexcan can: flexcan: add NXP S32G2/S32G3 SoC support 2025-04-20 10:15:18 +02:00
ifi_canfd can: ifi_canfd: ifi_canfd_handle_lec_err(): fix {rx,tx}_errors statistics 2024-12-14 20:03:01 +01:00
m_can can: m_can: fix CAN state in system PM 2025-10-23 16:20:28 +02:00
mscan can: Switch back to struct platform_driver::remove() 2024-09-11 09:37:16 +02:00
peak_canfd can: peak_canfd: Remove setting of RX software timestamp 2024-09-03 15:17:47 -07:00
rcar can: rcar_canfd: Fix controller mode setting 2025-10-12 12:57:17 +02:00
rockchip can: rockchip-canfd: rkcanfd_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb() 2025-10-29 14:08:54 +01:00
sja1000 can: sja1000: sja1000_err(): fix {rx,tx}_errors statistics 2024-12-14 20:03:02 +01:00
slcan can: slcan: allow reception of short error messages 2025-05-29 11:03:19 +02:00
softing can: Switch back to struct platform_driver::remove() 2024-09-11 09:37:16 +02:00
spi can: hi311x: fix null pointer dereference when resuming from sleep before interface was enabled 2025-10-12 12:57:17 +02:00
usb can: gs_usb: increase max interface to U8_MAX 2025-10-23 16:20:21 +02:00
at91_can.c can: Switch back to struct platform_driver::remove() 2024-09-11 09:37:16 +02:00
bxcan.c can: bxcan: bxcan_start_xmit(): use can_dev_dropped_skb() instead of can_dropped_invalid_skb() 2025-10-29 14:08:54 +01:00
can327.c tty: use u8 for flags 2023-08-11 21:12:45 +02:00
grcan.c can: Switch back to struct platform_driver::remove() 2024-09-11 09:37:16 +02:00
janz-ican3.c can: Switch back to struct platform_driver::remove() 2024-09-11 09:37:16 +02:00
Kconfig can: rockchip_canfd: add driver for Rockchip CAN-FD controller 2024-09-04 14:41:51 +02:00
kvaser_pciefd.c can: kvaser_pciefd: Store device channel index 2025-08-15 12:13:47 +02:00
Makefile can: rockchip_canfd: add driver for Rockchip CAN-FD controller 2024-09-04 14:41:51 +02:00
sun4i_can.c can: sun4i_can: populate ndo_change_mtu() to prevent buffer overflow 2025-10-02 13:44:09 +02:00
ti_hecc.c Revert "can: ti_hecc: fix -Woverflow compiler warning" 2025-08-28 16:31:05 +02:00
vcan.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
vxcan.c net: annotate writes on dev->mtu from ndo_change_mtu() 2024-05-07 16:19:14 -07:00
xilinx_can.c can: xilinx_can: xcan_write_frame(): fix use-after-free of transmitted SKB 2025-09-19 16:35:49 +02:00